public inbox for [email protected]  
help / color / mirror / Atom feed
From: Jon Wolski <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: removal of md5 from example code
Date: Thu, 1 Feb 2018 19:23:31 -0600
Message-ID: <CABZG8z866RH733UWbKA-oD5J4XE0kQc-LfBrDV+fF=4U=bAsgw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

I think I get it, now.

Is the reason for including the `pass` in the example so that the
documentation can demonstrate `citext` along side case-sensitive text?

If so, I struggle to come up with anything more obvious than a password
hash for a case where case-sensitive comparison of text is necessary. The
only other thing that comes to mind is an external system identifier like a
Salesforce object id of a user. That would not be as universally obvious an
example of case-sensitivity to all PostgreSQL users..

On Tue, Jan 30, 2018 at 10:02 PM, Peter Eisentraut <
[email protected]> wrote:

> On 1/17/18 11:14, PG Doc comments form wrote:
> > The documentation at
> > https://www.postgresql.org/docs/current/static/citext.html shows an
> example
> > using md5 for password hashes. This is generally a bad practice and not
> > relevant to the feature documented.
> >
> > I recommend removing the password column from this example or replacing
> the
> > md5 hash with something more secure (a secure hash algorithm with a
> salt).
>
> We don't have any other hash functions built in and exposed at the SQL
> level.  (Maybe that is a problem.)  Do you have any other ideas how to
> rewrite that example?
>
> --
> Peter Eisentraut              http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>


view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: removal of md5 from example code
  In-Reply-To: <CABZG8z866RH733UWbKA-oD5J4XE0kQc-LfBrDV+fF=4U=bAsgw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox