public inbox for [email protected]  
help / color / mirror / Atom feed
From: Clément Prévost <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: Documentation on information_ schema columns that does not exist
Date: Mon, 1 Jun 2015 02:27:16 +0200
Message-ID: <CABaKae8G=XNgsQW6eFzkjbQ4d=05L0siddRp1R6dMVZJtYwixA@mail.gmail.com> (raw)
In-Reply-To: <CABaKae8UVSGwyQ-QFKxsk9obqyBpYOsCfgO_jNP_Y8iTJOuJxw@mail.gmail.com>
References: <CABaKae8+p6=zhCM=Qrq_GMN88pFqjb5EgHpy9bjGaKZfvJmzZA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CABaKae8UVSGwyQ-QFKxsk9obqyBpYOsCfgO_jNP_Y8iTJOuJxw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

Here is another patch to fix the name of the column
information_schema.routines.result_cast_char_set_name that was mistakenly
named result_cast_character_set_name.

regards, clément prévost

On 1 June 2015 at 01:25, Clément Prévost <[email protected]> wrote:

> Well spotted!
>
> I attached 2 patches: 1 to fix erroneous documentation and the other to
> fix information schema types.
>
> regards, clément prévost
>
> On 1 June 2015 at 00:14, Tom Lane <[email protected]> wrote:
>
>> I wrote:
>> > Another problem in the same area is that the column types of
>> > foreign_table_schema and foreign_table_name seem to be "name":
>>
>> Further pursuant to that, these are the information_schema columns
>> that don't seem to have been cast to the spec-required type:
>>
>>  column_options            | column_name          | name
>>  column_options            | table_name           | name
>>  column_options            | table_schema         | name
>>  foreign_table_options     | foreign_table_name   | name
>>  foreign_table_options     | foreign_table_schema | name
>>  foreign_tables            | foreign_table_name   | name
>>  foreign_tables            | foreign_table_schema | name
>>
>>                         regards, tom lane
>>
>
>


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Attachments:

  [application/octet-stream] conform-information-schema-routines-unused-field-to-spec.patch (866B, 3-conform-information-schema-routines-unused-field-to-spec.patch)
  download | inline diff:
diff --git a/src/backend/catalog/information_schema.sql b/src/backend/catalog/information_schema.sql
index b7aa3e3..5efed4f 100644
--- a/src/backend/catalog/information_schema.sql
+++ b/src/backend/catalog/information_schema.sql
@@ -1463,7 +1463,7 @@ CREATE VIEW routines AS
            CAST(null AS cardinal_number) AS result_cast_char_octet_length,
            CAST(null AS sql_identifier) AS result_cast_char_set_catalog,
            CAST(null AS sql_identifier) AS result_cast_char_set_schema,
-           CAST(null AS sql_identifier) AS result_cast_character_set_name,
+           CAST(null AS sql_identifier) AS result_cast_char_set_name,
            CAST(null AS sql_identifier) AS result_cast_collation_catalog,
            CAST(null AS sql_identifier) AS result_cast_collation_schema,
            CAST(null AS sql_identifier) AS result_cast_collation_name,


view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Documentation on information_ schema columns that does not exist
  In-Reply-To: <CABaKae8G=XNgsQW6eFzkjbQ4d=05L0siddRp1R6dMVZJtYwixA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox