MIME-Version: 1.0
References: <162283882930.14468.5063555039238144271@wrigleys.postgresql.org>
 <507137.1622852350@sss.pgh.pa.us>
In-Reply-To: <507137.1622852350@sss.pgh.pa.us>
From: Eric Mutta <eric.mutta@gmail.com>
Date: Sat, 5 Jun 2021 14:37:56 +0300
Message-ID: 
 <CABb8_QYQb1RwFeNi2PM-zo8r4G=yv2d1hnStLyMDXWBxK_qvbw@mail.gmail.com>
Subject: Re: Typo in "13.2.3. Serializable Isolation Level"
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-docs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000056c66c05c4033f6d"
Archived-At: 
 <https://www.postgresql.org/message-id/CABb8_QYQb1RwFeNi2PM-zo8r4G%3Dyv2d1hnStLyMDXWBxK_qvbw%40mail.gmail.com>
Precedence: bulk

--00000000000056c66c05c4033f6d
Content-Type: text/plain; charset="UTF-8"

> That sentence is a suggestion of an action for the reader to take,
conditionally upon verifying that such things are no longer necessary.

I see, that makes sense now, I was parsing the sentence differently.
Perhaps for clarity those explicit locks could be mentioned in brackets so
the sentence reads:

> "Eliminate explicit locks (SELECT FOR UPDATE and SELECT FOR SHARE) where
no longer needed due to the protections automatically provided by
Serializable transactions."

That way, the intent of "where no longer needed" being a conditional
suggestion is closely connected to the "eliminate explicit locks"
instruction. Essentially without the bracketed part it would read:

  > "Eliminate explicit locks...where no longer needed..."

I believe adding brackets would help but in any case, it's not a big deal
and I extend my thanks to all the people working on the Postgres docs (as a
new user adopting Postgres for my next take-over-the-world project, the
comprehensive docs are pure gold!).

Many thanks,
Eric Mutta.

On Sat, Jun 5, 2021 at 3:19 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> PG Doc comments form <noreply@postgresql.org> writes:
> > The following sentence:
>
> >> Eliminate explicit locks, SELECT FOR UPDATE, and SELECT FOR SHARE where
> no
> > longer needed due...
>
> > Uses the word "where" when it should probably use the word "are" and thus
> > read:
>
> > Eliminate explicit locks, SELECT FOR UPDATE, and SELECT FOR SHARE are no
> > longer needed due...
>
> Hmm, I don't think so.  That sentence is a suggestion of an action
> for the reader to take, conditionally upon verifying that such things
> are no longer necessary.  Your wording would turn it into an assertion
> that no such things are necessary anywhere.  That seems (a) probably
> wrong and (b) not grammatically consistent with the other entries in
> that bullet list.
>
>                         regards, tom lane
>

--00000000000056c66c05c4033f6d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">&gt; That sentence is a suggestion of an =
action for the reader to take, conditionally upon verifying that such thing=
s are no longer necessary.</div><div dir=3D"ltr"><br></div><div>I see, that=
 makes sense now, I was parsing the sentence differently. Perhaps for clari=
ty those explicit locks could be mentioned in brackets so the sentence read=
s:</div><div><br></div><div>&gt; &quot;Eliminate explicit locks (SELECT FOR=
 UPDATE and SELECT FOR SHARE) where no longer needed due to the protections=
 automatically provided by Serializable transactions.&quot;<br></div><div><=
br></div><div>That way, the intent of &quot;where no longer needed&quot; be=
ing a conditional suggestion is closely connected to the &quot;eliminate ex=
plicit locks&quot; instruction. Essentially without the bracketed part it w=
ould read:</div><div><br></div><div>=C2=A0 &gt; &quot;Eliminate explicit lo=
cks...where no longer needed...&quot;=C2=A0<br></div><div><br></div><div>I =
believe adding brackets would help but in any case, it&#39;s not a big deal=
 and I extend my thanks to all the people working on the Postgres docs (as =
a new user adopting Postgres for my next=C2=A0take-over-the-world project, =
the comprehensive docs are pure gold!).</div><div><br></div><div>Many thank=
s,</div><div>Eric Mutta.</div><div>=C2=A0=C2=A0<br></div><div><div class=3D=
"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Jun 5, 2021 at =
3:19 AM Tom Lane &lt;<a href=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us=
</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
PG Doc comments form &lt;<a href=3D"mailto:noreply@postgresql.org" target=
=3D"_blank">noreply@postgresql.org</a>&gt; writes:<br>
&gt; The following sentence:<br>
<br>
&gt;&gt; Eliminate explicit locks, SELECT FOR UPDATE, and SELECT FOR SHARE =
where no<br>
&gt; longer needed due...<br>
<br>
&gt; Uses the word &quot;where&quot; when it should probably use the word &=
quot;are&quot; and thus<br>
&gt; read:<br>
<br>
&gt; Eliminate explicit locks, SELECT FOR UPDATE, and SELECT FOR SHARE are =
no<br>
&gt; longer needed due...<br>
<br>
Hmm, I don&#39;t think so.=C2=A0 That sentence is a suggestion of an action=
<br>
for the reader to take, conditionally upon verifying that such things<br>
are no longer necessary.=C2=A0 Your wording would turn it into an assertion=
<br>
that no such things are necessary anywhere.=C2=A0 That seems (a) probably<b=
r>
wrong and (b) not grammatically consistent with the other entries in<br>
that bullet list.<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 regards, tom lane<br>
</blockquote></div></div></div>

--00000000000056c66c05c4033f6d--