MIME-Version: 1.0
References: 
 <CACJufxG3M3W0Da+yRmu0Wj8mTUDTiEhtScsDFHb5xKfcDXWSZg@mail.gmail.com>
 <CAKFQuwbzmyEfdJ=LHeBEy0H1A2OYvWu-sOxsG+_qQc+ZZiOJog@mail.gmail.com>
In-Reply-To: 
 <CAKFQuwbzmyEfdJ=LHeBEy0H1A2OYvWu-sOxsG+_qQc+ZZiOJog@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Thu, 18 Sep 2025 17:03:10 +0800
Message-ID: 
 <CACJufxHmS+S8=4ikGW3_85TLgD_v+WXvabSXP8QGGdD+rRWNZg@mail.gmail.com>
Subject: Re: CREATE TABLE LIKE(INCLUDING COMMENTS) description ignored
 STATISTICS
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxHmS%2BS8%3D4ikGW3_85TLgD_v%2BWXvabSXP8QGGdD%2BrRWNZg%40mail.gmail.com>
Precedence: bulk

On Sun, Sep 7, 2025 at 1:03=E2=80=AFPM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Saturday, September 6, 2025, jian he <jian.universality@gmail.com> wro=
te:
>>
>> hi.
>>
>> https://www.postgresql.org/docs/devel/sql-createtable.html#SQL-CREATETAB=
LE-PARMS-LIKE-OPT-COMMENTS
>> """
>> INCLUDING COMMENTS
>> Comments for the copied columns, constraints, and indexes will be copied=
. The
>> default behavior is to exclude comments, resulting in the copied columns=
 and
>> constraints in the new table having no comments.
>> """
>>
>> The above description should mention that comments on extended
>> statistics will be
>> copied as well?
>>
>
> How about =E2=80=9CIf specified, existing comments on any copied elements=
 are copied as well.=E2=80=9D ?  Let=E2=80=99s fix this by removing the dup=
lication of the list of things allowed to be copied, not by fixing the over=
sight the duplication permitted.
>

=E2=80=9CIf specified, existing comments on any copied elements are copied =
as well.=E2=80=9D
some properties/elements don't have comments.

currently doc:
-------------------------------------------------
The optional like_option clauses specify which additional properties
of the original table to copy. Specifying INCLUDING copies the
property, specifying EXCLUDING omits the property. EXCLUDING is the
default. If multiple specifications are made for the same kind of
object, the last one is used. The available options are:

INCLUDING COMMENTS
Comments for the copied columns, constraints, and indexes will be
copied. The default behavior is to exclude comments, resulting in the
copied columns and constraints in the new table having no comments.

------------------------------------------------------------------------
The second sentence is redundant, because we already mentioned:
"EXCLUDING is the default".
So I am ok with:
"Comments for the copied columns, constraints, extended statistics and
 indexes will be copied".
the second sentence "The default behavior is to exclude comments...."
can be removed.

I also found that
https://www.postgresql.org/docs/devel/sql-createforeigntable.html
has the same problem.