MIME-Version: 1.0
References: <1591471729.4432635.1622706561235.ref@mail.yahoo.com>
 <1591471729.4432635.1622706561235@mail.yahoo.com>
In-Reply-To: <1591471729.4432635.1622706561235@mail.yahoo.com>
From: Dave Cramer <davecramer@postgres.rocks>
Date: Thu, 3 Jun 2021 06:31:41 -0400
Message-ID: 
 <CADK3HHJU+V8+yK167j-4cxb7sKrvH1zcLeyfee-Qu0AG9tc-cg@mail.gmail.com>
Subject: Re: Default value for the defaultAutoCommit property
To: Celinio Fer <celfersup@yahoo.com>
Cc: pgsql-docs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000ab1b4905c3da159e"
Archived-At: 
 <https://www.postgresql.org/message-id/CADK3HHJU%2BV8%2ByK167j-4cxb7sKrvH1zcLeyfee-Qu0AG9tc-cg%40mail.gmail.com>
Precedence: bulk

--000000000000ab1b4905c3da159e
Content-Type: text/plain; charset="UTF-8"

Good catch.

Thanks, I will fix that.
Dave Cramer
www.postgres.rocks


On Thu, 3 Jun 2021 at 03:49, Celinio Fer <celfersup@yahoo.com> wrote:

> Hi,
> I wonder if the documentation for the JDBC PostgreSQL driver is up to date
> :
> https://jdbc.postgresql.org/documentation/head/ds-cpds.html#ds-cpds-props
> It is written that the default value for the defaultAutoCommit  property
> is false.
>
> However in the source code, the default value is true :
>
> https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/ds/PGConnectionPoolDataSource.java
>
> private boolean defaultAutoCommit = true;
> ...
> /**
>    * Gets whether connections supplied by this pool will have autoCommit
> turned on by default. The
>    * default value is {@code true}, so that autoCommit will be turned on
> by default.
>    *
>    * @return true if connections supplied by this pool will have autoCommit
>    */
>   public boolean isDefaultAutoCommit() {
>     return defaultAutoCommit;
>   }
>
> Did i miss something ?
> Thanks
> Celinio
>
>
>

--000000000000ab1b4905c3da159e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Good catch.<div><br></div><div>Thanks, I will fix that.<br=
 clear=3D"all"><div><div dir=3D"ltr" class=3D"gmail_signature" data-smartma=
il=3D"gmail_signature"><div dir=3D"ltr">Dave Cramer<div>www.postgres.rocks<=
/div></div></div></div><br></div></div><br><div class=3D"gmail_quote"><div =
dir=3D"ltr" class=3D"gmail_attr">On Thu, 3 Jun 2021 at 03:49, Celinio Fer &=
lt;<a href=3D"mailto:celfersup@yahoo.com">celfersup@yahoo.com</a>&gt; wrote=
:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.=
8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
I wonder if the documentation for the JDBC PostgreSQL driver is up to date =
:<br>
<a href=3D"https://jdbc.postgresql.org/documentation/head/ds-cpds.html#ds-c=
pds-props" rel=3D"noreferrer" target=3D"_blank">https://jdbc.postgresql.org=
/documentation/head/ds-cpds.html#ds-cpds-props</a><br>
It is written that the default value for the defaultAutoCommit=C2=A0 proper=
ty=C2=A0 is false.<br>
<br>
However in the source code, the default value is true :<br>
<a href=3D"https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/jav=
a/org/postgresql/ds/PGConnectionPoolDataSource.java" rel=3D"noreferrer" tar=
get=3D"_blank">https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main=
/java/org/postgresql/ds/PGConnectionPoolDataSource.java</a><br>
<br>
private boolean defaultAutoCommit =3D true;<br>
...<br>
/**<br>
=C2=A0 =C2=A0* Gets whether connections supplied by this pool will have aut=
oCommit turned on by default. The<br>
=C2=A0 =C2=A0* default value is {@code true}, so that autoCommit will be tu=
rned on by default.<br>
=C2=A0 =C2=A0*<br>
=C2=A0 =C2=A0* @return true if connections supplied by this pool will have =
autoCommit<br>
=C2=A0 =C2=A0*/<br>
=C2=A0 public boolean isDefaultAutoCommit() {<br>
=C2=A0 =C2=A0 return defaultAutoCommit;<br>
=C2=A0 }<br>
<br>
Did i miss something ?<br>
Thanks<br>
Celinio<br>
<br>
<br>
</blockquote></div>

--000000000000ab1b4905c3da159e--