MIME-Version: 1.0
References: 
 <CADkLM=eP6HOeqDjn0FdXuGRusQu4oWH_LFsKjjafmhvWD=aSpQ@mail.gmail.com>
 <alpine.DEB.2.21.1911090904410.31344@lancre>
 <20191125075507.GH99720@paquier.xyz>
 <CADkLM=fx_kNCCz97HSXMBgTSY50Es_czsNZJrdCBtpYiT_VLHA@mail.gmail.com>
 <CADkLM=cQ1D4pA8GmBBftg7R+qQnJDHEgLvmxG4HBV8F6r4eiKg@mail.gmail.com>
 <CAM-7Z-r5AZ_LxUi2Vs1_U-suM_iZRVgwBHow8Oh56QXu6Zk+0w@mail.gmail.com>
 <763ae38f-599b-cfb9-0447-337649dfb017@purtz.de>
In-Reply-To: <763ae38f-599b-cfb9-0447-337649dfb017@purtz.de>
From: Corey Huinker <corey.huinker@gmail.com>
Date: Wed, 11 Mar 2020 13:23:57 -0400
Message-ID: 
 <CADkLM=fuijXpnjnXaaRoYNQm_P5v1ToVpC3ZeSsePdzW_DtOtg@mail.gmail.com>
Subject: Re: Add A Glossary
To: =?UTF-8?Q?J=C3=BCrgen_Purtz?= <juergen@purtz.de>
Cc: Roger Harkavy <rogerharkavy@gmail.com>, pgsql-hackers@postgresql.org,
	Fabien COELHO <coelho@cri.ensmp.fr>, Michael Paquier <michael@paquier.xyz>
Content-Type: multipart/alternative; boundary="0000000000002f850d05a09781fb"
Precedence: bulk

--0000000000002f850d05a09781fb
Content-Type: text/plain; charset="UTF-8"

>
> It will be helpful for diff-ing to restrict the length of lines in the
> SGML files to 71 characters (as usual).


I did it that way for the following reasons
1. It aids grep-ability
2. The committers seem to be moving towards that for SQL strings, mostly
for reason #1
3. I recall that the code is put through a linter as one of the final steps
before release, I assumed that the SGML gets the same.
4. Even if #3 is false, its easy enough to do manually for me to do for
this one file once we've settled on the text of the definitions.

As for the changes, most things seem fine, I specifically like:
* Checkpoint - looks good
* yes, PGDATA should have been a literal
* Partition - the a/b split works for me
* Unlogged - it reads better

I'm not so sure on / responses to your ???s:
* The statement that names of schema objects are unique isn't *strictly* true,
just *mostly* true. Take the case of a unique constraints. The constraint
has a name and the unique index has the same name, to the point where
adding a unique constraint using an existing index renames that index to
conform to the constraint name.
* Serializable "other way around" question - It's both. Outside the
transaction you can't see changes made inside another transaction (though
you can be blocked by them), and inside serializable you can't see any
changes made since you started. Does that make sense? Were you asking a
different question?
* Transaction - yes, all those things could be "visible" or they could be
"side effects". It may be best to leave the over-simplified definition in
place, and add a "For more information see <<linref to
tutorial-transactions>>

--0000000000002f850d05a09781fb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">It will be helpful for diff-ing to restrict the length o=
f lines in the <br>
SGML files to 71 characters (as usual).</blockquote><div><br></div><div>I d=
id it that way for the following reasons</div><div>1. It aids grep-ability<=
/div><div>2. The committers seem to be moving towards that for SQL strings,=
 mostly for reason #1<br>3. I recall that the code is put through a linter =
as one of the final steps before release, I assumed that the SGML gets the =
same.</div><div>4. Even if #3 is false, its easy enough to do manually for =
me to do for this one file once we&#39;ve settled on the text of the defini=
tions.</div><div><br></div><div>As for the changes, most things seem fine, =
I specifically like:</div><div>* Checkpoint - looks good</div><div>* yes, P=
GDATA should have been a literal<br>* Partition - the a/b split works for m=
e</div><div>* Unlogged - it reads better<br><br>I&#39;m not so sure on / re=
sponses to your ???s:<br>* The statement that names of schema objects are u=
nique isn&#39;t <i>strictly</i>=C2=A0true, just <i>mostly</i>=C2=A0true. Ta=
ke the case of a unique constraints. The constraint has a name and the uniq=
ue index has the same name, to the point where adding a unique constraint u=
sing an existing index renames that index to conform to the constraint name=
.</div><div>* Serializable &quot;other way around&quot; question - It&#39;s=
 both. Outside the transaction you can&#39;t see changes made inside anothe=
r transaction (though you can be blocked by them), and inside serializable =
you can&#39;t see any changes made since you started. Does that make sense?=
 Were you asking a different question?</div><div>* Transaction - yes, all t=
hose things could be &quot;visible&quot; or they could be &quot;side effect=
s&quot;. It may be best to leave the over-simplified definition in place, a=
nd add a &quot;For more information see &lt;&lt;linref to tutorial-transact=
ions&gt;&gt;</div></div></div>

--0000000000002f850d05a09781fb--