public inbox for [email protected]help / color / mirror / Atom feed
doc: Fix missing or duplicate closing parentheses in some documents 4+ messages / 3 participants [nested] [flat]
* doc: Fix missing or duplicate closing parentheses in some documents @ 2025-11-07 01:40 Daisuke Higuchi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Daisuke Higuchi @ 2025-11-07 01:40 UTC (permalink / raw) To: [email protected] Hi I found that the parentheses seemed not to be handled correctly in following 3 documents, so I attach the patch for this. - closing parentheses is missing - doc/src/sgml/client-auth.sgml - closing parentheses is duplicate - doc/src/sgml/ltree.sgml - doc/src/sgml/trigger.sgml Regards Attachments: [application/octet-stream] doc_fix_missing_parentheses_client-auth.patch (888B, 3-doc_fix_missing_parentheses_client-auth.patch) download | inline diff: diff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgml index 51b95ed04f3..ec62cba8050 100644 --- a/doc/src/sgml/client-auth.sgml +++ b/doc/src/sgml/client-auth.sgml @@ -306,7 +306,7 @@ include_dir <replaceable>directory</replaceable> matches. The value <literal>all</literal> specifies that it matches all users. Otherwise, this is either the name of a specific database user, a regular expression (when starting with a slash - (<literal>/</literal>), or a group name preceded by <literal>+</literal>. + (<literal>/</literal>)), or a group name preceded by <literal>+</literal>. (Recall that there is no real distinction between users and groups in <productname>PostgreSQL</productname>; a <literal>+</literal> mark really means <quote>match any of the roles that are directly or indirectly members [application/octet-stream] doc_fix_duplicate_parentheses_trigger.patch (506B, 4-doc_fix_duplicate_parentheses_trigger.patch) download | inline diff: diff --git a/doc/src/sgml/trigger.sgml b/doc/src/sgml/trigger.sgml index bb1b5faf34e..0062f1a3fd1 100644 --- a/doc/src/sgml/trigger.sgml +++ b/doc/src/sgml/trigger.sgml @@ -823,7 +823,7 @@ typedef struct Trigger <varname>attnum</varname> (1-based) is a member of this bitmap set, call <literal>bms_is_member(attnum - FirstLowInvalidHeapAttributeNumber, - trigdata->tg_updatedcols))</literal>. + trigdata->tg_updatedcols)</literal>. </para> <para> [application/octet-stream] doc_fix_duplicate_parentheses_ltree.patch (691B, 5-doc_fix_duplicate_parentheses_ltree.patch) download | inline diff: diff --git a/doc/src/sgml/ltree.sgml b/doc/src/sgml/ltree.sgml index ecbf463d8ab..ff3c227727b 100644 --- a/doc/src/sgml/ltree.sgml +++ b/doc/src/sgml/ltree.sgml @@ -645,7 +645,7 @@ Europe & Russia*@ & !Transportation <literal>siglen</literal> determines the signature length in bytes. The default signature length is 8 bytes. The length must be a positive multiple of <type>int</type> alignment - (4 bytes on most machines)) up to 2024. Longer + (4 bytes on most machines) up to 2024. Longer signatures lead to a more precise search (scanning a smaller fraction of the index and fewer heap pages), at the cost of a larger index. </para> ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: doc: Fix missing or duplicate closing parentheses in some documents @ 2025-11-07 04:08 Erik Wienhold <[email protected]> parent: Daisuke Higuchi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Erik Wienhold @ 2025-11-07 04:08 UTC (permalink / raw) To: Daisuke Higuchi <[email protected]>; +Cc: [email protected] On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote: > I found that the parentheses seemed not to be handled correctly in > following 3 documents, so I attach the patch for this. > > - closing parentheses is missing > - doc/src/sgml/client-auth.sgml > > - closing parentheses is duplicate > - doc/src/sgml/ltree.sgml > - doc/src/sgml/trigger.sgml All three changes make sense. Although I would rephrase the part in client-auth.sgml from this: "a regular expression (when starting with a slash (<literal>/</literal>))" to this: "a regular expression starting with a slash (<literal>/</literal>)" The latter reads nicer IMO and avoids the double closing parenthesis which I find a bit awkward. -- Erik Wienhold ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: doc: Fix missing or duplicate closing parentheses in some documents @ 2025-11-07 04:39 Daisuke Higuchi <[email protected]> parent: Erik Wienhold <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Daisuke Higuchi @ 2025-11-07 04:39 UTC (permalink / raw) To: Erik Wienhold <[email protected]>; +Cc: [email protected] Thank you for checking! >"a regular expression (when starting with a slash (<literal>/</literal>))" >to this: >"a regular expression starting with a slash (<literal>/</literal>)" Yes, I agree with you. I also think this is easier to read. Regards, 2025年11月7日(金) 13:08 Erik Wienhold <[email protected]>: > On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote: > > I found that the parentheses seemed not to be handled correctly in > > following 3 documents, so I attach the patch for this. > > > > - closing parentheses is missing > > - doc/src/sgml/client-auth.sgml > > > > - closing parentheses is duplicate > > - doc/src/sgml/ltree.sgml > > - doc/src/sgml/trigger.sgml > > All three changes make sense. Although I would rephrase the part in > client-auth.sgml from this: > > "a regular expression (when starting with a slash (<literal>/</literal>))" > > to this: > > "a regular expression starting with a slash (<literal>/</literal>)" > > The latter reads nicer IMO and avoids the double closing parenthesis > which I find a bit awkward. > > -- > Erik Wienhold > ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: doc: Fix missing or duplicate closing parentheses in some documents @ 2025-11-08 03:19 Bruce Momjian <[email protected]> parent: Daisuke Higuchi <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Bruce Momjian @ 2025-11-08 03:19 UTC (permalink / raw) To: Daisuke Higuchi <[email protected]>; +Cc: Erik Wienhold <[email protected]>; [email protected] On Fri, Nov 7, 2025 at 01:39:07PM +0900, Daisuke Higuchi wrote: > Thank you for checking! > > >"a regular expression (when starting with a slash (<literal>/</literal>))" > >to this: > >"a regular expression starting with a slash (<literal>/</literal>)" > > Yes, I agree with you. I also think this is easier to read. Very good, patches applied with adjustment by Erik Wienhold. --------------------------------------------------------------------------- > > Regards, > > 2025年11月7日(金) 13:08 Erik Wienhold <[email protected]>: > > On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote: > > I found that the parentheses seemed not to be handled correctly in > > following 3 documents, so I attach the patch for this. > > > > - closing parentheses is missing > > - doc/src/sgml/client-auth.sgml > > > > - closing parentheses is duplicate > > - doc/src/sgml/ltree.sgml > > - doc/src/sgml/trigger.sgml > > All three changes make sense. Although I would rephrase the part in > client-auth.sgml from this: > > "a regular expression (when starting with a slash (<literal>/</literal>))" > > to this: > > "a regular expression starting with a slash (<literal>/</literal>)" > > The latter reads nicer IMO and avoids the double closing parenthesis > which I find a bit awkward. > > -- > Erik Wienhold > -- Bruce Momjian <[email protected]> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future. ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-11-08 03:19 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-07 01:40 doc: Fix missing or duplicate closing parentheses in some documents Daisuke Higuchi <[email protected]> 2025-11-07 04:08 ` Erik Wienhold <[email protected]> 2025-11-07 04:39 ` Daisuke Higuchi <[email protected]> 2025-11-08 03:19 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox