Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gBoFA-0000yG-Of for pgsql-docs@arkaria.postgresql.org; Sun, 14 Oct 2018 21:48:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gBoF7-0000yw-Jn for pgsql-docs@arkaria.postgresql.org; Sun, 14 Oct 2018 21:48:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gBoF7-0000yp-57 for pgsql-docs@lists.postgresql.org; Sun, 14 Oct 2018 21:48:09 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gBoF3-0003Vw-Pt for pgsql-docs@lists.postgresql.org; Sun, 14 Oct 2018 21:48:07 +0000 Received: by mail-wm1-x343.google.com with SMTP id 189-v6so16977457wmw.2 for ; Sun, 14 Oct 2018 14:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wJtmyXhuTcMoFQifn8SBzZypU8KBncr/+HMnTrMMvAU=; b=QfAxN2gNwyQxlaJYPWkhKNffhWs3xYJIFVR/REHuy5UJorva0O2PHqUK+DTdl07mcq uKPSERyVAVFzCyGu8u6bMAd62OQrCQBENqgY/QmXB3+EA+X2x9t93mvxUhH0MOvrtlm9 zghdFewhe1XcPee8niwKpqWuP2l9C7rpkcTwiQDZFUCh7UyZ+TDKWC5l0dFvip0YdAFY Cw89nBB52/8Zh5p/g0sYiq2s7cGhqnWHXxbsR8PxMcoJ60d7QhWj9Pb0HJPGnla9By0y NOP0Asy0sTPWlW0zYtQ/902bL5LjWNsQHQPzfv19GKtLnpZDJEUxMvqzP/YWZFS7pR5d 5UuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wJtmyXhuTcMoFQifn8SBzZypU8KBncr/+HMnTrMMvAU=; b=Q1gNhNqa8W9OF5Z/x/7swpWbM0nPxNZbfkLysL8drCdsnBb5/xeeNe2TmTo992IOk7 669JXvG4RnvgWarqCYMJPjoVa8gBSNNjqfblSuDWByf4C6Aht5jNjdzyOfHWFPq9JGgD ljugw9HiwGE4JL38jt5RlmrZPaokEmw7zat4K0CGWBXITEdrLArNvXHmkdgiwn4/Q3jK vX6sGXtSXj4o5uZyvhJEaGpfT1SFK98Mln6UnO7stRtuTJhaq2tmh6a2qY8qSy85S7sd 2W8NlqamIeSke/7l58Sb6NWSyiLne+xqxM124yCtQ6hhoQkmtdo8KE+x4OP5YkuFyqqu WIHg== X-Gm-Message-State: ABuFfoh4QS0jNyeioA5sl3/9Dn/RmQiVIGkTobBKPFiBfRN7a6+OVGdc /tgYUZ042mXXMKHNP4Vj4I5s6rYGmj4aEMQdoGVXmQ== X-Google-Smtp-Source: ACcGV636dyk0yJMWlzci5JhE6bPysaZ4m5E9T17X6uUVVh+/1eET+kF3DBoXHnjP90t3sRinzpvoBgrby7fQHkmTlGg= X-Received: by 2002:a1c:2846:: with SMTP id o67-v6mr10887084wmo.60.1539553684085; Sun, 14 Oct 2018 14:48:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Thomas Munro Date: Mon, 15 Oct 2018 10:47:27 +1300 Message-ID: Subject: Re: bloom documentation patch To: obartunov@postgrespro.ru Cc: pgsql-docs@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov wrote: > Please, consider attached patch, which improves contrib/bloom documentation. Hello Oleg, I have no comment on the technical details but here is some proof-reading of the English: + Length of each signature (index entry) in bits, it is rounded up to the nearest + multiple of 16. The default is 80 bits and maximum is s/, it is/. It is/ s/and maximum/and the maximum/ + Bloom AM doesn't supports unique indexes. s/supports/support/ + Bloom AM doesn't supports NULL values. s/supports/support/ -- Thomas Munro http://www.enterprisedb.com