public inbox for [email protected]
help / color / mirror / Atom feedDead link in ltree documentation
8+ messages / 5 participants
[nested] [flat]
* Dead link in ltree documentation
@ 2018-04-04 09:59 PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: PG Doc comments form @ 2018-04-04 09:59 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/static/ltree.html
Description:
Hi,
https://www.postgresql.org/docs/current/static/ltree.html links to
www.dmoz.org which now returns a 403, since being closed down in 2017.
Maybe it could link to the mirror https://dmoztools.net/ or the wikipedia
page instead.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Dead link in ltree documentation
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
@ 2018-04-04 12:46 ` Oleg Bartunov <[email protected]>
2018-04-04 19:06 ` Re: Dead link in ltree documentation Bruce Momjian <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Oleg Bartunov @ 2018-04-04 12:46 UTC (permalink / raw)
To: [email protected]; [email protected]
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
On Wed, Apr 4, 2018 at 12:59 PM, PG Doc comments form
<[email protected]> wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/10/static/ltree.html
> Description:
>
> Hi,
>
> https://www.postgresql.org/docs/current/static/ltree.html links to
> www.dmoz.org which now returns a 403, since being closed down in 2017.
>
> Maybe it could link to the mirror https://dmoztools.net/ or the wikipedia
> page instead.
Attached is a small patch.
Attachments:
[application/octet-stream] ltree.sgml.patch (481B, 2-ltree.sgml.patch)
download | inline diff:
--- ltree.sgml.orig 2017-12-20 16:40:26.000000000 +0300
+++ ltree.sgml 2018-04-04 15:43:01.000000000 +0300
@@ -34,7 +34,7 @@
length of a label path must be less than 65kB, but keeping it under 2kB is
preferable. In practice this is not a major limitation; for example,
the longest label path in the DMOZ catalog (<ulink
- url="http://www.dmoz.org"></ulink>) is about 240 bytes.
+ url="http://www.dmoztools.net"></ulink>) is about 271 bytes.
</para>
<para>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Dead link in ltree documentation
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
@ 2018-04-04 19:06 ` Bruce Momjian <[email protected]>
2018-04-04 20:02 ` Re: Dead link in ltree documentation David G. Johnston <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Bruce Momjian @ 2018-04-04 19:06 UTC (permalink / raw)
To: Oleg Bartunov <[email protected]>; +Cc: [email protected]; [email protected]
On Wed, Apr 4, 2018 at 03:46:06PM +0300, Oleg Bartunov wrote:
> Postgres Professional: http://www.postgrespro.com
> The Russian Postgres Company
>
>
> On Wed, Apr 4, 2018 at 12:59 PM, PG Doc comments form
> <[email protected]> wrote:
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/10/static/ltree.html
> > Description:
> >
> > Hi,
> >
> > https://www.postgresql.org/docs/current/static/ltree.html links to
> > www.dmoz.org which now returns a 403, since being closed down in 2017.
> >
> > Maybe it could link to the mirror https://dmoztools.net/ or the wikipedia
> > page instead.
>
> Attached is a small patch.
> --- ltree.sgml.orig 2017-12-20 16:40:26.000000000 +0300
> +++ ltree.sgml 2018-04-04 15:43:01.000000000 +0300
> @@ -34,7 +34,7 @@
> length of a label path must be less than 65kB, but keeping it under 2kB is
> preferable. In practice this is not a major limitation; for example,
> the longest label path in the DMOZ catalog (<ulink
> - url="http://www.dmoz.org"></ulink;) is about 240 bytes.
> + url="http://www.dmoztools.net"></ulink;) is about 271 bytes.
> </para>
>
> <para>
Patch applied back through 9.3. Thanks.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Dead link in ltree documentation
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
2018-04-04 19:06 ` Re: Dead link in ltree documentation Bruce Momjian <[email protected]>
@ 2018-04-04 20:02 ` David G. Johnston <[email protected]>
2018-04-04 20:13 ` Re: Dead link in ltree documentation David G. Johnston <[email protected]>
2018-04-04 20:17 ` Re: Dead link in ltree documentation Alvaro Herrera <[email protected]>
0 siblings, 2 replies; 8+ messages in thread
From: David G. Johnston @ 2018-04-04 20:02 UTC (permalink / raw)
To: Bruce Momjian <[email protected]>; +Cc: Oleg Bartunov <[email protected]>; [email protected]; [email protected]
On Wed, Apr 4, 2018 at 12:06 PM, Bruce Momjian <[email protected]> wrote:
> On Wed, Apr 4, 2018 at 03:46:06PM +0300, Oleg Bartunov wrote:
> > Postgres Professional: http://www.postgrespro.com
> > The Russian Postgres Company
> >
> >
> > On Wed, Apr 4, 2018 at 12:59 PM, PG Doc comments form
> > <[email protected]> wrote:
> > > The following documentation comment has been logged on the website:
> > >
> > > Page: https://www.postgresql.org/docs/10/static/ltree.html
> > > Description:
> > >
> > > Hi,
> > >
> > > https://www.postgresql.org/docs/current/static/ltree.html links to
> > > www.dmoz.org which now returns a 403, since being closed down in 2017.
> > >
> > > Maybe it could link to the mirror https://dmoztools.net/ or the
> wikipedia
> > > page instead.
> >
> > Attached is a small patch.
>
> > --- ltree.sgml.orig 2017-12-20 16:40:26.000000000 +0300
> > +++ ltree.sgml 2018-04-04 15:43:01.000000000 +0300
> > @@ -34,7 +34,7 @@
> > length of a label path must be less than 65kB, but keeping it under
> 2kB is
> > preferable. In practice this is not a major limitation; for example,
> > the longest label path in the DMOZ catalog (<ulink
> > - url="http://www.dmoz.org"></ulink;) is about 240 bytes.
> > + url="http://www.dmoztools.net"></ulink;) is about 271 bytes.
> > </para>
> >
> > <para>
>
> Patch applied back through 9.3. Thanks.
>
I'm not seeing the value in providing a link, especially one that we don't
control, here. Futhermore, we could probably drop the whole "In
practice..." sentence. But if not at least put a period after "limitation"
and drop the example and link.
David J.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Dead link in ltree documentation
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
2018-04-04 19:06 ` Re: Dead link in ltree documentation Bruce Momjian <[email protected]>
2018-04-04 20:02 ` Re: Dead link in ltree documentation David G. Johnston <[email protected]>
@ 2018-04-04 20:13 ` David G. Johnston <[email protected]>
1 sibling, 0 replies; 8+ messages in thread
From: David G. Johnston @ 2018-04-04 20:13 UTC (permalink / raw)
To: Bruce Momjian <[email protected]>; +Cc: Oleg Bartunov <[email protected]>; [email protected]; [email protected]
On Wed, Apr 4, 2018 at 1:02 PM, David G. Johnston <
[email protected]> wrote:
> On Wed, Apr 4, 2018 at 12:06 PM, Bruce Momjian <[email protected]> wrote:
>
FYI - Bruce's "I've committed this" email is the only one in the thread
that made it into my inbox...pgsql-docs emails seem to be getting swallowed
in the void sometimes.
David J.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Dead link in ltree documentation
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
2018-04-04 19:06 ` Re: Dead link in ltree documentation Bruce Momjian <[email protected]>
2018-04-04 20:02 ` Re: Dead link in ltree documentation David G. Johnston <[email protected]>
@ 2018-04-04 20:17 ` Alvaro Herrera <[email protected]>
2018-04-05 11:54 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
1 sibling, 1 reply; 8+ messages in thread
From: Alvaro Herrera @ 2018-04-04 20:17 UTC (permalink / raw)
To: David G. Johnston <[email protected]>; +Cc: Bruce Momjian <[email protected]>; Oleg Bartunov <[email protected]>; [email protected]; [email protected]
David G. Johnston wrote:
> I'm not seeing the value in providing a link, especially one that we don't
> control, here. Futhermore, we could probably drop the whole "In
> practice..." sentence. But if not at least put a period after "limitation"
> and drop the example and link.
+1 remove the sentence.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Dead link in ltree documentation
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
2018-04-04 19:06 ` Re: Dead link in ltree documentation Bruce Momjian <[email protected]>
2018-04-04 20:02 ` Re: Dead link in ltree documentation David G. Johnston <[email protected]>
2018-04-04 20:17 ` Re: Dead link in ltree documentation Alvaro Herrera <[email protected]>
@ 2018-04-05 11:54 ` Oleg Bartunov <[email protected]>
2018-04-05 19:55 ` Re: Dead link in ltree documentation Bruce Momjian <[email protected]>
0 siblings, 1 reply; 8+ messages in thread
From: Oleg Bartunov @ 2018-04-05 11:54 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; +Cc: David G. Johnston <[email protected]>; Bruce Momjian <[email protected]>; [email protected]; [email protected]
On Wed, Apr 4, 2018 at 8:17 PM, Alvaro Herrera <[email protected]> wrote:
> David G. Johnston wrote:
>
>> I'm not seeing the value in providing a link, especially one that we don't
>> control, here. Futhermore, we could probably drop the whole "In
>> practice..." sentence. But if not at least put a period after "limitation"
>> and drop the example and link.
>
> +1 remove the sentence.
Attached is a new patch, which removed the whole sentence with example link.
>
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
[application/octet-stream] ltree.sgml.patch (595B, 2-ltree.sgml.patch)
download | inline diff:
--- ltree.sgml.old 2018-04-04 16:43:01.000000000 +0400
+++ ltree.sgml 2018-04-05 15:52:44.000000000 +0400
@@ -32,9 +32,7 @@
labels separated by dots, for example <literal>L1.L2.L3</literal>, representing
a path from the root of a hierarchical tree to a particular node. The
length of a label path must be less than 65kB, but keeping it under 2kB is
- preferable. In practice this is not a major limitation; for example,
- the longest label path in the DMOZ catalog (<ulink
- url="http://www.dmoztools.net"></ulink>) is about 271 bytes.
+ preferable.
</para>
<para>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Dead link in ltree documentation
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
2018-04-04 19:06 ` Re: Dead link in ltree documentation Bruce Momjian <[email protected]>
2018-04-04 20:02 ` Re: Dead link in ltree documentation David G. Johnston <[email protected]>
2018-04-04 20:17 ` Re: Dead link in ltree documentation Alvaro Herrera <[email protected]>
2018-04-05 11:54 ` Re: Dead link in ltree documentation Oleg Bartunov <[email protected]>
@ 2018-04-05 19:55 ` Bruce Momjian <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Bruce Momjian @ 2018-04-05 19:55 UTC (permalink / raw)
To: Oleg Bartunov <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; David G. Johnston <[email protected]>; [email protected]; [email protected]
On Thu, Apr 5, 2018 at 11:54:19AM +0000, Oleg Bartunov wrote:
> On Wed, Apr 4, 2018 at 8:17 PM, Alvaro Herrera <[email protected]> wrote:
> > David G. Johnston wrote:
> >
> >> I'm not seeing the value in providing a link, especially one that we don't
> >> control, here. Futhermore, we could probably drop the whole "In
> >> practice..." sentence. But if not at least put a period after "limitation"
> >> and drop the example and link.
> >
> > +1 remove the sentence.
>
> Attached is a new patch, which removed the whole sentence with example link.
Patch applied and backpatched through 9.3. Thanks.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2018-04-05 19:55 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-04-04 09:59 Dead link in ltree documentation PG Doc comments form <[email protected]>
2018-04-04 12:46 ` Oleg Bartunov <[email protected]>
2018-04-04 19:06 ` Bruce Momjian <[email protected]>
2018-04-04 20:02 ` David G. Johnston <[email protected]>
2018-04-04 20:13 ` David G. Johnston <[email protected]>
2018-04-04 20:17 ` Alvaro Herrera <[email protected]>
2018-04-05 11:54 ` Oleg Bartunov <[email protected]>
2018-04-05 19:55 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox