Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gCshR-0004Ri-3R for pgsql-docs@arkaria.postgresql.org; Wed, 17 Oct 2018 20:45:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gCshO-00089c-Kx for pgsql-docs@arkaria.postgresql.org; Wed, 17 Oct 2018 20:45:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gCshO-00088N-A8 for pgsql-docs@lists.postgresql.org; Wed, 17 Oct 2018 20:45:46 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gCshJ-0002eo-9v for pgsql-docs@lists.postgresql.org; Wed, 17 Oct 2018 20:45:43 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id EA42121C289A for ; Wed, 17 Oct 2018 23:45:39 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail-it1-f182.google.com (mail-it1-f182.google.com [209.85.166.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (not verified)) by mail.postgrespro.ru (Postfix) with ESMTPSA id 6DCEC21C2898 for ; Wed, 17 Oct 2018 23:45:39 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1539809139; bh=kRpZlohwhlNUwoWUx20US7zG7FAvdZWf3xhfZ6F96Rk=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=Ap0YHpfUiWIOYyR3Z70UA/bfK6T3ky3rCsJuYYHyQciVGy8pgiGKa4ssJyjGk3SlJ UEw5/MEjmYvDe58gZbQ4CftpF57NYyG7oTPZz5E5tLk+Niwrwd6VcBq6LLxkAHzguJ eTkkNF1imW94o9MLo0f1MdJ6KsBVhoS0lVbUub7I= Received: by mail-it1-f182.google.com with SMTP id i191-v6so4275242iti.5 for ; Wed, 17 Oct 2018 13:45:39 -0700 (PDT) X-Gm-Message-State: ABuFfohmOf2SFtjYGaBElel9/U/N8abUbBGeZrhoezUULiUwdhvF32kv JOvUddDnU36d3b4eG7Eh9uiqVykhcCW4dDCjm40= X-Google-Smtp-Source: ACcGV60bFMjINiIJ4hAI2OQDwft/90L9n9vTtazSpzzeHHZeIcJZfIquRPyLHRAK0xonXW5iNtTTPwbZHKX3gag5onA= X-Received: by 2002:a24:6907:: with SMTP id e7-v6mr2894482itc.113.1539809137934; Wed, 17 Oct 2018 13:45:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Oleg Bartunov Date: Wed, 17 Oct 2018 23:45:30 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bloom documentation patch To: Thomas Munro , Alexander Korotkov Cc: pgsql-docs@lists.postgresql.org Content-Type: multipart/mixed; boundary="000000000000b0c644057872c086" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b0c644057872c086 Content-Type: text/plain; charset="UTF-8" On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro wrote: > > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov wrote: > > Please, consider attached patch, which improves contrib/bloom documentation. > > Hello Oleg, I have no comment on the technical details but here is > some proof-reading of the English: > > + Length of each signature (index entry) in bits, it is rounded > up to the nearest > + multiple of 16. The default is 80 bits and maximum is > > s/, it is/. It is/ > s/and maximum/and the maximum/ > > + Bloom AM doesn't supports unique indexes. > > s/supports/support/ > > + Bloom AM doesn't supports NULL values. > > s/supports/support/ > Thanks, Thomas, new patch attached. > -- > Thomas Munro > http://www.enterprisedb.com > -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company --000000000000b0c644057872c086 Content-Type: application/octet-stream; name="bloom.sgml.patch" Content-Disposition: attachment; filename="bloom.sgml.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jndmgbtq0 LS0tIGJsb29tLnNnbWwub2xkCTIwMTgtMTAtMTUgMTE6NTY6MTcuMDAwMDAwMDAwICswMzAwCisr KyBibG9vbS5zZ21sCTIwMTgtMTAtMTcgMjM6NDA6MzAuMDAwMDAwMDAwICswMzAwCkBAIC01MSw5 ICs1MSw5IEBACiAgICAgPHRlcm0+PGxpdGVyYWw+bGVuZ3RoPC9saXRlcmFsPjwvdGVybT4KICAg ICA8bGlzdGl0ZW0+CiAgICAgIDxwYXJhPgotICAgICAgTGVuZ3RoIG9mIGVhY2ggc2lnbmF0dXJl IChpbmRleCBlbnRyeSkgaW4gYml0cywgaXQgaXMgcm91bmRlZCB1cCB0byB0aGUKKyAgICAgIExl bmd0aCBvZiBlYWNoIHNpZ25hdHVyZSAoaW5kZXggZW50cnkpIGluIGJpdHMuIEl0IGlzIHJvdW5k ZWQgdXAgdG8gdGhlCiAgICAgICBuZWFyZXN0IG11bHRpcGxlIG9mIDxsaXRlcmFsPjE2PC9saXRl cmFsPi4gVGhlIGRlZmF1bHQgaXMKLSAgICAgIDxsaXRlcmFsPjgwPC9saXRlcmFsPiBiaXRzIGFu ZCBtYXhpbXVtIGlzIDxsaXRlcmFsPjQwOTY8L2xpdGVyYWw+LgorICAgICAgPGxpdGVyYWw+ODA8 L2xpdGVyYWw+IGJpdHMgYW5kIHRoZSBtYXhpbXVtIGlzIDxsaXRlcmFsPjQwOTY8L2xpdGVyYWw+ LgogICAgICA8L3BhcmE+CiAgICAgPC9saXN0aXRlbT4KICAgIDwvdmFybGlzdGVudHJ5Pgo= --000000000000b0c644057872c086--