Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1igwH5-0001O8-1w for pgsql-docs@arkaria.postgresql.org; Mon, 16 Dec 2019 19:43:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1igwG5-0007Oc-J0 for pgsql-docs@arkaria.postgresql.org; Mon, 16 Dec 2019 19:42:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1igwG5-0007OV-94 for pgsql-docs@lists.postgresql.org; Mon, 16 Dec 2019 19:42:21 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1igwG2-0001SM-QW for pgsql-docs@lists.postgresql.org; Mon, 16 Dec 2019 19:42:20 +0000 Received: by mail-wm1-x341.google.com with SMTP id f129so569786wmf.2 for ; Mon, 16 Dec 2019 11:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6R3MOQj17Z4pnj7JH5V0qjPB939ji05xQTgq2BHz79k=; b=sgbnv/QLvDNCYfdqJ7eZz5I/pHVhiV1SHaGk+QWZIC9ENlUziS41i9FfHz4pFR7wKR 9KyaVuNjgc6uf3ai14KiC/5CVSljXQum1/e9zYSkDGfAmBqYMHLHA/uVleiOLFGi1azF KUWzS6hsbTF74rWDM3X+ZTRolGoYnhBHDTlLaRzPImKN5XlWDSfHPZ3U4IHTlyALfTXY wgnYS6s8e6HGws1lI5axIKIYj9iR4AtcrDdbW9dDxeYLvkQkbah2ZT8uTi/UpXAx9Sz2 JsUzkM6i/SnM/zKP7iD/MFaK5VbsIDin7m+VZrQBwIHOHyZgo6c+TesFmOpUN9/63z8X HoPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6R3MOQj17Z4pnj7JH5V0qjPB939ji05xQTgq2BHz79k=; b=FdsJX12F/5jNBHZjAT4wNOlqVr6tBr39Ang6IcKJD+v0E4E3URDVKzOmp1FO8Zjxgu UBhEnJfHaXXFX8hbBuKrLYFOGyCUzUoPzZLPybl0Yd21AHSfPgdaGP9t3glft0b34o4r tooZHg4rLiS1DwgBNVX50BDhqyxDyxmhel9wATROpRdZo3vqL2SyNUZaa++KZKMUQJlK xiTFMe8+YX9BpizTkRQ+y+GTDbWtvlmSYSsLavQjZhzUvf85Ksizj6cSw3N8PUC01fup 5ka2deTnrx3iIWbIllyGSW98f8zxCbyo4XiWPz094nbtxMRsuGcyiba4yYWbhhs2zRmX MNsA== X-Gm-Message-State: APjAAAVBIroa91UNnA8/WE9N0eZtBYlsYTYuuutOMwjHww9T4FmX234U Z00ljJt8y38kIVO+j03MY8ynd2Itac4qA96qraM= X-Google-Smtp-Source: APXvYqzQF3DKCWOv2KdNsll5f9q8dndEqh6DfGSaDKJqJdClSvbeSx19PvEdvx/HU6nLXAg79RuQHibYKewrGFgF+sU= X-Received: by 2002:a1c:49c2:: with SMTP id w185mr722038wma.138.1576525337428; Mon, 16 Dec 2019 11:42:17 -0800 (PST) MIME-Version: 1.0 References: <157644931740.18138.16968232991166819127@wrigleys.postgresql.org> <5877.1576524478@sss.pgh.pa.us> In-Reply-To: <5877.1576524478@sss.pgh.pa.us> From: Pavel Stehule Date: Mon, 16 Dec 2019 20:42:04 +0100 Message-ID: Subject: Re: Example 42.4. A PL/pgSQL Trigger Function for Auditing To: Tom Lane Cc: simon.dallaway@datacom.co.nz, pgsql-docs@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000b785340599d768ce" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b785340599d768ce Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dne po 16. 12. 2019 20:28 u=C5=BEivatel Tom Lane napsal= : > Pavel Stehule writes: > > po 16. 12. 2019 v 12:12 odes=C3=ADlatel PG Doc comments form < > > noreply@postgresql.org> napsal: > >> I'm wondering if it would be worthwhile to put a totally generic > auditing > >> function into the documentation e.g. > >> [ snip ] > > > Just few points to this code > > I agree this code could have better style, but maybe that is just more > evidence that a well-written example would be helpful? > +1 there is not too much examples for trigger parameters. > regards, tom lane > --000000000000b785340599d768ce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Dne po 16. 12. 2019 20:28 u=C5=BEivatel Tom Lane <<= a href=3D"mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us> napsal:
Pavel Stehule <pavel.stehule@gma= il.com> writes:
> po 16. 12. 2019 v 12:12 odes=C3=ADlatel PG Doc comments form <
> noreply@postgresql.org> napsal:
>> I'm wondering if it would be worthwhile to put a totally gener= ic auditing
>> function into the documentation e.g.
>> [ snip ]

> Just few points to this code

I agree this code could have better style, but maybe that is just more
evidence that a well-written example would be helpful?

+1

there is not too much examples for trigger= parameters.


<= div dir=3D"auto">

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 regards, tom lane
--000000000000b785340599d768ce--