public inbox for [email protected]  

help / color / mirror / Atom feed

docs: Link to the correct protocol version inspection function
3+ messages / 3 participants
[nested] [flat]

* docs: Link to the correct protocol version inspection function
@ 2025-10-22 09:42  Jelte Fennema-Nio <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Jelte Fennema-Nio @ 2025-10-22 09:42 UTC (permalink / raw)
  To: [email protected]

The docs for max_protocol_version suggested PQprotocolVersion instead of
PQfullProtocolVersion to find out the exact protocol version. Since
PQprotocolVersion only returns the major protocol version that is bad
advice.


Attachments:

  [application/x-patch] v1-0001-docs-Link-to-the-correct-protocol-version-inspect.patch (1.3K, 2-v1-0001-docs-Link-to-the-correct-protocol-version-inspect.patch)
  download | inline diff:
From e57dceb0d2b57c9ce99a843342cb821537d3b504 Mon Sep 17 00:00:00 2001
From: Jelte Fennema-Nio <[email protected]>
Date: Wed, 22 Oct 2025 11:36:13 +0200
Subject: [PATCH v1] docs: Link to the correct protocol version inspection
 function

The docs for max_protocol_version suggested PQprotocolVersion instead of
PQfullProtocolVersion to find out the exact protocol version. Since
PQprotocolVersion only returns the major protocol version that is bad
advice.

Author: Jelte Fennema-Nio <[email protected]>
Backpatch-through: 18
---
 doc/src/sgml/libpq.sgml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 5bf59a19855..e76da383714 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -2220,7 +2220,7 @@ postgresql://%2Fvar%2Flib%2Fpostgresql/dbname
         server does not support the protocol version requested by the client,
         the connection is automatically downgraded to a lower minor protocol
         version that the server supports. After the connection attempt has
-        completed you can use <xref linkend="libpq-PQprotocolVersion"/> to
+        completed you can use <xref linkend="libpq-PQfullProtocolVersion"/> to
         find out which exact protocol version was negotiated.
        </para>
 

base-commit: 2d7b247cb414ccbc052c485fd82a841477a7e1ff
-- 
2.51.1



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: docs: Link to the correct protocol version inspection function
@ 2025-10-23 05:58  Shinya Kato <[email protected]>
  parent: Jelte Fennema-Nio <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Shinya Kato @ 2025-10-23 05:58 UTC (permalink / raw)
  To: Jelte Fennema-Nio <[email protected]>; +Cc: [email protected]

Hi,

On Wed, Oct 22, 2025 at 6:42 PM Jelte Fennema-Nio <[email protected]> wrote:
>
> The docs for max_protocol_version suggested PQprotocolVersion instead of
> PQfullProtocolVersion to find out the exact protocol version. Since
> PQprotocolVersion only returns the major protocol version that is bad
> advice.

Nice catch! The patch looks good to me.

-- 
Best regards,
Shinya Kato
NTT OSS Center





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: docs: Link to the correct protocol version inspection function
@ 2025-10-30 10:06  Peter Eisentraut <[email protected]>
  parent: Shinya Kato <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Eisentraut @ 2025-10-30 10:06 UTC (permalink / raw)
  To: Shinya Kato <[email protected]>; Jelte Fennema-Nio <[email protected]>; +Cc: [email protected]

On 23.10.25 07:58, Shinya Kato wrote:
> On Wed, Oct 22, 2025 at 6:42 PM Jelte Fennema-Nio <[email protected]> wrote:
>> The docs for max_protocol_version suggested PQprotocolVersion instead of
>> PQfullProtocolVersion to find out the exact protocol version. Since
>> PQprotocolVersion only returns the major protocol version that is bad
>> advice.
> 
> Nice catch! The patch looks good to me.

committed







^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2025-10-30 10:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-10-22 09:42 docs: Link to the correct protocol version inspection function Jelte Fennema-Nio <[email protected]>
2025-10-23 05:58 ` Shinya Kato <[email protected]>
2025-10-30 10:06   ` Peter Eisentraut <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox