public inbox for [email protected]  
help / color / mirror / Atom feed
"IS NOT DOCUMENT" is missing
5+ messages / 4 participants
[nested] [flat]

* "IS NOT DOCUMENT" is missing
@ 2018-03-09 03:10  PG Doc comments form <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: PG Doc comments form @ 2018-03-09 03:10 UTC (permalink / raw)
  To: [email protected]; +Cc: [email protected]

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/10/static/functions-xml.html
Description:

From testing, it seems like PostgreSQL supports the syntax "IS NOT DOCUMENT"
in addition to "IS DOCUMENT", similar to "IS NOT NULL", "IS NOT FALSE", etc,
however this does not appear to be documented, only "IS DOCUMENT" is.


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: "IS NOT DOCUMENT" is missing
@ 2018-03-16 04:56  Euler Taveira <[email protected]>
  parent: PG Doc comments form <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Euler Taveira @ 2018-03-16 04:56 UTC (permalink / raw)
  To: [email protected]; [email protected]

2018-03-09 0:10 GMT-03:00 PG Doc comments form <[email protected]>:
> From testing, it seems like PostgreSQL supports the syntax "IS NOT DOCUMENT"
> in addition to "IS DOCUMENT", similar to "IS NOT NULL", "IS NOT FALSE", etc,
> however this does not appear to be documented, only "IS DOCUMENT" is.
>
It has been like that since day 1. I'm not sure why it was not
documented. It already has some tests. I'll bet that was an oversight.
Should we repeat the statement in another item (like the attached
patch)? Another option is to add a statement in the "IS DOCUMENT"
item. I'm afraid that NULL return wouldn't be clear.


-- 
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento


Attachments:

  [text/x-patch] doc3.diff (832B, 2-doc3.diff)
  download | inline diff:
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 2f59af2..fcef246 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -10399,6 +10399,24 @@ SELECT xmlagg(x) FROM (SELECT * FROM test ORDER BY y DESC) AS tab;
     </para>
    </sect3>
 
+   <sect3>
+    <title><literal>IS NOT DOCUMENT</literal></title>
+
+    <indexterm>
+     <primary>IS NOT DOCUMENT</primary>
+    </indexterm>
+
+<synopsis>
+<replaceable>xml</replaceable> IS NOT DOCUMENT
+</synopsis>
+
+    <para>
+     The expression <literal>IS NOT DOCUMENT</literal> returns false if the
+     argument XML value is a proper XML document, true if it is not (that is,
+     it is a content fragment), or null if the argument is null.
+    </para>
+   </sect3>
+
    <sect3 id="xml-exists">
     <title><literal>XMLEXISTS</literal></title>
 


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: "IS NOT DOCUMENT" is missing
@ 2018-03-30 14:40  Bruce Momjian <[email protected]>
  parent: Euler Taveira <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Bruce Momjian @ 2018-03-30 14:40 UTC (permalink / raw)
  To: Euler Taveira <[email protected]>; +Cc: [email protected]; [email protected]

On Fri, Mar 16, 2018 at 01:56:32AM -0300, Euler Taveira wrote:
> 2018-03-09 0:10 GMT-03:00 PG Doc comments form <[email protected]>:
> > From testing, it seems like PostgreSQL supports the syntax "IS NOT DOCUMENT"
> > in addition to "IS DOCUMENT", similar to "IS NOT NULL", "IS NOT FALSE", etc,
> > however this does not appear to be documented, only "IS DOCUMENT" is.
> >
> It has been like that since day 1. I'm not sure why it was not
> documented. It already has some tests. I'll bet that was an oversight.
> Should we repeat the statement in another item (like the attached
> patch)? Another option is to add a statement in the "IS DOCUMENT"
> item. I'm afraid that NULL return wouldn't be clear.
> 

Patch applied and backpatched to Postgres 10.  Thank.s

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +




^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: "IS NOT DOCUMENT" is missing
@ 2018-04-02 15:51  Peter Eisentraut <[email protected]>
  parent: Bruce Momjian <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Peter Eisentraut @ 2018-04-02 15:51 UTC (permalink / raw)
  To: Bruce Momjian <[email protected]>; Euler Taveira <[email protected]>; +Cc: [email protected]; [email protected]

On 3/30/18 10:40, Bruce Momjian wrote:
> On Fri, Mar 16, 2018 at 01:56:32AM -0300, Euler Taveira wrote:
>> 2018-03-09 0:10 GMT-03:00 PG Doc comments form <[email protected]>:
>>> From testing, it seems like PostgreSQL supports the syntax "IS NOT DOCUMENT"
>>> in addition to "IS DOCUMENT", similar to "IS NOT NULL", "IS NOT FALSE", etc,
>>> however this does not appear to be documented, only "IS DOCUMENT" is.
>>>
>> It has been like that since day 1. I'm not sure why it was not
>> documented. It already has some tests. I'll bet that was an oversight.
>> Should we repeat the statement in another item (like the attached
>> patch)? Another option is to add a statement in the "IS DOCUMENT"
>> item. I'm afraid that NULL return wouldn't be clear.
>>
> 
> Patch applied and backpatched to Postgres 10.  Thank.s

Per the nearby discussion, this should probably also be backpatched further.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: "IS NOT DOCUMENT" is missing
@ 2018-04-02 20:41  Bruce Momjian <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: Bruce Momjian @ 2018-04-02 20:41 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: Euler Taveira <[email protected]>; [email protected]; [email protected]

On Mon, Apr  2, 2018 at 11:51:50AM -0400, Peter Eisentraut wrote:
> On 3/30/18 10:40, Bruce Momjian wrote:
> > On Fri, Mar 16, 2018 at 01:56:32AM -0300, Euler Taveira wrote:
> >> 2018-03-09 0:10 GMT-03:00 PG Doc comments form <[email protected]>:
> >>> From testing, it seems like PostgreSQL supports the syntax "IS NOT DOCUMENT"
> >>> in addition to "IS DOCUMENT", similar to "IS NOT NULL", "IS NOT FALSE", etc,
> >>> however this does not appear to be documented, only "IS DOCUMENT" is.
> >>>
> >> It has been like that since day 1. I'm not sure why it was not
> >> documented. It already has some tests. I'll bet that was an oversight.
> >> Should we repeat the statement in another item (like the attached
> >> patch)? Another option is to add a statement in the "IS DOCUMENT"
> >> item. I'm afraid that NULL return wouldn't be clear.
> >>
> > 
> > Patch applied and backpatched to Postgres 10.  Thank.s
> 
> Per the nearby discussion, this should probably also be backpatched further.

OK, backpatched through 9.3.


-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +





^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2018-04-02 20:41 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-09 03:10 "IS NOT DOCUMENT" is missing PG Doc comments form <[email protected]>
2018-03-16 04:56 ` Euler Taveira <[email protected]>
2018-03-30 14:40   ` Bruce Momjian <[email protected]>
2018-04-02 15:51     ` Peter Eisentraut <[email protected]>
2018-04-02 20:41       ` Bruce Momjian <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox