public inbox for [email protected]
help / color / mirror / Atom feedFrom: Fujii Masao <[email protected]>
To: David G. Johnston <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Check query
Date: Tue, 7 Jul 2026 09:52:39 +0900
Message-ID: <CAHGQGwG5_1Vn7TqreKfrWB8Yx01AqyxJxPoG1HvWMGAK0etZQw@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwZyUsC4jKQ+o3ugVXx4_DgYBKUfX9YZM_1REF7oSqDGkw@mail.gmail.com>
References: <[email protected]>
<CAKFQuwZyUsC4jKQ+o3ugVXx4_DgYBKUfX9YZM_1REF7oSqDGkw@mail.gmail.com>
On Sun, Jun 28, 2026 at 12:51 AM David G. Johnston
<[email protected]> wrote:
>
> On Friday, June 26, 2026, PG Doc comments form <[email protected]> wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/18/rules-views.html
>> Description:
>>
>> ...
>> WHERE shoe_ready.total_avail > 2; ??? (maybe WHERE shoe_ready.total_avail
>> >= 2;)
>
>
> Yes, the lack of an equal sign there is a typo.
Yes. Very old commit dcb00495236 seems to have accidentally changed
the condition to > 2 while rewriting the example to use SQL operator
notation.
The attached patch changes it from > 2 to >= 2.
Barring any objections, I'll backpatch it to all supported branches.
Regards,
--
Fujii Masao
Attachments:
[application/octet-stream] v1-0001-doc-Fix-typo-in-rule-system-view-example.patch (1.3K, ../CAHGQGwG5_1Vn7TqreKfrWB8Yx01AqyxJxPoG1HvWMGAK0etZQw@mail.gmail.com/2-v1-0001-doc-Fix-typo-in-rule-system-view-example.patch)
download | inline diff:
From 3da9967172d0664cf6ab49f4f3aef8161bd03347 Mon Sep 17 00:00:00 2001
From: Fujii Masao <[email protected]>
Date: Tue, 7 Jul 2026 09:44:22 +0900
Subject: [PATCH v1] doc: Fix typo in rule-system view example
Commit dcb00495236 accidentally changed the final expanded query's
condition to > 2 while rewriting the example into SQL operator notation.
The original query and the preceding rewritten forms all use >= 2,
and view expansion should preserve that qualification. This commit
changes the final condition from > 2 to >= 2.
Backpatch to all supported versions.
Reported-by: Yaroslav Saburov <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 14
---
doc/src/sgml/rules.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/rules.sgml b/doc/src/sgml/rules.sgml
index 7f23962f524..9f9fa978f2d 100644
--- a/doc/src/sgml/rules.sgml
+++ b/doc/src/sgml/rules.sgml
@@ -631,7 +631,7 @@ SELECT shoe_ready.shoename, shoe_ready.sh_avail,
WHERE rsl.sl_color = rsh.slcolor
AND rsl.sl_len_cm >= rsh.slminlen_cm
AND rsl.sl_len_cm <= rsh.slmaxlen_cm) shoe_ready
- WHERE shoe_ready.total_avail > 2;
+ WHERE shoe_ready.total_avail >= 2;
</programlisting>
</para>
--
2.55.0
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Check query
In-Reply-To: <CAHGQGwG5_1Vn7TqreKfrWB8Yx01AqyxJxPoG1HvWMGAK0etZQw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox