public inbox for [email protected]  

help / color / mirror / Atom feed

file_fdw: Add missing docs for the DEFAULT option
3+ messages / 2 participants
[nested] [flat]

* file_fdw: Add missing docs for the DEFAULT option
@ 2026-01-09 08:05  Shinya Kato <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Shinya Kato @ 2026-01-09 08:05 UTC (permalink / raw)
  To: pgsql-docs

Hi hackers,

Commit 9f8377f[0] introduced the DEFAULT option for file_fdw, but the
documentation was not updated. The attached patch adds the missing
documentation.

[0] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9f8377f7a27910bf0f35bf5169a8046731948...

--
Best regards,
Shinya Kato
NTT OSS Center


Attachments:

  [application/x-patch] v1-0001-file_fdw-Add-missing-docs-for-the-DEFAULT-option.patch (1.1K, ../../CAOzEurT_PE7QEh5xAdb7Cja84Rur5qPv2Fzt3Tuqi=NU0WJsbg@mail.gmail.com/2-v1-0001-file_fdw-Add-missing-docs-for-the-DEFAULT-option.patch)
  download | inline diff:
From 2dfc92021974646118582a2b1119bd4cd0f38e0e Mon Sep 17 00:00:00 2001
From: Shinya Kato <[email protected]>
Date: Fri, 9 Jan 2026 16:50:50 +0900
Subject: [PATCH v1] file_fdw: Add missing docs for the DEFAULT option

Commit 9f8377f7a introduced the DEFAULT option for file_fdw, but the
documentation was not updated. This commit adds the missing
documentation.

Author: Shinya Kato <[email protected]>
Reviewed-by:
Discussion: https://postgr.es/m/
---
 doc/src/sgml/file-fdw.sgml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
index 882d9a76d21..e3fe796b897 100644
--- a/doc/src/sgml/file-fdw.sgml
+++ b/doc/src/sgml/file-fdw.sgml
@@ -115,6 +115,17 @@
    </listitem>
   </varlistentry>
 
+  <varlistentry>
+   <term><literal>default</literal></term>
+
+   <listitem>
+    <para>
+     Specifies the string that represents a default value,
+     the same as <command>COPY</command>'s <literal>DEFAULT</literal> option.
+    </para>
+   </listitem>
+  </varlistentry>
+
   <varlistentry>
    <term><literal>encoding</literal></term>
 
-- 
2.47.3



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: file_fdw: Add missing docs for the DEFAULT option
@ 2026-01-09 09:49  Fujii Masao <[email protected]>
  parent: Shinya Kato <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Fujii Masao @ 2026-01-09 09:49 UTC (permalink / raw)
  To: Shinya Kato <[email protected]>; +Cc: pgsql-docs

On Fri, Jan 9, 2026 at 5:06 PM Shinya Kato <[email protected]> wrote:
>
> Hi hackers,
>
> Commit 9f8377f[0] introduced the DEFAULT option for file_fdw, but the
> documentation was not updated. The attached patch adds the missing
> documentation.

Thanks for the patch! LGTM.
I'm thinking of backpatching this to v16, where the DEFAULT option was
introduced.

Regards,

-- 
Fujii Masao





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: file_fdw: Add missing docs for the DEFAULT option
@ 2026-01-13 13:57  Fujii Masao <[email protected]>
  parent: Fujii Masao <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Fujii Masao @ 2026-01-13 13:57 UTC (permalink / raw)
  To: Shinya Kato <[email protected]>; +Cc: pgsql-docs

On Fri, Jan 9, 2026 at 6:49 PM Fujii Masao <[email protected]> wrote:
>
> On Fri, Jan 9, 2026 at 5:06 PM Shinya Kato <[email protected]> wrote:
> >
> > Hi hackers,
> >
> > Commit 9f8377f[0] introduced the DEFAULT option for file_fdw, but the
> > documentation was not updated. The attached patch adds the missing
> > documentation.
>
> Thanks for the patch! LGTM.
> I'm thinking of backpatching this to v16, where the DEFAULT option was
> introduced.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2026-01-13 13:57 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-09 08:05 file_fdw: Add missing docs for the DEFAULT option Shinya Kato <[email protected]>
2026-01-09 09:49 ` Fujii Masao <[email protected]>
2026-01-13 13:57   ` Fujii Masao <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox