MIME-Version: 1.0
In-Reply-To: 
 <CAB7nPqSSX8yYkzHrsFDChvEpwWuMekrW2RV+yJR7WLKa6Xf4Fg@mail.gmail.com>
References: 
 <CAD_AmVgk899Ld2=YTg=7qcOAs5OE4BL1sQ+ZR+N7LDT9MrS8Aw@mail.gmail.com>
 <CAB7nPqSV1kR6FqWf2rOVter5cXAW8oTH+DKZjwP4Meji5do5wg@mail.gmail.com>
 <CAHGQGwH9ccoz=Ryf=9ft9QfmkFkff1wAsxXdthnGu88Cvw3VpQ@mail.gmail.com>
 <CAB7nPqSSX8yYkzHrsFDChvEpwWuMekrW2RV+yJR7WLKa6Xf4Fg@mail.gmail.com>
Date: Fri, 11 Sep 2015 13:04:03 +0900
Message-ID: 
 <CAHGQGwHTBwop0AzfWz0KNGCYeys8Wru09jwd2vUdjdY_tCZ+vw@mail.gmail.com>
Subject: Re: Possible mistake in Section 63.6 - 9.6devel Documentation
From: Fujii Masao <masao.fujii@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Vignesh Raghunathan <vignesh.pgsql@gmail.com>,
 pgsql-docs <pgsql-docs@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

On Thu, Sep 10, 2015 at 3:05 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Thu, Sep 10, 2015 at 12:42 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> On Tue, Jul 21, 2015 at 9:59 AM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> On Tue, Jul 21, 2015 at 6:54 AM, Vignesh Raghunathan
>>> <vignesh.pgsql@gmail.com> wrote:
>>>> Hello,
>>>>
>>>> It has been mentioned in Section 63.6 that the first two fields in
>>>> PageHeaderData track the most recent WAL entry related to the page. However,
>>>> I am not sure how pd_checksum is related to WAL. Could it be possible that
>>>> the sentence has been carried over from previous versions of the
>>>> documentations without considering the change to the second field in
>>>> PageHeaderData?
>>>
>>> Yes, the documentation is mistaken. The two bytes of pd_tli have been
>>> switched to pd_checksum in 9.3, hence only the first field is relevant
>>> for WAL, aka pd_lsn. Looking at this portion of the docs I think that
>>> it should be updated as attached, mentioning pd_checksum as well.
>>
>> Also the type of pd_lsn in the Table 63-3 should be PageXLogRecPtr.
>
> Yep. See attached FWIW.

Thanks! Applied.

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs