MIME-Version: 1.0
References: 
 <CAHGQGwHSOSGcaYDvHF8EYCUCfGPjbRwGFsJ23cx5KbJ1X6JouQ@mail.gmail.com>
 <DGJ18BHYPI3K.1025EY15AKHB6@gmail.com>
In-Reply-To: <DGJ18BHYPI3K.1025EY15AKHB6@gmail.com>
From: Fujii Masao <masao.fujii@gmail.com>
Date: Fri, 20 Feb 2026 00:51:04 +0900
Message-ID: 
 <CAHGQGwHbgZvjHEFOjLSiUNfcFFCXw5muJBZp9Ko44Uujks70Bg@mail.gmail.com>
Subject: Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE
 FOREIGN TABLE docs
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHGQGwHbgZvjHEFOjLSiUNfcFFCXw5muJBZp9Ko44Uujks70Bg%40mail.gmail.com>
Precedence: bulk

On Fri, Feb 20, 2026 at 12:10=E2=80=AFAM Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
>
> On Tue Feb 17, 2026 at 11:36 AM -03, Fujii Masao wrote:
> > Hi,
> >
> >> Comments for the copied columns, constraints, and indexes will be copi=
ed.
> >
> > The above current description of INCLUDING COMMENTS in the CREATE TABLE=
 docs
> > appears inaccurate and incomplete. It says that comments on constraints=
 are
> > copied, but in practice only comments on CHECK and NOT NULL constraints
> > are copied; comments on other constraints (such as primary keys) are no=
t.
> > In addition, comments on extended statistics are copied, but this is no=
t
> > documented.
> >
> > The CREATE FOREIGN TABLE docs has a similar omission: comments on exten=
ded
> > statistics are also copied, but this is not mentioned.
> >
> > Therefore I'd like to propose the attached patch to clarify the actual =
behavior
> > of INCLUDING COMMENTS. Thoughts?
> >
>
> Hi, thanks for the patch.
>
> The changes make sense to me, it sounds more clear. I've performed some
> tests and the documentation seems correct about what comments are
> actually copied.

Thanks for the review! Barring any objections, I will commit the patch.

Regards,

--=20
Fujii Masao