MIME-Version: 1.0
References: 
 <CAJpy0uBBk+OZXXqQ00Gai09XR+mDi2=9sMBYY0F+BedoFivaMA@mail.gmail.com>
 <CAJpy0uAKG3moYA0pwQoQ2sv1d-S0CmfXsZf_9C_83UqtREaj+w@mail.gmail.com>
 <CAA4eK1+voWz3b1zL=RP4AcsDuLfRv7N=Rom2od5uD-geKEQDGA@mail.gmail.com>
 <OS0PR01MB5716A706053B6EEA2B4EC20B94A92@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAJpy0uArGF6S4if6Aet82s5NEnfcPSKVBHGcxGx-m5Q+XHso6w@mail.gmail.com>
 <CAA4eK1JahE4YRb1ixyKdi7uc-v1cbO3iJVWNbAOkzBSdbDXVwA@mail.gmail.com>
 <CAJpy0uAeROTfqdoGWvZ9zqH4kRX5LECEGP1q-cTdmV9sYmWG6w@mail.gmail.com>
 <OS0PR01MB57165C9AEDDCEFD44B0BB1CB94AA2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <OS0PR01MB57165C9AEDDCEFD44B0BB1CB94AA2@OS0PR01MB5716.jpnprd01.prod.outlook.com>
From: shveta malik <shveta.malik@gmail.com>
Date: Wed, 24 Jul 2024 09:40:49 +0530
Message-ID: 
 <CAJpy0uDiaZWp_p5WEavgu0QgKxdMBT4nbCEYMYcO2sYdcDqxEg@mail.gmail.com>
Subject: Re: Correction in doc of failover ready steps
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	"pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>,
 shveta malik <shveta.malik@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000004b6caf061df67728"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJpy0uDiaZWp_p5WEavgu0QgKxdMBT4nbCEYMYcO2sYdcDqxEg%40mail.gmail.com>
Precedence: bulk

--0000000000004b6caf061df67728
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 24, 2024 at 9:02=E2=80=AFAM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> Thanks for the patch.
>
> Here is one comment:
>
> The second query has a condition 'WHERE slot_name IS NOT NULL', but I
> think it belongs to the first query. Because the slot_name of second quer=
y
> is built by CONCAT() which means it should be valid, while the first quer=
y's
> subslotname could be NULL if user executed ALTER SUB SET (slot_name =3D N=
ONE).
>

Thanks for pointing it out. Please find a new patch with this change.

Also corrected the commit message in this patch.

thanks
Shveta

--0000000000004b6caf061df67728
Content-Type: application/octet-stream;
	name="v4-0001-Correction-in-doc-of-failover-ready-steps.patch"
Content-Disposition: attachment;
	filename="v4-0001-Correction-in-doc-of-failover-ready-steps.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lyzbt4qo0>
X-Attachment-Id: f_lyzbt4qo0

RnJvbSAyZTBkZTI3ZTZlZWJhZjUyYjZiZjdkNzczZTI1MzkzMTI1NTNjNTRkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTaHZldGEgTWFsaWsgPHNodmV0YS5tYWxpa0BnbWFpbC5jb20+
CkRhdGU6IE1vbiwgMjIgSnVsIDIwMjQgMTA6MTA6MzQgKzA1MzAKU3ViamVjdDogW1BBVENIIHY0
XSBDb3JyZWN0aW9uIGluIGRvYyBvZiBmYWlsb3ZlciByZWFkeSBzdGVwcy4KClVubGlrZSBwZ19z
dWJzY3JpcHRpb24sIHBnX3N1YnNjcmlwdGlvbl9yZWwgcHJvdmlkZXMgcmVzdWx0cyBvbmx5IHdo
ZW4KY29ubmVjdGVkIHRvIHRoZSBkYXRhYmFzZSB0aGF0IGNvbnRhaW5zIHRoZSBzdWJzY3JpcHRp
b24ocykuIFRoZXJlZm9yZSwKdGhlIHF1ZXJ5IGZvciBmYWlsb3Zlci1yZWFkeSBzdGVwcywgd2hp
Y2ggaXMgYSBVTklPTiBvZiB0d28gcXVlcmllcyBvbgpwZ19zdWJzY3JpcHRpb24gYW5kIHBnX3N1
YnNjcmlwdGlvbl9yZWwsIG5lZWRzIHRvIGJlIHNwbGl0IGludG8gdHdvCnNlcGFyYXRlIHF1ZXJp
ZXMuIFRoZSBxdWVyeSBpbnZvbHZpbmcgcGdfc3Vic2NyaXB0aW9uIHNob3VsZCBiZQpleGVjdXRl
ZCBvbmNlIHBlciBzdWJzY3JpYmVyIG5vZGUsIHdoaWxlIHRoZSBxdWVyeSBpbnZvbHZpbmcKcGdf
c3Vic2NyaXB0aW9uX3JlbCBzaG91bGQgYmUgcnVuIG9uY2UgcGVyIGRhdGFiYXNlIHRoYXQgaW5j
bHVkZXMKdGhlIGZhaWxvdmVyLWVuYWJsZWQgc3Vic2NyaXB0aW9uKHMpLiBUaGlzIHBhdGNoIGNv
cnJlY3RzIHRoZQpkb2N1bWVudGF0aW9uIGFjY29yZGluZ2x5LgotLS0KIGRvYy9zcmMvc2dtbC9s
b2dpY2FsLXJlcGxpY2F0aW9uLnNnbWwgfCA2MSArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0K
IDEgZmlsZSBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9kb2Mvc3JjL3NnbWwvbG9naWNhbC1yZXBsaWNhdGlvbi5zZ21sIGIvZG9jL3NyYy9z
Z21sL2xvZ2ljYWwtcmVwbGljYXRpb24uc2dtbAppbmRleCBmMDc4ZDYzNjRiLi5mYmRkZGRkMGUz
IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvbG9naWNhbC1yZXBsaWNhdGlvbi5zZ21sCisrKyBi
L2RvYy9zcmMvc2dtbC9sb2dpY2FsLXJlcGxpY2F0aW9uLnNnbWwKQEAgLTcyNSwzMiArNzI1LDQ1
IEBAIEFMVEVSIFNVQlNDUklQVElPTgogICA8cHJvY2VkdXJlPgogICAgPHN0ZXAgcGVyZm9ybWFu
Y2U9InJlcXVpcmVkIj4KICAgICA8cGFyYT4KLSAgICAgT24gdGhlIHN1YnNjcmliZXIgbm9kZSwg
dXNlIHRoZSBmb2xsb3dpbmcgU1FMIHRvIGlkZW50aWZ5IHdoaWNoIHNsb3RzCi0gICAgIHNob3Vs
ZCBiZSBzeW5jZWQgdG8gdGhlIHN0YW5kYnkgdGhhdCB3ZSBwbGFuIHRvIHByb21vdGUuIFRoaXMg
cXVlcnkgd2lsbAotICAgICByZXR1cm4gdGhlIHJlbGV2YW50IHJlcGxpY2F0aW9uIHNsb3RzLCBp
bmNsdWRpbmcgdGhlIG1haW4gc2xvdHMgYW5kIHRhYmxlCi0gICAgIHN5bmNocm9uaXphdGlvbiBz
bG90cyBhc3NvY2lhdGVkIHdpdGggdGhlIGZhaWxvdmVyLWVuYWJsZWQgc3Vic2NyaXB0aW9ucy4K
LSAgICAgTm90ZSB0aGF0IHRoZSB0YWJsZSBzeW5jIHNsb3Qgc2hvdWxkIGJlIHN5bmNlZCB0byB0
aGUgc3RhbmRieSBzZXJ2ZXIgb25seQotICAgICBpZiB0aGUgdGFibGUgY29weSBpcyBmaW5pc2hl
ZCAoU2VlIDx4cmVmIGxpbmtlbmQ9ImNhdGFsb2ctcGctc3Vic2NyaXB0aW9uLXJlbCIvPikuCisg
ICAgIE9uIHRoZSBzdWJzY3JpYmVyIG5vZGUsIHVzZSB0aGUgZm9sbG93aW5nIFNRTCB0byBpZGVu
dGlmeSB3aGljaCByZXBsaWNhdGlvbgorICAgICBzbG90cyBzaG91bGQgYmUgc3luY2VkIHRvIHRo
ZSBzdGFuZGJ5IHRoYXQgd2UgcGxhbiB0byBwcm9tb3RlLiBUaGlzIHF1ZXJ5CisgICAgIHdpbGwg
cmV0dXJuIHRoZSByZWxldmFudCByZXBsaWNhdGlvbiBzbG90cyBhc3NvY2lhdGVkIHdpdGggdGhl
CisgICAgIGZhaWxvdmVyLWVuYWJsZWQgc3Vic2NyaXB0aW9ucy4KKzxwcm9ncmFtbGlzdGluZz4K
K3Rlc3Rfc3ViPSMgU0VMRUNUCisgICAgICAgICAgICAgICBhcnJheV9hZ2cocXVvdGVfbGl0ZXJh
bChzLnN1YnNsb3RuYW1lKSkgQVMgc2xvdHMKKyAgICAgICAgICAgRlJPTSAgcGdfc3Vic2NyaXB0
aW9uIHMKKyAgICAgICAgICAgV0hFUkUgcy5zdWJmYWlsb3ZlciBBTkQKKyAgICAgICAgICAgICAg
ICAgcy5zdWJzbG90bmFtZSBJUyBOT1QgTlVMTDsKKyBzbG90cworLS0tLS0tLQorIHsnc3ViMScs
J3N1YjInLCdzdWIzJ30KKygxIHJvdykKKzwvcHJvZ3JhbWxpc3Rpbmc+PC9wYXJhPgorICAgPC9z
dGVwPgorICAgPHN0ZXAgcGVyZm9ybWFuY2U9InJlcXVpcmVkIj4KKyAgICA8cGFyYT4KKyAgICAg
T24gdGhlIHN1YnNjcmliZXIgbm9kZSwgdXNlIHRoZSBmb2xsb3dpbmcgU1FMIHRvIGlkZW50aWZ5
IHdoaWNoIHRhYmxlCisgICAgIHN5bmNocm9uaXphdGlvbiBzbG90cyBzaG91bGQgYmUgc3luY2Vk
IHRvIHRoZSBzdGFuZGJ5IHRoYXQgd2UgcGxhbiB0byBwcm9tb3RlLgorICAgICBUaGlzIHNwZWNp
ZmljIHF1ZXJ5IG5lZWRzIHRvIGJlIHJ1biBvbiBlYWNoIGRhdGFiYXNlIHRoYXQgaW5jbHVkZXMg
dGhlIGZhaWxvdmVyCisgICAgIGVuYWJsZWQgc3Vic2NyaXB0aW9uKHMpLiBOb3RlIHRoYXQgdGhl
IHRhYmxlIHN5bmMgc2xvdCBzaG91bGQgYmUgc3luY2VkIHRvIHRoZQorICAgICBzdGFuZGJ5IHNl
cnZlciBvbmx5IGlmIHRoZSB0YWJsZSBjb3B5IGlzIGZpbmlzaGVkCisgICAgIChTZWUgPHhyZWYg
bGlua2VuZD0iY2F0YWxvZy1wZy1zdWJzY3JpcHRpb24tcmVsIi8+KS4KICAgICAgV2UgZG9uJ3Qg
bmVlZCB0byBlbnN1cmUgdGhhdCB0aGUgdGFibGUgc3luYyBzbG90cyBhcmUgc3luY2VkIGluIG90
aGVyIHNjZW5hcmlvcwogICAgICBhcyB0aGV5IHdpbGwgZWl0aGVyIGJlIGRyb3BwZWQgb3IgcmUt
Y3JlYXRlZCBvbiB0aGUgbmV3IHByaW1hcnkgc2VydmVyIGluIHRob3NlCiAgICAgIGNhc2VzLgog
PHByb2dyYW1saXN0aW5nPgogdGVzdF9zdWI9IyBTRUxFQ1QKLSAgICAgICAgICAgICAgIGFycmF5
X2FnZyhzbG90X25hbWUpIEFTIHNsb3RzCisgICAgICAgICAgICAgICBhcnJheV9hZ2cocXVvdGVf
bGl0ZXJhbChzbG90X25hbWUpKSBBUyBzbG90cwogICAgICAgICAgICBGUk9NCi0gICAgICAgICAg
ICgoCi0gICAgICAgICAgICAgICBTRUxFQ1Qgci5zcnN1YmlkIEFTIHN1YmlkLCBDT05DQVQoJ3Bn
XycsIHNyc3ViaWQsICdfc3luY18nLCBzcnJlbGlkLCAnXycsIGN0bC5zeXN0ZW1faWRlbnRpZmll
cikgQVMgc2xvdF9uYW1lCisgICAgICAgICAgICgKKyAgICAgICAgICAgICAgIFNFTEVDVCBDT05D
QVQoJ3BnXycsIHNyc3ViaWQsICdfc3luY18nLCBzcnJlbGlkLCAnXycsIGN0bC5zeXN0ZW1faWRl
bnRpZmllcikgQVMgc2xvdF9uYW1lCiAgICAgICAgICAgICAgICBGUk9NIHBnX2NvbnRyb2xfc3lz
dGVtKCkgY3RsLCBwZ19zdWJzY3JpcHRpb25fcmVsIHIsIHBnX3N1YnNjcmlwdGlvbiBzCiAgICAg
ICAgICAgICAgICBXSEVSRSByLnNyc3Vic3RhdGUgPSAnZicgQU5EIHMub2lkID0gci5zcnN1Ymlk
IEFORCBzLnN1YmZhaWxvdmVyCi0gICAgICAgICAgICkgVU5JT04gKAotICAgICAgICAgICAgICAg
U0VMRUNUIHMub2lkIEFTIHN1YmlkLCBzLnN1YnNsb3RuYW1lIGFzIHNsb3RfbmFtZQotICAgICAg
ICAgICAgICAgRlJPTSBwZ19zdWJzY3JpcHRpb24gcwotICAgICAgICAgICAgICAgV0hFUkUgcy5z
dWJmYWlsb3ZlcgotICAgICAgICAgICApKQotICAgICAgICAgICBXSEVSRSBzbG90X25hbWUgSVMg
Tk9UIE5VTEw7CisgICAgICAgICAgICk7CiAgc2xvdHMKIC0tLS0tLS0KLSB7c3ViMSxzdWIyLHN1
YjN9CisgeydwZ18xNjM5NF9zeW5jXzE2Mzg1XzczOTQ2NjY3MTUxNDkwNTUxNjQnfQogKDEgcm93
KQogPC9wcm9ncmFtbGlzdGluZz48L3BhcmE+CiAgICA8L3N0ZXA+CkBAIC03NjEsMTMgKzc3NCwx
NSBAQCB0ZXN0X3N1Yj0jIFNFTEVDVAogPHByb2dyYW1saXN0aW5nPgogdGVzdF9zdGFuZGJ5PSMg
U0VMRUNUIHNsb3RfbmFtZSwgKHN5bmNlZCBBTkQgTk9UIHRlbXBvcmFyeSBBTkQgTk9UIGNvbmZs
aWN0aW5nKSBBUyBmYWlsb3Zlcl9yZWFkeQogICAgICAgICAgICAgICAgRlJPTSBwZ19yZXBsaWNh
dGlvbl9zbG90cwotICAgICAgICAgICAgICAgV0hFUkUgc2xvdF9uYW1lIElOICgnc3ViMScsJ3N1
YjInLCdzdWIzJyk7Ci0gIHNsb3RfbmFtZSAgfCBmYWlsb3Zlcl9yZWFkeQotLS0tLS0tLS0tLS0t
LSstLS0tLS0tLS0tLS0tLS0tCi0gIHN1YjEgICAgICAgfCB0Ci0gIHN1YjIgICAgICAgfCB0Ci0g
IHN1YjMgICAgICAgfCB0Ci0oMyByb3dzKQorICAgICAgICAgICAgICAgV0hFUkUgc2xvdF9uYW1l
IElOCisgICAgICAgICAgICAgICAgICAgKCdzdWIxJywnc3ViMicsJ3N1YjMnLCAncGdfMTYzOTRf
c3luY18xNjM4NV83Mzk0NjY2NzE1MTQ5MDU1MTY0Jyk7CisgIHNsb3RfbmFtZSAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwgZmFpbG92ZXJfcmVhZHkKKy0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0KKyAgc3ViMSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCB0CisgIHN1YjIgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHwgdAorICBzdWIzICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8IHQKKyAgcGdfMTYzOTRfc3luY18xNjM4NV83Mzk0NjY2NzE1MTQ5
MDU1MTY0ICAgfCB0CisoNCByb3dzKQogPC9wcm9ncmFtbGlzdGluZz48L3BhcmE+CiAgICAgPC9z
dGVwPgogICA8L3Byb2NlZHVyZT4KLS0gCjIuMzQuMQoK
--0000000000004b6caf061df67728--