MIME-Version: 1.0
In-Reply-To: <4E7B815B.7080500@timbira.com>
References: <1316524671.9044.12.camel@fsopti579.F-Secure.com>
	<4E794FB5.80400@2ndQuadrant.com>
	<1316613536.14119.6.camel@fsopti579.F-Secure.com>
	<4E7A6D0D.4060106@2ndQuadrant.com> <4E7A887F.8010908@timbira.com>
	<CAK3UJRHChOcGQ0kzu01wZX6PB9pScHSzg1X+hThdR7QXWoe1yw@mail.gmail.com>
	<4E7B815B.7080500@timbira.com>
From: Josh Kupershmidt <schmiddy@gmail.com>
Date: Thu, 22 Sep 2011 15:29:25 -0400
Message-ID: 
 <CAK3UJREJd31vOd3QPrWTbB9a86D9HPV4PRNuc-B8gB5kxHT0OQ@mail.gmail.com>
Subject: Re: somewhat wrong archive_command example
To: Euler Taveira de Oliveira <euler@timbira.com>
Cc: Greg Smith <greg@2ndquadrant.com>, pgsql-docs@postgresql.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 22, 2011 at 2:41 PM, Euler Taveira de Oliveira
<euler@timbira.com> wrote:
> On 22-09-2011 15:15, Josh Kupershmidt wrote:
>> =A01.) IMO it's more logical to put the test for whether the $ARCHIVE
>> directory exists before the test whether ${ARCHIVE}/${FILE} exists.
>
> No. If you do so, it will end up wasting a lot of cpu cycles testing
> something that is *always* true (if the directory exists). AFAICS this te=
st
> is to handle a cp failure case nicely.

Maybe I misunderstand you.. I was talking about this test, which was
in Greg's script already:

if [ ! -d ${ARCHIVE} ] ; then
  echo Archive directory does not exist >&2
  exit 1
fi

I don't see how it would make any difference performance-wise whether
this block is moved up to right before the "if [ -f ${ARCHIVE}/${FILE}
] ; then" line: we expect both of these if-statements to evaluate
false if they are reached.

Josh