public inbox for [email protected]  
help / color / mirror / Atom feed
From: Josh Kupershmidt <[email protected]>
To: pgsql-docs <[email protected]>
Subject: Rewording for ALTER TABLE ... ADD table_constraint_using_index
Date: Wed, 26 Aug 2015 19:31:53 -0400
Message-ID: <CAK3UJRF=KY_nx_TRQq+t6jOrtS2rry79ktkzPiMDhFx_K=dZAg@mail.gmail.com> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

I'd like to propose the following slight rewording for the note about ALTER
TABLE ... ADD table_constraint_using_index. The existing text says one may
"install it [the existing index] as an official constraint".

The "official constraint" phrase sounds like weasel wording to me -- how is
a UNIQUE constraint more "official" than an UNIQUE index? Then "install"
makes it sound like some installation process is going on that you should
be aware of. I like "convert" slightly better instead.

Josh

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
new file mode 100644
index 92e9ce8..784f5b4
*** a/doc/src/sgml/ref/alter_table.sgml
--- b/doc/src/sgml/ref/alter_table.sgml
*************** ALTER TABLE ALL IN TABLESPACE <replaceab
*** 320,327 ****
         Adding a constraint using an existing index can be helpful in
         situations where a new constraint needs to be added without blocking
         table updates for a long time.  To do that, create the index using
!        <command>CREATE INDEX CONCURRENTLY</>, and then install it as an
!        official constraint using this syntax.  See the example below.
        </para>
       </note>
      </listitem>
--- 320,327 ----
         Adding a constraint using an existing index can be helpful in
         situations where a new constraint needs to be added without blocking
         table updates for a long time.  To do that, create the index using
!        <command>CREATE UNIQUE INDEX CONCURRENTLY</>, and then convert it to a
!        constraint using this syntax.  See the example below.
        </para>
       </note>
      </listitem>


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Attachments:

  [text/plain] alter_table_table_constraint_using_index.diff (1.1K, 3-alter_table_table_constraint_using_index.diff)
  download | inline diff:
diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
new file mode 100644
index 92e9ce8..784f5b4
*** a/doc/src/sgml/ref/alter_table.sgml
--- b/doc/src/sgml/ref/alter_table.sgml
*************** ALTER TABLE ALL IN TABLESPACE <replaceab
*** 320,327 ****
         Adding a constraint using an existing index can be helpful in
         situations where a new constraint needs to be added without blocking
         table updates for a long time.  To do that, create the index using
!        <command>CREATE INDEX CONCURRENTLY</>, and then install it as an
!        official constraint using this syntax.  See the example below.
        </para>
       </note>
      </listitem>
--- 320,327 ----
         Adding a constraint using an existing index can be helpful in
         situations where a new constraint needs to be added without blocking
         table updates for a long time.  To do that, create the index using
!        <command>CREATE UNIQUE INDEX CONCURRENTLY</>, and then convert it to a
!        constraint using this syntax.  See the example below.
        </para>
       </note>
      </listitem>


reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Rewording for ALTER TABLE ... ADD table_constraint_using_index
  In-Reply-To: <CAK3UJRF=KY_nx_TRQq+t6jOrtS2rry79ktkzPiMDhFx_K=dZAg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox