MIME-Version: 1.0
In-Reply-To: <23280.1335711812@sss.pgh.pa.us>
References: <4683.1335648276@sss.pgh.pa.us>
	<CAK3UJRH-8xmhb4G3t=LPQed3ZCtt2Jk+XH8GZkBqO45bJX7SLw@mail.gmail.com>
	<23280.1335711812@sss.pgh.pa.us>
From: Josh Kupershmidt <schmiddy@gmail.com>
Date: Sun, 29 Apr 2012 11:56:30 -0700
Message-ID: 
 <CAK3UJRGPwcO2FN5Ktmh=bQ75pb4Q7R39EgSmLHTVvrca08N3Hw@mail.gmail.com>
Subject: Re: Documentation of underlying functions for statistics views
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-docs@postgresql.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 29, 2012 at 8:03 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Josh Kupershmidt <schmiddy@gmail.com> writes:
>> I did find it marginally useful to see clarifications of milliseconds
>> vs. microseconds =A0(e.g. "block_write_time" column). Yeah, you could
>> figure out that based on the " / 1000" in the view description, but
>> it'd be a bit less obvious. So maybe keep just those?
>
> There's an existing paragraph that explains that the underlying
> functions take backend ID or table/index/function OID. =A0I was thinking
> of expanding that to add the recommendation to look at the view
> definitions. =A0We could also add a sentence there that says that for
> timing columns, the underlying function reports integer microseconds
> which are converted to milliseconds by the view. =A0I think that's better
> than repeating the info for each such column.

Yeah, that sounds fine. The paragraph I think you're talking about
claims "These functions are listed in Table 27-13", but Table 27-13
only has a few functions (e.g. pg_stat_get_db_block_time_read() is
missing). Maybe that paragraph could  clarify that it's talking
generally about all the views/functions on that page.

Josh