public inbox for [email protected]  
help / color / mirror / Atom feed
Incomplete compatibility information for triggers
5+ messages / 3 participants
[nested] [flat]

* Incomplete compatibility information for triggers
@ 2012-11-11 20:52  Louis-Claude Canon <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Louis-Claude Canon @ 2012-11-11 20:52 UTC (permalink / raw)
  To: pgsql-docs

Hello,

the compatibility section of the "create trigger" page 
(http://www.postgresql.org/docs/devel/static/sql-createtrigger.html) 
claims that a missing functionality is the ability to define aliases for 
the "old" and "new" rows or tables. If I am understanding this 
correctly, another related missing functionality is that PostgreSQL does 
not allow the old and new tables to be referenced for statement-level 
triggers (i.e., the "OLD TABLE" that contains all the deleted/modified 
rows in case of deletion/update). I think this is also worth noting as 
any workaround for it seems to be more difficult (if possible at all) 
than for the missing alias feature.

Regards,

Louis-Claude Canon




^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Incomplete compatibility information for triggers
@ 2012-11-14 04:23  Josh Kupershmidt <[email protected]>
  parent: Louis-Claude Canon <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Josh Kupershmidt @ 2012-11-14 04:23 UTC (permalink / raw)
  To: Louis-Claude Canon <[email protected]>; +Cc: pgsql-docs

On Sun, Nov 11, 2012 at 3:52 PM, Louis-Claude Canon
<[email protected]> wrote:

> the compatibility section of the "create trigger" page
> (http://www.postgresql.org/docs/devel/static/sql-createtrigger.html) claims
> that a missing functionality is the ability to define aliases for the "old"
> and "new" rows or tables. If I am understanding this correctly, another
> related missing functionality is that PostgreSQL does not allow the old and
> new tables to be referenced for statement-level triggers (i.e., the "OLD
> TABLE" that contains all the deleted/modified rows in case of
> deletion/update). I think this is also worth noting as any workaround for it
> seems to be more difficult (if possible at all) than for the missing alias
> feature.

+1, it seems like a useful missing piece from the SQL:2011 standard.
Care to send a documentation patch?

Josh




^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Incomplete compatibility information for triggers
@ 2012-11-14 21:19  Louis-Claude Canon <[email protected]>
  parent: Josh Kupershmidt <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Louis-Claude Canon @ 2012-11-14 21:19 UTC (permalink / raw)
  To: Josh Kupershmidt <[email protected]>; +Cc: pgsql-docs

Le 14/11/2012 05:23, Josh Kupershmidt a écrit :
> On Sun, Nov 11, 2012 at 3:52 PM, Louis-Claude Canon
> <[email protected]> wrote:
>
>> the compatibility section of the "create trigger" page
>> (http://www.postgresql.org/docs/devel/static/sql-createtrigger.html) claims
>> that a missing functionality is the ability to define aliases for the "old"
>> and "new" rows or tables. If I am understanding this correctly, another
>> related missing functionality is that PostgreSQL does not allow the old and
>> new tables to be referenced for statement-level triggers (i.e., the "OLD
>> TABLE" that contains all the deleted/modified rows in case of
>> deletion/update). I think this is also worth noting as any workaround for it
>> seems to be more difficult (if possible at all) than for the missing alias
>> feature.
> +1, it seems like a useful missing piece from the SQL:2011 standard.
> Care to send a documentation patch?

Let me know if it requires a second round.

By the way, I can propose another patch regarding the transaction 
isolation relatively to my previous post on pgsql-bugs.

Louis


Attachments:

  [text/x-patch] 0001-Document-the-missing-OLD-NEW-TABLE-trigger-feature.patch (0B, 2-0001-Document-the-missing-OLD-NEW-TABLE-trigger-feature.patch)
  download

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Incomplete compatibility information for triggers
@ 2013-01-13 21:47  Josh Kupershmidt <[email protected]>
  parent: Louis-Claude Canon <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Josh Kupershmidt @ 2013-01-13 21:47 UTC (permalink / raw)
  To: Louis-Claude Canon <[email protected]>; +Cc: pgsql-docs

On Wed, Nov 14, 2012 at 2:19 PM, Louis-Claude Canon
<[email protected]> wrote:
> Le 14/11/2012 05:23, Josh Kupershmidt a écrit :
>
>> On Sun, Nov 11, 2012 at 3:52 PM, Louis-Claude Canon
>> <[email protected]> wrote:
>>
>>> the compatibility section of the "create trigger" page
>>> (http://www.postgresql.org/docs/devel/static/sql-createtrigger.html)
>>> claims
>>> that a missing functionality is the ability to define aliases for the
>>> "old"
>>> and "new" rows or tables. If I am understanding this correctly, another
>>> related missing functionality is that PostgreSQL does not allow the old
>>> and
>>> new tables to be referenced for statement-level triggers (i.e., the "OLD
>>> TABLE" that contains all the deleted/modified rows in case of
>>> deletion/update). I think this is also worth noting as any workaround for
>>> it
>>> seems to be more difficult (if possible at all) than for the missing
>>> alias
>>> feature.
>>
>> +1, it seems like a useful missing piece from the SQL:2011 standard.
>> Care to send a documentation patch?
>
>
> Let me know if it requires a second round.

A (belated) +1 for this patch. There were two small typos which I've
fixed in the attached version. You may want to add this patch soon to
the 2013-01 CommitFest so it doesn't get lost.

> By the way, I can propose another patch regarding the transaction isolation
> relatively to my previous post on pgsql-bugs.

If that doc change hasn't been made yet, you may want to post a patch.

Josh


-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


Attachments:

  [application/octet-stream] 0002-Document-the-missing-OLD-NEW-TABLE-trigger-feature.patch (1.6K, 2-0002-Document-the-missing-OLD-NEW-TABLE-trigger-feature.patch)
  download | inline diff:
diff --git a/doc/src/sgml/ref/create_trigger.sgml b/doc/src/sgml/ref/create_trigger.sgml
new file mode 100644
index 0f87b1f..49a8130
*** a/doc/src/sgml/ref/create_trigger.sgml
--- b/doc/src/sgml/ref/create_trigger.sgml
*************** CREATE TRIGGER view_insert
*** 484,494 ****
    <para>
     The <command>CREATE TRIGGER</command> statement in
     <productname>PostgreSQL</productname> implements a subset of the
!    <acronym>SQL</> standard. The following functionality is currently missing:
  
     <itemizedlist>
      <listitem>
       <para>
        SQL allows you to define aliases for the <quote>old</quote>
        and <quote>new</quote> rows or tables for use in the definition
        of the triggered action (e.g., <literal>CREATE TRIGGER ... ON
--- 484,505 ----
    <para>
     The <command>CREATE TRIGGER</command> statement in
     <productname>PostgreSQL</productname> implements a subset of the
!    <acronym>SQL</> standard. The following functionalities are currently
!    missing:
  
     <itemizedlist>
      <listitem>
       <para>
+       <productname>PostgreSQL</productname> does not allow the old and new
+       tables to be referenced for statement-level triggers (i.e., the tables
+       that contain all the old and/or new rows, which are referred to as
+       <literal>OLD TABLE</literal> and <literal>NEW TABLE</literal> in the
+       <acronym>SQL</> standard).
+      </para>
+     </listitem>
+ 
+     <listitem>
+      <para>
        SQL allows you to define aliases for the <quote>old</quote>
        and <quote>new</quote> rows or tables for use in the definition
        of the triggered action (e.g., <literal>CREATE TRIGGER ... ON


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Incomplete compatibility information for triggers
@ 2013-02-23 05:30  Peter Eisentraut <[email protected]>
  parent: Josh Kupershmidt <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: Peter Eisentraut @ 2013-02-23 05:30 UTC (permalink / raw)
  To: Josh Kupershmidt <[email protected]>; +Cc: Louis-Claude Canon <[email protected]>; pgsql-docs

On Sun, 2013-01-13 at 14:47 -0700, Josh Kupershmidt wrote:
> On Wed, Nov 14, 2012 at 2:19 PM, Louis-Claude Canon
> <[email protected]> wrote:
> > Le 14/11/2012 05:23, Josh Kupershmidt a écrit :
> >
> >> On Sun, Nov 11, 2012 at 3:52 PM, Louis-Claude Canon
> >> <[email protected]> wrote:
> >>
> >>> the compatibility section of the "create trigger" page
> >>> (http://www.postgresql.org/docs/devel/static/sql-createtrigger.html)
> >>> claims
> >>> that a missing functionality is the ability to define aliases for the
> >>> "old"
> >>> and "new" rows or tables. If I am understanding this correctly, another
> >>> related missing functionality is that PostgreSQL does not allow the old
> >>> and
> >>> new tables to be referenced for statement-level triggers (i.e., the "OLD
> >>> TABLE" that contains all the deleted/modified rows in case of
> >>> deletion/update). I think this is also worth noting as any workaround for
> >>> it
> >>> seems to be more difficult (if possible at all) than for the missing
> >>> alias
> >>> feature.
> >>
> >> +1, it seems like a useful missing piece from the SQL:2011 standard.
> >> Care to send a documentation patch?
> >
> >
> > Let me know if it requires a second round.
> 
> A (belated) +1 for this patch. There were two small typos which I've
> fixed in the attached version.

Committed.



-- 
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs




^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2013-02-23 05:30 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2012-11-11 20:52 Incomplete compatibility information for triggers Louis-Claude Canon <[email protected]>
2012-11-14 04:23 ` Josh Kupershmidt <[email protected]>
2012-11-14 21:19   ` Louis-Claude Canon <[email protected]>
2013-01-13 21:47     ` Josh Kupershmidt <[email protected]>
2013-02-23 05:30       ` Peter Eisentraut <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox