MIME-Version: 1.0
In-Reply-To: <4E7A887F.8010908@timbira.com>
References: <1316524671.9044.12.camel@fsopti579.F-Secure.com>
	<4E794FB5.80400@2ndQuadrant.com>
	<1316613536.14119.6.camel@fsopti579.F-Secure.com>
	<4E7A6D0D.4060106@2ndQuadrant.com> <4E7A887F.8010908@timbira.com>
From: Josh Kupershmidt <schmiddy@gmail.com>
Date: Thu, 22 Sep 2011 14:15:30 -0400
Message-ID: 
 <CAK3UJRHChOcGQ0kzu01wZX6PB9pScHSzg1X+hThdR7QXWoe1yw@mail.gmail.com>
Subject: Re: somewhat wrong archive_command example
To: Greg Smith <greg@2ndquadrant.com>,
	Euler Taveira de Oliveira <euler@timbira.com>
Cc: pgsql-docs@postgresql.org
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Sep 21, 2011 at 8:59 PM, Euler Taveira de Oliveira
<euler@timbira.com> wrote:
> On 21-09-2011 20:02, Greg Smith wrote:
>>
>> Attached version fixes the late night brain fade errors. I think the right
>> thing to do next is to package this up into a doc update that corrects the
>> errors in that section too; just clean the whole thing up while I'm poking
>> at
>> it. I'll submit that over to the hackers list so that everyone can take a
>> shot
>> at correcting my shell code.

First, a +1 on the impetus for this script.

Few more suggestions/nitpicks:
 1.) IMO it's more logical to put the test for whether the $ARCHIVE
directory exists before the test whether ${ARCHIVE}/${FILE} exists.
 2.) I think the error code reporting here is not sound:

cp ${FULLPATH} ${ARCHIVE}/${FILE}
if [ $? -ne 0 ] ; then
  echo $0 Archive copy of ${FILE} failed with error $? >&2

at least on my OS X machine, that echo produces a message like
"./local_backup_script.sh Archive copy of failed with error 0", I
guess since $? gets reset to 0 after that if-statement. You can use a
temporary variable like $ERRCODE=$? to get around this.

Josh