MIME-Version: 1.0
References: 
 <CAKFQuwZKQoOEHQgTREb7swqryWjHVckcrpOrHUKQqEHznsZfGA@mail.gmail.com>
In-Reply-To: 
 <CAKFQuwZKQoOEHQgTREb7swqryWjHVckcrpOrHUKQqEHznsZfGA@mail.gmail.com>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Mon, 11 Apr 2022 20:21:49 -0700
Message-ID: 
 <CAKFQuwYN20c0+7kKvm3PBgibu77BzxDvk9RvoXBb1=j1mDODPw@mail.gmail.com>
Subject: Re: Update wording of INSERT ON CONFLICT "rows proposed for
 insertion"
To: Pg Docs <pgsql-docs@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000c68d8b05dc6c9047"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKFQuwYN20c0%2B7kKvm3PBgibu77BzxDvk9RvoXBb1%3Dj1mDODPw%40mail.gmail.com>
Precedence: bulk

--000000000000c68d8b05dc6c9047
Content-Type: multipart/alternative; boundary="000000000000c68d8a05dc6c9045"

--000000000000c68d8a05dc6c9045
Content-Type: text/plain; charset="UTF-8"

On Tue, Mar 8, 2022 at 5:14 PM David G. Johnston <david.g.johnston@gmail.com>
wrote:

>
> I suggest a minor rewording of:
>
> https://www.postgresql.org/docs/devel/sql-insert.html
>
>
Concretely as attached.  I did a bit more than minor work - I decided that
actually calling it a table in the docs didn't really fit how it behaves in
practice and so reworded the "table" into just "name".  Please see the
commit message for more exposition.

David J.

--000000000000c68d8a05dc6c9045
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:arial,helvetica,sans-serif"><span style=3D"font-family:Arial,Helve=
tica,sans-serif">On Tue, Mar 8, 2022 at 5:14 PM David G. Johnston &lt;<a hr=
ef=3D"mailto:david.g.johnston@gmail.com">david.g.johnston@gmail.com</a>&gt;=
 wrote:</span><br></div></div><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div style=3D"font-family=
:arial,helvetica,sans-serif"><br></div><div style=3D"font-family:arial,helv=
etica,sans-serif">I suggest a minor rewording of:</div><div style=3D"font-f=
amily:arial,helvetica,sans-serif"><br></div><div style=3D"font-family:arial=
,helvetica,sans-serif"><a href=3D"https://www.postgresql.org/docs/devel/sql=
-insert.html" target=3D"_blank">https://www.postgresql.org/docs/devel/sql-i=
nsert.html</a><br></div><div style=3D"font-family:arial,helvetica,sans-seri=
f"><br></div></div></blockquote><div><br></div><div class=3D"gmail_default"=
 style=3D"font-family:arial,helvetica,sans-serif">Concretely as attached.=
=C2=A0 I did a bit more than minor work - I decided that actually calling i=
t a table in the docs didn&#39;t really fit how it behaves in practice and =
so reworded the &quot;table&quot; into just &quot;name&quot;.=C2=A0 Please =
see the commit message for more exposition.</div><div class=3D"gmail_defaul=
t" style=3D"font-family:arial,helvetica,sans-serif"><br></div><div class=3D=
"gmail_default" style=3D"font-family:arial,helvetica,sans-serif">David J.</=
div><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-=
serif"><br></div></div></div>

--000000000000c68d8a05dc6c9045--

--000000000000c68d8b05dc6c9047
Content-Type: application/octet-stream;
	name="v0001-on-conflict-excluded-is-name-not-table.patch"
Content-Disposition: attachment;
	filename="v0001-on-conflict-excluded-is-name-not-table.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_l1vkrwxz0>
X-Attachment-Id: f_l1vkrwxz0

Y29tbWl0IDNhZTEyNWFhZmI1YmFkMDYyOTUyYmUxZTlmOTdjYjIyODgzNTBmNWIKQXV0aG9yOiBE
YXZpZCBHLiBKb2huc3RvbiA8ZGF2aWQuZy5qb2huc3RvbkBnbWFpbC5jb20+CkRhdGU6ICAgVHVl
IEFwciAxMiAwMjo1MToxOCAyMDIyICswMDAwCgogICAgZG9jOiBGb3IgSU5TRVJUIE9OIENPTkZM
SUNUIGV4Y2x1ZGVkIGlzIGEgb25seSBhIG5hbWUsIG5vdCBhIHRhYmxlLgogICAgCiAgICBBcyBv
bmUgY2Fubm90IHBsYWNlIGV4Y2x1ZGVkIGluIGEgRlJPTSBjbGF1c2UgKHN1YnF1ZXJ5KSBpbiB0
aGUKICAgIE9OIENPTkZMSUNUIGNsYXVzZSByZWZlcnJpbmcgdG8gaXQgYXMgYSB0YWJsZSwgd2l0
aCBwbHVyYWwgcm93cwogICAgbm9uZXRoZWxlc3MsIGxlYWRzIHRoZSByZWFkZXIgdG8gaW5mZXIg
bW9yZSBhYm91dCB3aGF0IHRoZQogICAgYmVoYXZpb3IgaGVyZSBpcyB0aGFuIGlzIGNvcnJlY3Qu
IFdlIGFscmVhZHkganVzdCBzYXkgdXNlIHRoZQogICAgdGFibGUncyBuYW1lIGZvciB0aGUgZXhp
c3Rpbmcgcm93IHNvIGp1c3QgbWF0Y2ggdGhhdCBwYXR0ZXJuCiAgICBvZiB1c2luZyB0aGUgbmFt
ZSBleGNsdWRlZCBmb3IgdGhlIHByb3Bvc2VkIHJvdy4KICAgIAogICAgVGhlIGFsaWFzIGRlc2Ny
aXB0aW9uIGRvZXNuJ3QgaGF2ZSB0aGUgc2FtZSBpc3N1ZSByZWdhcmRpbmcgdGhlCiAgICB1c2Ug
b2YgdGhlIHdvcmQgdGFibGUgYW5kIHJvd3MsIGFzIHRoZSB1c2UgdGhlcmUgaXMgbW9yZSBjb25j
ZXB0dWFsLAogICAgYnV0IHRoZSB3b3JkaW5nIGFib3V0ICJvdGhlcndpc2UgdGFrZW4gYXMiIGlz
IHdyb25nOiByYXRoZXIgdHdvCiAgICBsYWJlbHMgb2YgZXhjbHVkZWQgZW5kIHVwIGluIHNjb3Bl
IGFuZCB5b3UgZ2V0IGFuIGFtYmlnaW91cyBuYW1lIGVycm9yLgogICAgCiAgICBUaGUgZXJyb3Ig
bWVzc2FnZXMgc3RpbGwgY29uc2lkZXIgZXhjbHVkZWQgdG8gYmUgYSB0YWJsZSByZWZlcmVuY2UK
ICAgIGFuZCB0aGlzIHBhdGNoIGRvZXMgbm90IHRyeSB0byBjaGFuZ2UgdGhhdC4gIFRoYXQgaW1w
bGVtZW50YXRpb24KICAgIGRldGFpbCBuZWVkIG5vdCBmb3JjZSB0aGUgdXNlci1mYWNpbmcgZG9j
dW1lbnRhdGlvbiBmb3IgdGhlIGZlYXR1cmUKICAgIHRvIHVzZSB0aGUgdGVybSB0YWJsZSB3aGVu
IGl0IGRvZXNuJ3QgcmVhbGx5IGFwcGx5LgoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYv
aW5zZXJ0LnNnbWwgYi9kb2Mvc3JjL3NnbWwvcmVmL2luc2VydC5zZ21sCmluZGV4IGE5YWY5OTU5
YzAuLjBmYWQxZDM2NDAgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9yZWYvaW5zZXJ0LnNnbWwK
KysrIGIvZG9jL3NyYy9zZ21sL3JlZi9pbnNlcnQuc2dtbApAQCAtMTc1LDkgKzE3NSw4IEBAIElO
U0VSVCBJTlRPIDxyZXBsYWNlYWJsZSBjbGFzcz0icGFyYW1ldGVyIj50YWJsZV9uYW1lPC9yZXBs
YWNlYWJsZT4gWyBBUyA8cmVwbGFjCiAgICAgICAgIGNsYXNzPSJwYXJhbWV0ZXIiPnRhYmxlX25h
bWU8L3JlcGxhY2VhYmxlPi4gIFdoZW4gYW4gYWxpYXMgaXMKICAgICAgICAgcHJvdmlkZWQsIGl0
IGNvbXBsZXRlbHkgaGlkZXMgdGhlIGFjdHVhbCBuYW1lIG9mIHRoZSB0YWJsZS4KICAgICAgICAg
VGhpcyBpcyBwYXJ0aWN1bGFybHkgdXNlZnVsIHdoZW4gPGxpdGVyYWw+T04gQ09ORkxJQ1QgRE8g
VVBEQVRFPC9saXRlcmFsPgotICAgICAgICB0YXJnZXRzIGEgdGFibGUgbmFtZWQgPHZhcm5hbWU+
ZXhjbHVkZWQ8L3Zhcm5hbWU+LCBzaW5jZSB0aGF0IHdpbGwgb3RoZXJ3aXNlCi0gICAgICAgIGJl
IHRha2VuIGFzIHRoZSBuYW1lIG9mIHRoZSBzcGVjaWFsIHRhYmxlIHJlcHJlc2VudGluZyByb3dz
IHByb3Bvc2VkCi0gICAgICAgIGZvciBpbnNlcnRpb24uCisgICAgICAgIHRhcmdldHMgYSB0YWJs
ZSBuYW1lZCA8dmFybmFtZT5leGNsdWRlZDwvdmFybmFtZT4sIHNpbmNlIHRoYXQgd2lsbAorICAg
ICAgICBjb25mbGljdCB3aXRoIHRoZSBzcGVjaWFsIG5hbWUgcmVwcmVzZW50aW5nIHRoZSByb3cg
cHJvcG9zZWQgZm9yIGluc2VydGlvbi4KICAgICAgICA8L3BhcmE+CiAgICAgICA8L2xpc3RpdGVt
PgogICAgICA8L3Zhcmxpc3RlbnRyeT4KQEAgLTM5Niw4ICszOTUsOCBAQCBJTlNFUlQgSU5UTyA8
cmVwbGFjZWFibGUgY2xhc3M9InBhcmFtZXRlciI+dGFibGVfbmFtZTwvcmVwbGFjZWFibGU+IFsg
QVMgPHJlcGxhYwogICAgICAgICBjb25mbGljdC4gIFRoZSA8bGl0ZXJhbD5TRVQ8L2xpdGVyYWw+
IGFuZAogICAgICAgICA8bGl0ZXJhbD5XSEVSRTwvbGl0ZXJhbD4gY2xhdXNlcyBpbiA8bGl0ZXJh
bD5PTiBDT05GTElDVCBETwogICAgICAgICBVUERBVEU8L2xpdGVyYWw+IGhhdmUgYWNjZXNzIHRv
IHRoZSBleGlzdGluZyByb3cgdXNpbmcgdGhlCi0gICAgICAgIHRhYmxlJ3MgbmFtZSAob3IgYW4g
YWxpYXMpLCBhbmQgdG8gcm93cyBwcm9wb3NlZCBmb3IgaW5zZXJ0aW9uCi0gICAgICAgIHVzaW5n
IHRoZSBzcGVjaWFsIDx2YXJuYW1lPmV4Y2x1ZGVkPC92YXJuYW1lPiB0YWJsZS4KKyAgICAgICAg
dGFibGUncyBuYW1lIChvciBhbiBhbGlhcyksIGFuZCB0byB0aGUgcHJvcG9zZWQgcm93CisgICAg
ICAgIHVzaW5nIHRoZSBuYW1lIDx2YXJuYW1lPmV4Y2x1ZGVkPC92YXJuYW1lPi4KICAgICAgICAg
PGxpdGVyYWw+U0VMRUNUPC9saXRlcmFsPiBwcml2aWxlZ2UgaXMgcmVxdWlyZWQgb24gYW55IGNv
bHVtbiBpbiB0aGUKICAgICAgICAgdGFyZ2V0IHRhYmxlIHdoZXJlIGNvcnJlc3BvbmRpbmcgPHZh
cm5hbWU+ZXhjbHVkZWQ8L3Zhcm5hbWU+CiAgICAgICAgIGNvbHVtbnMgYXJlIHJlYWQuCkBAIC02
OTksOCArNjk4LDggQEAgSU5TRVJUIElOVE8gZW1wbG95ZWVzX2xvZyBTRUxFQ1QgKiwgY3VycmVu
dF90aW1lc3RhbXAgRlJPTSB1cGQ7CiAgIDxwYXJhPgogICAgSW5zZXJ0IG9yIHVwZGF0ZSBuZXcg
ZGlzdHJpYnV0b3JzIGFzIGFwcHJvcHJpYXRlLiAgQXNzdW1lcyBhIHVuaXF1ZQogICAgaW5kZXgg
aGFzIGJlZW4gZGVmaW5lZCB0aGF0IGNvbnN0cmFpbnMgdmFsdWVzIGFwcGVhcmluZyBpbiB0aGUK
LSAgIDxsaXRlcmFsPmRpZDwvbGl0ZXJhbD4gY29sdW1uLiAgTm90ZSB0aGF0IHRoZSBzcGVjaWFs
Ci0gICA8dmFybmFtZT5leGNsdWRlZDwvdmFybmFtZT4gdGFibGUgaXMgdXNlZCB0byByZWZlcmVu
Y2UgdmFsdWVzIG9yaWdpbmFsbHkKKyAgIDxsaXRlcmFsPmRpZDwvbGl0ZXJhbD4gY29sdW1uLiAg
Tm90ZSB0aGF0IHRoZSBuYW1lCisgICA8dmFybmFtZT5leGNsdWRlZDwvdmFybmFtZT4gaXMgdXNl
ZCB0byByZWZlcmVuY2UgdmFsdWVzIG9yaWdpbmFsbHkKICAgIHByb3Bvc2VkIGZvciBpbnNlcnRp
b246CiA8cHJvZ3JhbWxpc3Rpbmc+CiBJTlNFUlQgSU5UTyBkaXN0cmlidXRvcnMgKGRpZCwgZG5h
bWUpCg==
--000000000000c68d8b05dc6c9047--