MIME-Version: 1.0
In-Reply-To: <28231.1533743837@sss.pgh.pa.us>
References: <153371978486.1298.2091761143788088262@wrigleys.postgresql.org>
 <28231.1533743837@sss.pgh.pa.us>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Wed, 8 Aug 2018 09:58:43 -0700
Message-ID: 
 <CAKFQuwYQwpS_qGdt7hWfsQnsrD9eZX0fif6tQNzhCHTZ80f-YA@mail.gmail.com>
Subject: Re: dblink_error_message return value
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: realyota@gmail.com, Joe Conway <mail@joeconway.com>,
 pgsql-docs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000006111650572ef6c60"
Precedence: bulk

--0000000000006111650572ef6c60
Content-Type: text/plain; charset="UTF-8"

On Wed, Aug 8, 2018 at 8:57 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> > Secondly
> > dblink_is_busy must be first called to make dblink_error_message returns
> an
> > error message. (Tested on 9.6.9)
>
> Meh.  I see what you're getting at here, I think, but that seems like a
> completely wrong/misleading statement of the issue.  Joe, can you think of
> better phraseology?
>

I would suggest that while rewording might be useful a more beneficial
improvement would be separating the commands into "Sync/ASync" and link
back into the corresponding libpq documentation sections which dblink
provides direct SQL layer access to (and which the docs seem to have been
written under the assumption the reader was knowledgeable of that API).  It
does abstract away some of the material in the libpq docs but I think it
would be a reasonable halfway measure in lieu of spending time enhancing
the mostly obsolete dblink extension documentation.

David J.

--0000000000006111650572ef6c60
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:arial,he=
lvetica,sans-serif"><span style=3D"font-family:arial,sans-serif">On Wed, Au=
g 8, 2018 at 8:57 AM, Tom Lane </span><span dir=3D"ltr" style=3D"font-famil=
y:arial,sans-serif">&lt;<a href=3D"mailto:tgl@sss.pgh.pa.us" target=3D"_bla=
nk">tgl@sss.pgh.pa.us</a>&gt;</span><span style=3D"font-family:arial,sans-s=
erif"> wrote:</span><br></div><div class=3D"gmail_extra"><div class=3D"gmai=
l_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde=
r-left:1px #ccc solid;padding-left:1ex">&gt; Secondly<br>
&gt; dblink_is_busy must be first called to make dblink_error_message retur=
ns an<br>
&gt; error message. (Tested on 9.6.9)<br>
<br>
Meh.=C2=A0 I see what you&#39;re getting at here, I think, but that seems l=
ike a<br>
completely wrong/misleading statement of the issue.=C2=A0 Joe, can you thin=
k of<br>
better phraseology?<br></blockquote><div><br></div><div class=3D"gmail_defa=
ult" style=3D"font-family:arial,helvetica,sans-serif">I would suggest that =
while rewording might be useful a more beneficial improvement would be sepa=
rating the commands into &quot;Sync/ASync&quot; and link back into the corr=
esponding libpq documentation sections which dblink provides direct SQL lay=
er access to (and which the docs seem to have been written under the assump=
tion the reader was knowledgeable of that API).=C2=A0 It does abstract away=
 some of the material in the libpq docs but I think it would be a reasonabl=
e halfway measure in lieu of spending time enhancing the mostly obsolete db=
link extension documentation.</div><div class=3D"gmail_default" style=3D"fo=
nt-family:arial,helvetica,sans-serif"><br></div><div class=3D"gmail_default=
" style=3D"font-family:arial,helvetica,sans-serif">David J.</div><div class=
=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif"><br></d=
iv></div></div></div>

--0000000000006111650572ef6c60--