Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XRrxC-0000Gm-E5 for pgsql-docs@arkaria.postgresql.org; Thu, 11 Sep 2014 00:09:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1XRrxB-0005k4-HO for pgsql-docs@arkaria.postgresql.org; Thu, 11 Sep 2014 00:09:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1XRrxA-0005jx-Jd for pgsql-docs@postgresql.org; Thu, 11 Sep 2014 00:09:36 +0000 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]) by magus.postgresql.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1XRrx7-0005AC-5J for pgsql-docs@postgresql.org; Thu, 11 Sep 2014 00:09:35 +0000 Received: by mail-we0-f179.google.com with SMTP id u56so5211977wes.24 for ; Wed, 10 Sep 2014 17:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MA2j5hpn43VAK/nbsLm2Kk5XBWifeJ648s+GDn1kUlo=; b=v7MrnVLJ/6U1JqQ6YYV3pdMHxojtwFXTt5FAtKtLHkfK5kIyv3Iwuh8yLTDqSk/M/X sw7rys0ZZ/4kBxAT9q7TM+hz+eS4B/NMozvl8GzXaPgiA4DeDxc+b5fHiysvfx7doAhL MrzrgUDddE35z8PMLv+R3TOwWKtZDVIxdZ5V8CGsu0gJzNLBIDmqRb9NixAalLMRdOCC CACyo7w4j2SzSVmXINiyc3oBv4rSG1ApThFgUH9UHX6nMIeEIGYbkve3G/AgAMp9zshj YyoZLQj1PxmVIQ2n1SwSiqMw84UKfPl0sLgXoFkZI9A9bgN+LgU6y/heL1RzpSY5eQWc tyDg== MIME-Version: 1.0 X-Received: by 10.180.189.14 with SMTP id ge14mr3011818wic.36.1410394170515; Wed, 10 Sep 2014 17:09:30 -0700 (PDT) Received: by 10.216.113.200 with HTTP; Wed, 10 Sep 2014 17:09:30 -0700 (PDT) In-Reply-To: <20140910202002.GA21173@momjian.us> References: <1400698826956-5804655.post@n5.nabble.com> <2916.1400704666@sss.pgh.pa.us> <20140909191317.GF16663@momjian.us> <20140910202002.GA21173@momjian.us> Date: Wed, 10 Sep 2014 20:09:30 -0400 Message-ID: Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration? From: David Johnston To: Bruce Momjian Cc: "pgsql-docs@postgresql.org" Content-Type: multipart/alternative; boundary=001a11c2285286e8e60502befbb9 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org --001a11c2285286e8e60502befbb9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 10, 2014 at 4:20 PM, Bruce Momjian wrote: > On Tue, Sep 9, 2014 at 03:40:45PM -0400, David Johnston wrote: > > > "In addition to setting global defaults or attaching" <- add a comma > after > > "defaults" > > I didn't like this change as it causes too many comma phrases. > > Attaches are the changes since yesterday's patch. The full patch is at: > > ftp://momjian.us/postgresql/mypatches/config.diff > > =E2=80=8BAt minimum the word "setting" in that paragraph needs to be made p= lural. ", you can pass settings to PostgreSQL..."=E2=80=8B =E2=80=8BI'm not particularly fond of the overly long preamble burying the = "shell facilities" - and the resultant comma separating the two - but cannot think of anything better. Not having the transition makes it too short and curt. The proposed second comma helped to at least break it up but it too doesn't sound all that great. I'm good for just making the plural fix and calling it a day. David J. =E2=80=8B --001a11c2285286e8e60502befbb9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Sep 10, 2014 = at 4:20 PM, Bruce Momjian <bruce@momjian= .us> wrote:
On Tue, Sep=C2=A0 9, 2014 at 03:40:45PM -0400, = David Johnston wrote:

> "In addition to setting global defaults or attaching" <- = add a comma after
> "defaults"

I didn't like this change as it causes too many comma phrases.
Attaches are the changes since yesterday's patch.=C2=A0 The full patch = is at:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 ftp://momjian.us/postgresql/mypatches/conf= ig.diff

<= br>
=E2=80=8BAt minimum the word "setting" in that p= aragraph needs to be made plural. ", you can pass settings to <prod= uctname>PostgreSQL..."=E2=80=8B

=E2=80=8BI&#= 39;m not particularly fond of the overly long preamble burying the "sh= ell facilities" - and the resultant comma separating the two - but can= not think of anything better. =C2=A0Not having the transition makes it too = short and curt. =C2=A0The proposed second comma helped to at least break it= up but it too doesn't sound all that great.

I'= ;m good for just making the plural fix and calling it a day.

David J.


=

=E2=80=8B
= =C2=A0
--001a11c2285286e8e60502befbb9--