MIME-Version: 1.0
References: <177609278737.403059.14174275013090471947@wrigleys.postgresql.org>
In-Reply-To: 
 <177609278737.403059.14174275013090471947@wrigleys.postgresql.org>
From: "David G. Johnston" <david.g.johnston@gmail.com>
Date: Wed, 15 Apr 2026 08:55:20 -0700
Message-ID: 
 <CAKFQuwZ86BE49-gzFunuu=u1ieT+T6q900=1Cx=vuO9Aqv9kcg@mail.gmail.com>
Subject: Re: Logical Replication upgrade
To: mimidatabase@gmail.com, pgsql-docs@lists.postgresql.org,
	Amit Kapila <amit.kapila16@gmail.com>
Content-Type: multipart/alternative; boundary="00000000000060c108064f81c0ac"
Archived-At: 
 <https://www.postgresql.org/message-id/CAKFQuwZ86BE49-gzFunuu%3Du1ieT%2BT6q900%3D1Cx%3DvuO9Aqv9kcg%40mail.gmail.com>
Precedence: bulk

--00000000000060c108064f81c0ac
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 15, 2026 at 7:52=E2=80=AFAM PG Doc comments form <noreply@postg=
resql.org>
wrote:

> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/18/logical-replication-upgrade.html
> Description:
>
> Hello there,
>
> I don't know if it's me but I find this sentence quite confusing in its
> current wording:
> All slots on the old cluster must be usable, i.e., there are no slots who=
se
> pg_replication_slots.conflicting is not true.
>
> The prerequisite is that no replication slot has conflicting=3Dtrue right=
?
> So this sentence (the i.e. part) suggests the opposite, as per my
> understanding.
>
> Here is the link (29.13.1):
>
> https://www.postgresql.org/docs/current/logical-replication-upgrade.html#=
STEPS-TWO-NODE-CIRCULAR-LOGICAL-REPLICATION-CLUSTER:~:text=3Dthere%20are%20=
no%20slots%20whose%20pg_replication_slots.conflicting%20is%20not%20true
>
>
You are correct.  Usage of a double-negative should be avoided as a matter
of style, but in this case it actually resolves to an untrue statement.

https://github.com/postgres/postgres/commit/7fdeaf5774d05245e82632e763665ff=
62db5598e

I've copied the committer for this.  Removing the "not" is simple enough;
though writing in the negative sense, while good for an SQL where clause,
does make reading in English more difficult.  Would rather say "all slots
must be false" rather than "no slots can be true".  The next item regarding
no persistent slots has the same complaint though it is factually correct
as written.  Though NULL is a valid value here so maybe the negative
phrasing is indeed necessary...

David J.

--00000000000060c108064f81c0ac
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_defa=
ult" style=3D"font-family:arial,helvetica,sans-serif"><span style=3D"font-f=
amily:Arial,Helvetica,sans-serif">On Wed, Apr 15, 2026 at 7:52=E2=80=AFAM P=
G Doc comments form &lt;<a href=3D"mailto:noreply@postgresql.org" target=3D=
"_blank">noreply@postgresql.org</a>&gt; wrote:</span></div></div><div class=
=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The foll=
owing documentation comment has been logged on the website:<br>
<br>
Page: <a href=3D"https://www.postgresql.org/docs/18/logical-replication-upg=
rade.html" rel=3D"noreferrer" target=3D"_blank">https://www.postgresql.org/=
docs/18/logical-replication-upgrade.html</a><br>
Description:<br>
<br>
Hello there,<br>
<br>
I don&#39;t know if it&#39;s me but I find this sentence quite confusing in=
 its<br>
current wording:<br>
All slots on the old cluster must be usable, i.e., there are no slots whose=
<br>
pg_replication_slots.conflicting is not true.<br>
<br>
The prerequisite is that no replication slot has conflicting=3Dtrue right?<=
br>
So this sentence (the i.e. part) suggests the opposite, as per my<br>
understanding.<br>
<br>
Here is the link (29.13.1):<br>
<a href=3D"https://www.postgresql.org/docs/current/logical-replication-upgr=
ade.html#STEPS-TWO-NODE-CIRCULAR-LOGICAL-REPLICATION-CLUSTER:~:text=3Dthere=
%20are%20no%20slots%20whose%20pg_replication_slots.conflicting%20is%20not%2=
0true" rel=3D"noreferrer" target=3D"_blank">https://www.postgresql.org/docs=
/current/logical-replication-upgrade.html#STEPS-TWO-NODE-CIRCULAR-LOGICAL-R=
EPLICATION-CLUSTER:~:text=3Dthere%20are%20no%20slots%20whose%20pg_replicati=
on_slots.conflicting%20is%20not%20true</a><br><br></blockquote><div><br></d=
iv><div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-s=
erif">You are correct.=C2=A0 Usage of a double-negative should be avoided a=
s a matter of style, but in this case it actually resolves to an untrue sta=
tement.</div><div class=3D"gmail_default" style=3D"font-family:arial,helvet=
ica,sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-family=
:arial,helvetica,sans-serif"><a href=3D"https://github.com/postgres/postgre=
s/commit/7fdeaf5774d05245e82632e763665ff62db5598e" target=3D"_blank">https:=
//github.com/postgres/postgres/commit/7fdeaf5774d05245e82632e763665ff62db55=
98e</a></div><div class=3D"gmail_default" style=3D"font-family:arial,helvet=
ica,sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-family=
:arial,helvetica,sans-serif">I&#39;ve copied the committer for this.=C2=A0 =
Removing the &quot;not&quot; is simple enough; though writing in the negati=
ve sense, while good for an SQL where clause, does make reading in English =
more difficult.=C2=A0 Would rather say &quot;all slots must be false&quot; =
rather than &quot;no slots can be true&quot;.=C2=A0 The next item regarding=
 no persistent slots has the same complaint though it is factually correct =
as written.=C2=A0 Though NULL is a valid value here so maybe the negative p=
hrasing is indeed necessary...</div><div class=3D"gmail_default" style=3D"f=
ont-family:arial,helvetica,sans-serif"><br></div><div class=3D"gmail_defaul=
t" style=3D"font-family:arial,helvetica,sans-serif">David J.</div><div clas=
s=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif"><br></=
div></div></div>
</div>

--00000000000060c108064f81c0ac--