public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G. Johnston <[email protected]>
To: [email protected]
To: [email protected]
Subject: Re: An example in UPDATE documentation page is a bit outdated
Date: Sat, 7 Mar 2026 13:45:19 -0700
Message-ID: <CAKFQuwZH4VqPkTz0bcEK0J_C=25W_G7gA7ZN=bQUddQinnyGKw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Sat, Mar 7, 2026 at 1:38 PM PG Doc comments form <[email protected]>
wrote:

> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/18/sql-update.html
> Description:
>
> There is an example on UPDATE documentation page --
>
> BEGIN;
> -- other operations
> SAVEPOINT sp1;
> INSERT INTO wines VALUES('Chateau Lafite 2003', '24');
> -- Assume the above fails because of a unique key violation,
> -- so now we issue these commands:
> ROLLBACK TO sp1;
> UPDATE wines SET stock = stock + 24 WHERE winename = 'Chateau Lafite 2003';
> -- continue with other operations, and eventually
> COMMIT;
>
> Now we can use INSERT ... ON CONFLICT DO UPDATE command in this case.
>
>
My second reaction was why would we put either variant on the update
command reference page.

Admittedly both of those examples are probably good to have somewhere, and
I'm not sure where would be the most discoverable place.

I'd rather remove the example and write a paragraph pointing the reader to
the savepoint and insert pages if they have a need to perform a conditional
insert/update pairing.

David J.

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: An example in UPDATE documentation page is a bit outdated
  In-Reply-To: <CAKFQuwZH4VqPkTz0bcEK0J_C=25W_G7gA7ZN=bQUddQinnyGKw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox