MIME-Version: 1.0
In-Reply-To: <26093.1402588800@sss.pgh.pa.us>
References: <53992FF8.2060702@po.ntts.co.jp>
 <CAHGQGwEPVu2T39Zddvh-CubJ9Ghyz4Gf1-JGqqvu5Ja7m5BJ7w@mail.gmail.com>
 <23802.1402584095@sss.pgh.pa.us>
 <CAKFQuwayss-PaqZ9+vCfc5h-WUKRtf7Lkn20THfWssmv1qa5eA@mail.gmail.com>
 <26093.1402588800@sss.pgh.pa.us>
Date: Thu, 12 Jun 2014 12:16:07 -0400
Message-ID: 
 <CAKFQuwZTB-kdvZZQgA6jSqyXtkcHdV9fFjSDt0gutnxmGFRnnw@mail.gmail.com>
Subject: Re: disabling log_rotation_age feature.
From: David Johnston <david.g.johnston@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: "pgsql-docs@postgresql.org" <pgsql-docs@postgresql.org>
Content-Type: multipart/alternative; boundary=f46d044280dee3ba2704fba5e0d0
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

--f46d044280dee3ba2704fba5e0d0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thursday, June 12, 2014, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> David G Johnston <david.g.johnston@gmail.com <javascript:;>> writes:
> > On Thu, Jun 12, 2014 at 10:42 AM, Tom Lane-2 [via PostgreSQL] <
> > ml-node+s1045698n5807014h58@n5.nabble.com <javascript:;>> wrote:
> >> I wonder if we should round fractions up instead of down in that logic=
?
> >> It might be less surprising for those GUCs where zero is special, and
> >> it seems like about a wash for most others.
>
> > =E2=80=8BI think documenting the behavior better,
>
> I don't.  If you have to explain it, it probably needs improvement.


No argument with the philosophy.


>
> > Green field maybe I'd say yes but given that the new behavior could tur=
n
> > features on that are currently off it doesn't seem to be beneficial
> enough
> > to warrant changing.
>
> I don't think that argument holds water either.  We routinely make
> changes that break old postgresql.conf files.  Not in minor updates
> of course, but none of this is material for back-patching.
>

Then I'd pick throwing an error if a floating point value is assigned to a
parameter that is defined to accept integer. I'd rather actually break the
file and not silently redefine its contents.

David J.

--f46d044280dee3ba2704fba5e0d0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thursday, June 12, 2014, Tom Lane &lt;<a href=3D"mailto:tgl@sss.pgh.pa.u=
s">tgl@sss.pgh.pa.us</a>&gt; wrote:<br><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">David=
 G Johnston &lt;<a href=3D"javascript:;" onclick=3D"_e(event, &#39;cvml&#39=
;, &#39;david.g.johnston@gmail.com&#39;)">david.g.johnston@gmail.com</a>&gt=
; writes:<br>

&gt; On Thu, Jun 12, 2014 at 10:42 AM, Tom Lane-2 [via PostgreSQL] &lt;<br>
&gt; <a href=3D"javascript:;" onclick=3D"_e(event, &#39;cvml&#39;, &#39;ml-=
node+s1045698n5807014h58@n5.nabble.com&#39;)">ml-node+s1045698n5807014h58@n=
5.nabble.com</a>&gt; wrote:<br>
&gt;&gt; I wonder if we should round fractions up instead of down in that l=
ogic?<br>
&gt;&gt; It might be less surprising for those GUCs where zero is special, =
and<br>
&gt;&gt; it seems like about a wash for most others.<br>
<br>
&gt; =E2=80=8BI think documenting the behavior better,<br>
<br>
I don&#39;t. =C2=A0If you have to explain it, it probably needs improvement=
.</blockquote><div><br></div><div>No argument with the philosophy.</div><di=
v>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex">

<br>
&gt; Green field maybe I&#39;d say yes but given that the new behavior coul=
d turn<br>
&gt; features on that are currently off it doesn&#39;t seem to be beneficia=
l enough<br>
&gt; to warrant changing.<br>
<br>
I don&#39;t think that argument holds water either. =C2=A0We routinely make=
<br>
changes that break old postgresql.conf files. =C2=A0Not in minor updates<br=
>
of course, but none of this=C2=A0is material for back-patching.<br></blockq=
uote><div><br></div><div>Then=C2=A0I&#39;d pick throwing an error if a floa=
ting point value is assigned to a parameter that is defined to accept integ=
er. I&#39;d rather actually break the file and not silently redefine its co=
ntents.</div>
<div><br></div><div>David J.</div><div><br></div><div>=C2=A0</div>

--f46d044280dee3ba2704fba5e0d0--