Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gPsF4-0004jY-Ac for pgsql-docs@arkaria.postgresql.org; Thu, 22 Nov 2018 16:54:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gPsF2-0001DV-NN for pgsql-docs@arkaria.postgresql.org; Thu, 22 Nov 2018 16:54:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gPsF2-0001DM-ES for pgsql-docs@lists.postgresql.org; Thu, 22 Nov 2018 16:54:12 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gPsF0-00021H-AJ for pgsql-docs@lists.postgresql.org; Thu, 22 Nov 2018 16:54:12 +0000 Received: by mail-qt1-x82c.google.com with SMTP id n21so8020849qtl.6 for ; Thu, 22 Nov 2018 08:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0+FjNQkOhIDHGnbLVfcmK2ZfEJj9zdJTL9GWqFvavQU=; b=qVW3BGKRtaM5XhkxbaiHpxZcFP6LK3/WFwpFZ48W0YAWsNq5q0AaPS/iNC11eL4bpL aC+Kwnj+XWK9pynSaRnIf7qn26RsgBFYeMwGHh2/03naxL8hBWW1fALulKS0lCDjcHXS XN+KhxF0xdBpDWz8dEIfe62MtKoGHKN/GJPhMPrZ7g/XwrOzVtG9bUZtJ2K5Rime3Nwz cEww24UO4eDj5pHq23KOe7gGhgB/SUa/QKU7mxGWz+VuNWQMMfMrbEeC/I6QhuHXeye6 UMneMsAchZcqTc9Ztz1ZUCplHh97Qs18f2BfI9Koz5eKyk6h26PhRgYjXOA+m7xOQUT0 KySg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0+FjNQkOhIDHGnbLVfcmK2ZfEJj9zdJTL9GWqFvavQU=; b=BftEN3lDFsa4zcCXQJbjVBTfqML+kf5lqemZeWxXK9/O2fOsXFAIjpZ//cWNipbwXt PdGBA116tjbMc40zCOUI58r7hjtwhPJ1fKzD7dR6SgFJBp+SclWKdP4TSy6lugmuY13k teWjJi9hPyCJJ2SQfbir3WYo2e7P60pcW9aWbCu4qmHek25e2RhgPL34NS1504mw3VKN mz5ZDnlR+x35Yhw3Ic+mROfaflJTjGARj6L5PfV6DtGWuQVRZsoFrYzy/4e+ii3aY1Jq Zk/NZn/hCaSkpgm9Da11xKPCJMtq4QPJsRQWwBeDpbmVxDm0/Te6qVYRxl4p6Rpr6W1q 4BJA== X-Gm-Message-State: AA+aEWZlWxEF0uil/X1Sfolr5AOjbO5Edibe9pCNaNkVP5hBXVEVS6DA E5Ye/c0KS5sGARFqpnAsDfsyG1kMWcAVdh3rPo0= X-Google-Smtp-Source: AFSGD/X11ov8qqU1JakAqxCvx44xFu1W+sPemP6+wy+nt3n3uZgAttEBGb1y9dayWA31aaXvCeit+Z9xQ/PNxOCjVEA= X-Received: by 2002:aed:31a3:: with SMTP id 32mr11074034qth.234.1542905648461; Thu, 22 Nov 2018 08:54:08 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a0c:ad5b:0:0:0:0:0 with HTTP; Thu, 22 Nov 2018 08:54:07 -0800 (PST) In-Reply-To: <20181122075806.GK3369@paquier.xyz> References: <154282901979.1316.7418475422120496802@wrigleys.postgresql.org> <20181122020759.GE3369@paquier.xyz> <20181122075806.GK3369@paquier.xyz> From: "David G. Johnston" Date: Thu, 22 Nov 2018 09:54:07 -0700 Message-ID: Subject: Re: CREATE/ALTER ROLE with NULL password To: Michael Paquier Cc: "steven.winfield@cantabcapital.com" , "pgsql-docs@lists.postgresql.org" Content-Type: multipart/alternative; boundary="000000000000193b41057b43b74e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000193b41057b43b74e Content-Type: text/plain; charset="UTF-8" On Thursday, November 22, 2018, Michael Paquier wrote: > On Wed, Nov 21, 2018 at 11:58:25PM -0700, David G. Johnston wrote: > > Should tweak the paragraph to point out this exception as well. > > > > The ENCRYPTED keyword has no effect, but is accepted for backwards > > compatibility[, except in the PASSWORD NULL form.] > > The docs list the following with the patch as supported grammar: > [ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL > And it seems to me that '|' has priority over '[]', so ENCRYPTED does > not apply to PASSWORD NULL if phrased this way. > > Yes, the syntax block is perfectly clear but we still explain said grammer in words and should be precise there as well, IMO. Not a big deal though. David J. --000000000000193b41057b43b74e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thursday, November 22, 2018, Michael Paquier <michael@paquier.xyz> wrote:
On Wed, Nov 21, 2018 at 11:58:25PM -0700, David G. Johnston wrote= :
> Should tweak the paragraph to point out this exception as well.
>
>=C2=A0 The ENCRYPTED keyword has no effect, but is accepted for backwar= ds
> compatibility[, except in the PASSWORD NULL form.]

The docs list the following with the patch as supported grammar:
[ ENCRYPTED ] PASSWORD 'password' | PASSWORD NULL
And it seems to me that '|' has priority over '[]', so ENCR= YPTED does
not apply to PASSWORD NULL if phrased this way.


Yes, the syntax block is perfectly clear b= ut we still explain said grammer in words and should be precise there as we= ll, IMO.=C2=A0 Not a big deal though.

David J.
=C2=A0
--000000000000193b41057b43b74e--