public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G. Johnston <[email protected]>
To: Euler Taveira <[email protected]>
Cc: Jeff Janes <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: "Alter system" command documentation
Date: Mon, 15 Jun 2015 17:10:16 -0400
Message-ID: <CAKFQuwZnoQKAi9qu_Vb6njo30x46MWZDNSExkvbs+hiOdjmHAA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAMkU=1xjSYan=T518E+=J4Ugg8xkymjx5a_hSFx1roB-chKyxw@mail.gmail.com>
	<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>

On Mon, Jun 15, 2015 at 4:58 PM, Euler Taveira <[email protected]> wrote:

> On 15-06-2015 13:32, Jeff Janes wrote:
> > From http://www.postgresql.org/docs/current/static/sql-altersystem.html
> >
> > "Values set with ALTER SYSTEM will be effective after the next server
> > configuration reload (SIGHUP or pg_ctl reload), or after the next server
> > restart in the case of parameters that can only be changed at server
> start."
> >
> > Isn't it unfortunate that the command used for changing the
> > configuration file from within SQL mentions SIGHUP and pg_ctl reload,
> > but not "select pg_reload_conf();", as a way to activate that change?
> >
> SIGHUP is an implementation detail. If I were to change that sentence,
> my preference is replace SIGHUP with pg_reload_conf.
> ​
>

​I ​
disagree on SIGHUP being an implementation detail.
​
​  Using signals in IPC (inter-process communication) is a public API that
should be documented when applicable.  Yes, various command-line and SQL
commands and functions have been provided so that one does not have to use
raw signals but they are still part of the public API for the application.

Adding mention of pg_reload_conf may be warranted (probably is but I
haven't made an independent evaluation) but removing SIGHUP is a separate
concern and one that doesn't seem necessary.

David J.
​

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: "Alter system" command documentation
  In-Reply-To: <CAKFQuwZnoQKAi9qu_Vb6njo30x46MWZDNSExkvbs+hiOdjmHAA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox