public inbox for [email protected]
help / color / mirror / Atom feedConflict in documentation
4+ messages / 3 participants
[nested] [flat]
* Conflict in documentation
@ 2026-03-18 11:17 PG Doc comments form <[email protected]>
2026-03-18 14:14 ` Re: Conflict in documentation David G. Johnston <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: PG Doc comments form @ 2026-03-18 11:17 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/18/logical-replication-row-filter.html
Description:
On page
https://www.postgresql.org/docs/current/logical-replication-row-filter.html#LOGICAL-REPLICATION-ROW-...
If the subscription requires copying pre-existing table data and a
publication contains WHERE clauses, only data that satisfies the row filter
expressions is copied to the subscriber.
and
Warning
Because initial data synchronization does not take into account the publish
parameter when copying existing table data, some rows may be copied that
would not be replicated using DML. Refer to Section 29.9.1, and see Section
29.2.2 for examples.
conflict.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Conflict in documentation
2026-03-18 11:17 Conflict in documentation PG Doc comments form <[email protected]>
@ 2026-03-18 14:14 ` David G. Johnston <[email protected]>
2026-03-18 14:55 ` RE: Conflict in documentation Blaziak, Sebastian <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: David G. Johnston @ 2026-03-18 14:14 UTC (permalink / raw)
To: [email protected] <[email protected]>; [email protected] <[email protected]>
On Wednesday, March 18, 2026, PG Doc comments form <[email protected]>
wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/18/logical-replication-
> row-filter.html
> Description:
>
> On page
> https://www.postgresql.org/docs/current/logical-
> replication-row-filter.html#LOGICAL-REPLICATION-ROW-
> FILTER-INITIAL-DATA-SYNC
>
> If the subscription requires copying pre-existing table data and a
> publication contains WHERE clauses, only data that satisfies the row filter
> expressions is copied to the subscriber.
>
> and
>
> Warning
> Because initial data synchronization does not take into account the publish
> parameter when copying existing table data, some rows may be copied that
> would not be replicated using DML. Refer to Section 29.9.1, and see Section
> 29.2.2 for examples.
>
> conflict.
>
>
I don’t see a conflict.
But I also don’t really see the point of the warning - at least not with
its present wording. There is the initial state and the change log (DML)
and comparing the two in this manner doesn’t make sense.
It’s seems a bit heavy to say: warning - publish does not apply to the
initial table sync. It seems like it could easily just be a note; or
removed altogether as we try to avoid documenting what things don’t do.
That all said I’m not planning on trying to push for a change here.
David J.
^ permalink raw reply [nested|flat] 4+ messages in thread
* RE: Conflict in documentation
2026-03-18 11:17 Conflict in documentation PG Doc comments form <[email protected]>
2026-03-18 14:14 ` Re: Conflict in documentation David G. Johnston <[email protected]>
@ 2026-03-18 14:55 ` Blaziak, Sebastian <[email protected]>
2026-03-18 16:55 ` Re: Conflict in documentation David G. Johnston <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Blaziak, Sebastian @ 2026-03-18 14:55 UTC (permalink / raw)
To: David G. Johnston <[email protected]>; [email protected] <[email protected]>
Hi David
The first line states that the initial data copy will _only_ copy filtered / relevant data.
While warning, but also elsewhere in the documentation it is stated that initial table _does not_ respect any publish limitations.
Hence the conflict.
Thx
Seb
From: David G. Johnston <[email protected]>
Sent: Wednesday, 18 March 2026 15:15
To: Blaziak, Sebastian <[email protected]>; [email protected]
Subject: Re: Conflict in documentation
On Wednesday, March 18, 2026, PG Doc comments form <[email protected]<mailto:[email protected]>> wrote:
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/18/logical-replication-row-filter.html<https://urldefense.com/v3/...;
Description:
On page
https://www.postgresql.org/docs/current/logical-replication-row-filter.html#LOGICAL-REPLICATION-ROW-...;
If the subscription requires copying pre-existing table data and a
publication contains WHERE clauses, only data that satisfies the row filter
expressions is copied to the subscriber.
and
Warning
Because initial data synchronization does not take into account the publish
parameter when copying existing table data, some rows may be copied that
would not be replicated using DML. Refer to Section 29.9.1, and see Section
29.2.2 for examples.
conflict.
I don't see a conflict.
But I also don't really see the point of the warning - at least not with its present wording. There is the initial state and the change log (DML) and comparing the two in this manner doesn't make sense.
It's seems a bit heavy to say: warning - publish does not apply to the initial table sync. It seems like it could easily just be a note; or removed altogether as we try to avoid documenting what things don't do.
That all said I'm not planning on trying to push for a change here.
David J.
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Conflict in documentation
2026-03-18 11:17 Conflict in documentation PG Doc comments form <[email protected]>
2026-03-18 14:14 ` Re: Conflict in documentation David G. Johnston <[email protected]>
2026-03-18 14:55 ` RE: Conflict in documentation Blaziak, Sebastian <[email protected]>
@ 2026-03-18 16:55 ` David G. Johnston <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: David G. Johnston @ 2026-03-18 16:55 UTC (permalink / raw)
To: Blaziak, Sebastian <[email protected]>; +Cc: PostgreSQL Documentation <[email protected]>
On Wed, Mar 18, 2026, 07:55 Blaziak, Sebastian <
[email protected]> wrote:
> Hi David
>
>
>
> The first line states that the initial data copy will _*only*_ copy
> filtered / relevant data.
>
>
>
> While warning, but also elsewhere in the documentation it is stated that
> initial table _*does not*_ respect any publish limitations.
>
>
>
> Hence the conflict.
>
>
"publish" is a setting, it is completely orthogonal to the ability to
specify a "where" clause.
A where clause is always applied, both for the transfer of the ledger table
data and the transfer of journal event data. The publish setting can only
ever apply to the transfer of journal event data by its very nature.
David J.
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-03-18 16:55 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-03-18 11:17 Conflict in documentation PG Doc comments form <[email protected]>
2026-03-18 14:14 ` David G. Johnston <[email protected]>
2026-03-18 14:55 ` Blaziak, Sebastian <[email protected]>
2026-03-18 16:55 ` David G. Johnston <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox