public inbox for [email protected]  
help / color / mirror / Atom feed
From: David G. Johnston <[email protected]>
To: Jürgen Purtz <[email protected]>
Cc: Anastasia Lubennikova <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Change JOIN tutorial to focus more on explicit joins
Date: Mon, 30 Nov 2020 13:25:58 -0700
Message-ID: <CAKFQuwauhGRnwqGamn6oHrdP-3v2SR0ELhe_a3w0BtjpkV5q_g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<160676553158.7563.8055833766353450366.pgcf@coridan.postgresql.org>
	<[email protected]>

On Mon, Nov 30, 2020 at 1:15 PM Jürgen Purtz <[email protected]> wrote:

> On 30.11.20 20:45, Anastasia Lubennikova wrote:
> > As far as I see something got committed and now the discussion is stuck
> in arguing about parenthesis.
> > FWIW, I think it is a matter of personal taste. Maybe we can compromise
> on simply leaving this part unchanged.
>
> With or without parenthesis is a little more than a personal taste, but
> it's a very tiny detail. I'm happy with either of the two variants.
>
>
Sorry, I managed to overlook the most recent patch.

I admitted my use of parentheses was incorrect and I don't see anyone else
defending them.  Please remove them.

Minor typos:

"the database compare" -> needs an "s" (compares)

"In this case, the definition how to compare their rows." -> remove,
redundant with the first sentence

"The results from the older implicit syntax, and the newer explicit JOIN/ON
syntax, are identical" -> move the commas around to what is shown here

David J.


reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Change JOIN tutorial to focus more on explicit joins
  In-Reply-To: <CAKFQuwauhGRnwqGamn6oHrdP-3v2SR0ELhe_a3w0BtjpkV5q_g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox