Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1XRRHY-0007CN-KX for pgsql-docs@arkaria.postgresql.org; Tue, 09 Sep 2014 19:40:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1XRRHY-00063r-5J for pgsql-docs@arkaria.postgresql.org; Tue, 09 Sep 2014 19:40:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1XRRHX-00063K-0a for pgsql-docs@postgresql.org; Tue, 09 Sep 2014 19:40:51 +0000 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]) by makus.postgresql.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1XRRHT-0000Jv-Fy for pgsql-docs@postgresql.org; Tue, 09 Sep 2014 19:40:49 +0000 Received: by mail-wi0-f180.google.com with SMTP id ex7so5095395wid.1 for ; Tue, 09 Sep 2014 12:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=pLkvT3Idu3EPLX4OuOBWrnYwi98g5pwuGux6ueYyi/k=; b=geKLQiBPwk6+9N9iZB83xyJETcAdrDU5eDTEP2Ohz4XoDXb+M4cIW99b6+24cxsB94 m4UOYPFC4S8SeWG57f0fHZqvOEEsACLcsp6mdYT9Rrcas99RapEE7PXxRZNwsSixTIv/ sWWsqakK2a8qbfIgSI7vzW23PxkNGyWbzOp5zpfhjOKo52lRfziSsbke7W44pU98Bs/C fAS9X9aQBD2bwHLtZB7r26jZZ+KuYKNX8YTGXu/nPH5F90N2Mo/DfvX4/YehEFqeD+8l rwKc+msM9GAYCW8TcRfa3UEPsRYGCfWhN3gMaLNk1zzBMIxfV2u4SjfHCg65Gnv1GHSk L1MA== MIME-Version: 1.0 X-Received: by 10.194.236.132 with SMTP id uu4mr6844307wjc.108.1410291645367; Tue, 09 Sep 2014 12:40:45 -0700 (PDT) Received: by 10.216.113.200 with HTTP; Tue, 9 Sep 2014 12:40:45 -0700 (PDT) In-Reply-To: <20140909191317.GF16663@momjian.us> References: <1400698826956-5804655.post@n5.nabble.com> <2916.1400704666@sss.pgh.pa.us> <20140909191317.GF16663@momjian.us> Date: Tue, 9 Sep 2014 15:40:45 -0400 Message-ID: Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration? From: David Johnston To: Bruce Momjian Cc: "pgsql-docs@postgresql.org" Content-Type: multipart/alternative; boundary=089e014941868d4bae0502a71c9f X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-docs Precedence: bulk Sender: pgsql-docs-owner@postgresql.org --089e014941868d4bae0502a71c9f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, Sep 9, 2014 at 3:13 PM, Bruce Momjian wrote: > On Thu, Jun 12, 2014 at 11:32:49AM -0400, David Johnston wrote: > > This addition still needs some work as well as the patch as a whole (se= e > my > > comments above). The attached PDF is the page that results from "make > html"; > > the original patch has been re-attached as well and -hackers copied > given the > > lack of response on -doc. > > > > I am hoping this change would be something that could be included in > 9.4; I > > believe the enhancements would be most beneficial to newcomers who are > just > > getting started with PostgreSQL and would be using 9.4 as their startin= g > point. > > [hackers CC removed] > > I have reviewed and updated this reworking of our configuration settings > documentation and feel it is ready for application to head and 9.4; > attached. > > Minor corrections: =E2=80=8BFirst block: " In the first section of this chapter, we describe how to set configuration parameters"=E2=80=8B =E2=80=8B- remove the comma =E2=80=8BSecond Block: - placement of the colon inside or outside of the emphasis tag is inconsistent (string, unit, enum are inside; boolean and =E2=80=8Bnumeric a= re outside) - units: "An numeric value..." -> maybe "An unadorned numeric value... =E2=80=8BThird block: =E2=80=8B"Hash marks (#) designate the remainder of line= s as comments." -> "...designate the remainder of the line as a comment." I read this at first as "remaining lines [in the file] ... " "To embed a single quote in a parameter value, write either two quotes (preferred) or backslash-quote." -> remove the comma "Querying this view is the sames as" -> "the same as" "In addition to setting global defaults or attaching" <- add a comma after "defaults" A few extra commas here-and-there which seem to have replaced my use of colons but that maybe should just be removed completely. If I didn't note it above it seemed OK to leave in (or I missed it entirely...) David J. --089e014941868d4bae0502a71c9f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Sep 9, 2014 a= t 3:13 PM, Bruce Momjian <bruce@momjian.= us> wrote:
=
On Thu, Jun 12, 2014 at 11:32:49AM -0400, David Johnston wrote= :
> This addition still needs some work as well as= the patch as a whole (see my
> comments above). =C2=A0The attached PDF is the page that results from = "make html";
> the original patch has been re-attached as well and -hackers copied gi= ven the
> lack of response on -doc.
>
> I am hoping this change would be something that could be included in 9= .4; I
> believe the enhancements would be most beneficial to newcomers who are= just
> getting started with PostgreSQL and would be using 9.4 as their starti= ng point.

[hackers CC removed]

I have reviewed and updated this reworking of our configuration settings documentation and feel it is ready for application to head and 9.4;
attached.


Minor corrections:

=E2=80=8BFirst block: "
In the first section of this chapter, we
=E2=80=8B- remove the comma

=E2=80=8BSecond Block:=C2=A0
<= div class=3D"gmail_default" style=3D"font-family:arial,helvetica,sans-serif= ">- placement of the colon inside or outside of the emphasis tag is inconsi= stent (string, unit, enum are inside; boolean and =E2=80=8Bnumeric are outs= ide)
- units: =C2=A0"An numeric value..." -> maybe &qu= ot;An unadorned numeric value...

=E2=80=8BThird bloc= k:
=E2=80=8B"Hash marks (<literal>#</literal>) des= ignate the remainder of lines as comments." -> "...designate t= he remainder of the line as a comment." =C2=A0I read this at first as = "remaining lines [in the file] ... "

"T= o embed a single quote in a parameter value, write either two quotes (prefe= rred) or backslash-quote." -> remove the comma
"Queryi= ng this view is the sames as" -> "the same as"
&= quot;In addition to setting global defaults or attaching" <- add a = comma after "defaults"

A few extra commas here-and-there which seem = to have replaced my use of colons but that maybe should just be removed com= pletely. =C2=A0If I didn't note it above it seemed OK to leave in (or I= missed it entirely...)

<= /div>
David J.


=
--089e014941868d4bae0502a71c9f--