public inbox for [email protected]
help / color / mirror / Atom feedFrom: vignesh C <[email protected]>
To: Amit Kapila <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Logical Replication upgrade
Date: Fri, 17 Apr 2026 11:02:16 +0530
Message-ID: <CALDaNm1VOrMXHHPxPmaaBvLN43L2=E5d=KLLUSdiMn8SOfj1VQ@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1LWNPW7bTY+0=L183rCyqUmq6MuFkgTE8QwHeT6nkDmpg@mail.gmail.com>
References: <[email protected]>
<CAKFQuwZ86BE49-gzFunuu=u1ieT+T6q900=1Cx=vuO9Aqv9kcg@mail.gmail.com>
<CAA4eK1LR_MjZuV31r-MOqno9-Kr0mA9zas2cxZtE=+X3RUYXbw@mail.gmail.com>
<CAKFQuwbHjB6EEdp6mmaUt4bCTYrYUdvEr44vVqhdT0OD4Z+3Qg@mail.gmail.com>
<CAA4eK1+dR-sEGM+oC7H_-7PrBJBcdM2o5-eS6JrkMBJ0FOA54Q@mail.gmail.com>
<CAKFQuwaWUuXJYZSMKtiXFT=kFK-sFg+pSwK0MUN-MBEEobkfBg@mail.gmail.com>
<CAA4eK1LWNPW7bTY+0=L183rCyqUmq6MuFkgTE8QwHeT6nkDmpg@mail.gmail.com>
On Fri, 17 Apr 2026 at 09:25, Amit Kapila <[email protected]> wrote:
>
> On Thu, Apr 16, 2026 at 11:16 AM David G. Johnston
> <[email protected]> wrote:
> >
> > On Wednesday, April 15, 2026, Amit Kapila <[email protected]> wrote:
> >>
> >>
> >> So, how about: "All slots on the old cluster must be usable, i.e.,
> >> their pg_replication_slots.conflicting is false."?
> >
> >
> > That works.
> >
> > Then we’d also change:
> >
> > The new cluster must not have permanent logical slots, i.e., there must be no slots where pg_replication_slots.temporary is false.
> >
> > To be:
> >
> > “The new cluster is only permitted to have temporary logical slots, i.e., ones where pg_replication_slots.temporary is true.”
> >
>
> What you wrote is correct but it is better to keep what is not allowed
> for this case. Based on that, how about the following:
> "The new cluster must not have any permanent logical slots; i.e., any
> existing logical slots must have pg_replication_slots.temporary set to
> true."
Your version seems better, the attached v2 version patch has the
changes for the same.
Regards,
Vignesh
Attachments:
[application/octet-stream] v2-0001-Improve-the-wording-of-logical-slot-prerequisites.patch (2.3K, ../CALDaNm1VOrMXHHPxPmaaBvLN43L2=E5d=KLLUSdiMn8SOfj1VQ@mail.gmail.com/2-v2-0001-Improve-the-wording-of-logical-slot-prerequisites.patch)
download | inline diff:
From d891802fd8fae9daa544c5229bf1674f131e5421 Mon Sep 17 00:00:00 2001
From: Vignesh C <[email protected]>
Date: Thu, 16 Apr 2026 12:36:34 +0530
Subject: [PATCH v2] Improve the wording of logical slot prerequisites to make
the conditions easier to understand.
Replace the previous negative phrasing such as "there are no slots
whose ... is not true" with a direct expression that all slots must
have conflicting = false.
Similarly, reword the requirement on the new cluster to state that it
must not have any permanent logical slots, clarifying that any existing
logical slots must have temporary set to true.
These changes improve readability without altering the meaning.
Author: Vignesh C <[email protected]>
Reviewed-by: Amit Kapila <[email protected]>
Reviewed-by: David G. Johnston <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/177609278737.403059.14174275013090471947%40wrigleys.postgresql.org
---
doc/src/sgml/logical-replication.sgml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 23b268273b9..598e23ad4f5 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -2785,18 +2785,17 @@ CONTEXT: processing remote data for replication origin "pg_16395" during "INSER
</listitem>
<listitem>
<para>
- All slots on the old cluster must be usable, i.e., there are no slots
- whose
+ All slots on the old cluster must be usable, i.e., their
<link linkend="view-pg-replication-slots">pg_replication_slots</link>.<structfield>conflicting</structfield>
- is not <literal>true</literal>.
+ is <literal>false</literal>.
</para>
</listitem>
<listitem>
<para>
- The new cluster must not have permanent logical slots, i.e.,
- there must be no slots where
+ The new cluster must not have any permanent logical slots; i.e., any
+ existing logical slots must have
<link linkend="view-pg-replication-slots">pg_replication_slots</link>.<structfield>temporary</structfield>
- is <literal>false</literal>.
+ set to <literal>true</literal>.
</para>
</listitem>
</itemizedlist>
--
2.43.0
view thread (10+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Logical Replication upgrade
In-Reply-To: <CALDaNm1VOrMXHHPxPmaaBvLN43L2=E5d=KLLUSdiMn8SOfj1VQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox