MIME-Version: 1.0
References: 
 <CAM527d_Qt9ZGt99vgTaidfObRiDH0R5F_uEfum9zHeZbc+LwCQ@mail.gmail.com>
 <1a7d3c03e6169e6340f9d77667433fd0cc5f5897.camel@cybertec.at>
In-Reply-To: <1a7d3c03e6169e6340f9d77667433fd0cc5f5897.camel@cybertec.at>
From: Nikolay Samokhvalov <nik@postgres.ai>
Date: Tue, 24 Mar 2026 05:36:42 -0700
Message-ID: 
 <CAM527d89GmcMV5GD2PXS-a3ay3YE-HVSwV4NT0_o2ySf_5v8Kw@mail.gmail.com>
Subject: Re: [PATCH] Doc: clarify that pg_upgrade statistics transfer works
 cross-version
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-docs@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000f971e7064dc467c3"
Archived-At: 
 <https://www.postgresql.org/message-id/CAM527d89GmcMV5GD2PXS-a3ay3YE-HVSwV4NT0_o2ySf_5v8Kw%40mail.gmail.com>
Precedence: bulk

--000000000000f971e7064dc467c3
Content-Type: text/plain; charset="UTF-8"

On Mon, Mar 23, 2026 at 23:59 Laurenz Albe <laurenz.albe@cybertec.at> wrote:
...

> I think that your patch offers too much detail,
> like from which relations the statistics are extracted.  Anybody
> who wants to know that level of detail probably has to read the
> source code anyway.
>
> How about adding a simple remark, like
>
> --- a/doc/src/sgml/ref/pgupgrade.sgml
> +++ b/doc/src/sgml/ref/pgupgrade.sgml
> @@ -837,6 +837,8 @@ psql --username=postgres --file=script.sql postgres
>       all statistics, such as those created explicitly with
>       <xref linkend="sql-createstatistics"/>, custom statistics added by
>       an extension, or statistics collected by the cumulative statistics
> system.
> +     Transferring optimizer statistics works regardless of the old
> cluster's
> +     major version.
>      </para>
>
>      <para>


That would work too -- my goal was just to resolve confusion.

Nik

>

--000000000000f971e7064dc467c3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">On Mon, Mar 23, 2026 at 23:59 Laurenz Albe &lt;<a href=3D=
"mailto:laurenz.albe@cybertec.at">laurenz.albe@cybertec.at</a>&gt; wrote:</=
div><div dir=3D"auto">...</div><div dir=3D"auto"><div class=3D"gmail_quote =
gmail_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0p=
x 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:=
1ex;border-left-color:rgb(204,204,204)" dir=3D"auto">I think that your patc=
h offers too much detail,<br>
like from which relations the statistics are extracted.=C2=A0 Anybody<br>
who wants to know that level of detail probably has to read the<br>
source code anyway.<br>
<br>
How about adding a simple remark, like<br>
<br>
--- a/doc/src/sgml/ref/pgupgrade.sgml<br>
+++ b/doc/src/sgml/ref/pgupgrade.sgml<br>
@@ -837,6 +837,8 @@ psql --username=3Dpostgres --file=3Dscript.sql postgres=
<br>
=C2=A0 =C2=A0 =C2=A0 all statistics, such as those created explicitly with<=
br>
=C2=A0 =C2=A0 =C2=A0 &lt;xref linkend=3D&quot;sql-createstatistics&quot;/&g=
t;, custom statistics added by<br>
=C2=A0 =C2=A0 =C2=A0 an extension, or statistics collected by the cumulativ=
e statistics system.<br>
+=C2=A0 =C2=A0 =C2=A0Transferring optimizer statistics works regardless of =
the old cluster&#39;s<br>
+=C2=A0 =C2=A0 =C2=A0major version.<br>
=C2=A0 =C2=A0 =C2=A0&lt;/para&gt;<br>
<br>
=C2=A0 =C2=A0 =C2=A0&lt;para&gt;</blockquote><div dir=3D"auto"><br></div><d=
iv dir=3D"auto">That would work too -- my goal was just to resolve confusio=
n.</div><div dir=3D"auto"><br></div><div dir=3D"auto">Nik</div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1=
px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,2=
04)" dir=3D"auto"></blockquote></div></div>

--000000000000f971e7064dc467c3--