Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1iVgz4-0006d0-70
	for pgsql-docs@arkaria.postgresql.org; Fri, 15 Nov 2019 19:10:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1iVgz2-0003Uh-SM
	for pgsql-docs@arkaria.postgresql.org; Fri, 15 Nov 2019 19:10:16 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <jeff.janes@gmail.com>)
	id 1iVgz2-0003Ua-IW
	for pgsql-docs@lists.postgresql.org; Fri, 15 Nov 2019 19:10:16 +0000
Received: from mail-vk1-xa44.google.com ([2607:f8b0:4864:20::a44])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <jeff.janes@gmail.com>)
	id 1iVgyz-0004q4-Uw
	for pgsql-docs@postgresql.org; Fri, 15 Nov 2019 19:10:15 +0000
Received: by mail-vk1-xa44.google.com with SMTP id r4so2599249vkf.9
        for <pgsql-docs@postgresql.org>; Fri, 15 Nov 2019 11:10:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:from:date:message-id:subject:to;
        bh=xED1So2kfhfauLfdX3SVuaV5qxIjbnlK+FjIBHEqSTI=;
        b=qFJFYvJtjb5drQG9OnRy+pI/B21jufITGDDmd5U87g7Z+MKzAt1AOeU/stLenv9Cc5
         6eYq53w6mV/kznjCoQV7kSar1BJoSQH64HimZkGDgpTanWbyRPy0E5XVNxAdspZ5Al2Z
         54X1+Xq7kz041sKWEY/69ncavTk//NLpsw86Oeh76lE40lGgfZGzZsB0LvyXOo5ZAB+r
         YA9vCb6PJ/GOdMLZuw8D8jsXlygfAnEMjS0qd+KcWzjDycSAHHNGK21pUME1fjCODrqq
         ShgTwGHrmJX/NqbGWKKxCzMsKoABra652YZ1kRNCwPNxrydKTkcFx4FnBtDiupq2CkW1
         +B7g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=xED1So2kfhfauLfdX3SVuaV5qxIjbnlK+FjIBHEqSTI=;
        b=SXYWEqAEL0DbND1fytI7RunQ4mQBzQbAYftRRq1YomSZwOfF54qoE4c6AvuIb1jsmN
         CDkkAkb9m8mF1XJdF9p2ZbUfrWDGq94vCqqygjz3upRebb319Sp+KCmp9R2rPaaSbbvL
         0vlX/K6S9Y3Z7y0jY4oY9q+tcF0HREd+R5CycyXtek719QsR3ict/Ix/GlgSt6LH0hqk
         9iLGnJDi9iOVC+LW+aS2gHuh8CT0lJrWpaXOYPczx87JPxy0SY3yxyPpetf3ELbysHWg
         XjrnF1vTgl1MCe6YdrLjHlwTLMbZkt6QkU1GRvhkNAWzdAmb+noO+6m4LnxeMFCBL+/g
         saZw==
X-Gm-Message-State: APjAAAX429ptmRBEuJn4hMbZdyBr1Ws8+tj6Z2EtsJfuBOHYupJty+EV
	Yya7vXYITAGXYvPauzjOt4ECZXopsSGXB+YwUP+DRU4=
X-Google-Smtp-Source: 
 APXvYqw4DpMliubOHBtylxlKDpkHJ5JxjPYKQWht2NI2xyE8GXRGi08bpa9H6S3cDh2sur4gSMFJ3KVFy4TbeybLuuM=
X-Received: by 2002:a1f:a592:: with SMTP id o140mr5994403vke.30.1573845011404;
 Fri, 15 Nov 2019 11:10:11 -0800 (PST)
MIME-Version: 1.0
From: Jeff Janes <jeff.janes@gmail.com>
Date: Fri, 15 Nov 2019 14:09:59 -0500
Message-ID: 
 <CAMkU=1wQ-t=7gVoWRv6+yik+yZ20dEEwGjCXumNpHEFKLtxfVg@mail.gmail.com>
Subject: Add <caution> for ALTER TEXT SEARCH CONFIGURATION
To: pgsql-docs@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000d61bee05976758b8"
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Precedence: bulk

--000000000000d61bee05976758b8
Content-Type: text/plain; charset="UTF-8"

If you alter one of the built-in text search configurations, the
modifications to it will not get dumped by pg_dump, and thus won't get
propagated by pg_upgrade leading to silent behavior changes in the new
cluster (as well in any other type of restoration from pg_dump output)

I would say it is bad practise to alter one of those anyway, rather than
copy and alter the copy.  But I wasn't aware until now of just how bad of
an idea it was.  I think that this needs to be warned about in the docs
for ALTER TEXT SEARCH CONFIGURATION.  If I were monkeying around in
$SHAREDLIB/tsearch_data, I'd expect traps like this, but not when executing
things from SQL after reading the docs on the command.

Cheers,

Jeff

--000000000000d61bee05976758b8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>If you alter one of the built-in text search configur=
ations, the modifications to it will not get dumped by pg_dump, and thus wo=
n&#39;t get propagated by pg_upgrade leading to silent behavior changes in =
the new cluster (as well in any other type of restoration from pg_dump outp=
ut)</div><div><br></div><div>I would say it is bad practise to alter one of=
 those anyway, rather than copy and alter the copy.=C2=A0 But I wasn&#39;t =
aware until now of just how bad of an idea it was.=C2=A0 I think that this =
needs to be warned about in the docs for=C2=A0ALTER TEXT SEARCH CONFIGURATI=
ON.=C2=A0 If I were monkeying around in $SHAREDLIB/tsearch_data, I&#39;d ex=
pect traps like this, but not when executing things from SQL after reading =
the docs on the command.</div><div><br></div><div>Cheers,</div><div><br></d=
iv><div>Jeff</div></div>

--000000000000d61bee05976758b8--