MIME-Version: 1.0
References: 
 <OS0PR01MB6113030CD04D4CE25F73B985FB0A9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
In-Reply-To: 
 <OS0PR01MB6113030CD04D4CE25F73B985FB0A9@OS0PR01MB6113.jpnprd01.prod.outlook.com>
From: Craig Ringer <craig.ringer@2ndquadrant.com>
Date: Wed, 30 Jun 2021 10:15:25 +0800
Message-ID: 
 <CAMsr+YHfNzQFxBtHnS_L=MBsd_H-N4+Ff4WJZ7gwZenPbqOwJA@mail.gmail.com>
Subject: Re: doc: Document how to run regression tests with custom server
 settings
To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
Cc: "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>,
	"peter@eisentraut.org" <peter@eisentraut.org>
Content-Type: multipart/alternative; boundary="00000000000044bebf05c5f24c34"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMsr%2BYHfNzQFxBtHnS_L%3DMBsd_H-N4%2BFf4WJZ7gwZenPbqOwJA%40mail.gmail.com>
Precedence: bulk

--00000000000044bebf05c5f24c34
Content-Type: text/plain; charset="UTF-8"

On Mon, 21 Jun 2021 at 15:43, tanghy.fnst@fujitsu.com <
tanghy.fnst@fujitsu.com> wrote:

> Hi
>
> I was doing regression testing according to the PG-doc at [1].
> The modification at 854434c5 seems not correct, could you please take a
> check at it?
>
> >make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB"
>
> The above command reported an error like this:
> failed: FATAL:  parameter "log_checkpoints" cannot be changed now
>
> IMHO, as a sighup GUC, log_checkpoints can't be set in PGOPTIONS, is that
> correct?
>
> >make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf"
>
> pg_regress: could not open "test_postgresql.conf" to read extra config: No
> such file or directory
>
> I fixed above problem using command like this:
> make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf"
>
> Maybe we can change doc description to tell user he/she should specify the
> location of " test_postgresql.conf", thoughts?
>
> [1] https://www.postgresql.org/docs/devel/regress-run.html


Yes, that'd make a lot of sense.

PGOPTIONS is more suited for client settings.

Willing to cook up a quick patch?

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--00000000000044bebf05c5f24c34
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, 21 Jun 2021 at 15:43, <a href=3D"=
mailto:tanghy.fnst@fujitsu.com">tanghy.fnst@fujitsu.com</a> &lt;<a href=3D"=
mailto:tanghy.fnst@fujitsu.com">tanghy.fnst@fujitsu.com</a>&gt; wrote:<br><=
/div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex">Hi<br>
<br>
I was doing regression testing according to the PG-doc at [1]. <br>
The modification at 854434c5 seems not correct, could you please take a che=
ck at it? <br>
<br>
&gt;make check PGOPTIONS=3D&quot;-c log_checkpoints=3Don -c work_mem=3D50MB=
&quot;<br>
<br>
The above command reported an error like this:<br>
failed: FATAL:=C2=A0 parameter &quot;log_checkpoints&quot; cannot be change=
d now<br>
<br>
IMHO, as a sighup GUC, log_checkpoints can&#39;t be set in PGOPTIONS, is th=
at correct?<br>
<br>
&gt;make check EXTRA_REGRESS_OPTS=3D&quot;--temp-config=3Dtest_postgresql.c=
onf&quot;<br>
<br>
pg_regress: could not open &quot;test_postgresql.conf&quot; to read extra c=
onfig: No such file or directory<br>
<br>
I fixed above problem using command like this:<br>
make check EXTRA_REGRESS_OPTS=3D&quot;--temp-config=3D$(pwd)/test_postgresq=
l.conf&quot;<br>
<br>
Maybe we can change doc description to tell user he/she should specify the =
location of &quot; test_postgresql.conf&quot;, thoughts?<br>
<br>
[1] <a href=3D"https://www.postgresql.org/docs/devel/regress-run.html" rel=
=3D"noreferrer" target=3D"_blank">https://www.postgresql.org/docs/devel/reg=
ress-run.html</a></blockquote><div><br></div><div>Yes, that&#39;d make a lo=
t of sense.</div><div><br></div><div>PGOPTIONS is more suited for client se=
ttings.<br></div></div><div class=3D"gmail_quote"><br></div><div class=3D"g=
mail_quote">Willing to cook up a quick patch?<br></div><br>-- <br><div dir=
=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><=
div>=C2=A0Craig Ringer =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 <a href=3D"http://www.2ndQuadrant.com/" target=3D"_blank">http:/=
/www.2ndQuadrant.com/</a><br></div><div>=C2=A0PostgreSQL Development, 24x7 =
Support, Remote DBA, Training &amp; Services</div></div></div></div></div><=
/div>

--00000000000044bebf05c5f24c34--