Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gELMP-0007vo-15 for pgsql-docs@arkaria.postgresql.org; Sun, 21 Oct 2018 21:34:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gELMN-000737-0i for pgsql-docs@arkaria.postgresql.org; Sun, 21 Oct 2018 21:34:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gELMM-00072z-K3 for pgsql-docs@lists.postgresql.org; Sun, 21 Oct 2018 21:34:06 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gELME-0005KB-Jt for pgsql-docs@lists.postgresql.org; Sun, 21 Oct 2018 21:34:05 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 9309C21C1CC6 for ; Mon, 22 Oct 2018 00:33:55 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail-it1-f180.google.com (mail-it1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (not verified)) by mail.postgrespro.ru (Postfix) with ESMTPSA id E856621C1CC3 for ; Mon, 22 Oct 2018 00:33:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1540157635; bh=3IgkXzwLg1OvmHF+PP7/3zkWg2T4Ve1LBRxL8ddBLQ4=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=kCNZJz1e77PD8567zMdl80yMGKoTWptbJTEiKuUtB3z8oeMgAJ4zp7PX0G0rx7nf5 lVHRLoLxoPO5NgoHk3UBE85s3O3kLwIQ0T7TISljVuG2ytW/f1JgYAiRSUifjDgrtt fHf6MikpKiiknoxVtcmqYnpOhcQYNfdqBcHLMHdY= Received: by mail-it1-f180.google.com with SMTP id i191-v6so10187877iti.5 for ; Sun, 21 Oct 2018 14:33:54 -0700 (PDT) X-Gm-Message-State: ABuFfohoMCok8+GLAZ8ZjMOqfQ4XC6vyM8TUYm3AMTf2f+c/zsJuum/U llVB2M4c8jWhokiGkdACEVadGyKJWw7w//gJnus= X-Google-Smtp-Source: ACcGV62EttzZrQbz8t3z/T6K0LI4yQwsCaMCfPx6RrkUlVtnx6yrEg0/fTjVLmaQY5DtYXuCIRO8ryI0iKsO1IgXrjY= X-Received: by 2002:a24:9886:: with SMTP id n128-v6mr8474386itd.7.1540157633026; Sun, 21 Oct 2018 14:33:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Korotkov Date: Mon, 22 Oct 2018 00:33:42 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bloom documentation patch To: Oleg Bartunov Cc: Thomas Munro , pgsql-docs@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Oct 17, 2018 at 11:45 PM Oleg Bartunov wrote: > On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro > wrote: > > > > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov wrote: > > > Please, consider attached patch, which improves contrib/bloom documentation. > > > > Hello Oleg, I have no comment on the technical details but here is > > some proof-reading of the English: > > > > + Length of each signature (index entry) in bits, it is rounded > > up to the nearest > > + multiple of 16. The default is 80 bits and maximum is > > > > s/, it is/. It is/ > > s/and maximum/and the maximum/ Thank you for these corrections. They are pushed. > > + Bloom AM doesn't supports unique indexes. > > > > s/supports/support/ > > > > + Bloom AM doesn't supports NULL values. > > > > s/supports/support/ These two were already fixed in the version I've pushed before. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company