Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef4yJ-0005Xd-5C for pgsql-docs@arkaria.postgresql.org; Fri, 26 Jan 2018 14:27:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ef4yI-0003Ex-8L for pgsql-docs@arkaria.postgresql.org; Fri, 26 Jan 2018 14:27:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ef4yI-0003En-0Z for pgsql-docs@lists.postgresql.org; Fri, 26 Jan 2018 14:27:14 +0000 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ef4yA-0007Rv-0M for pgsql-docs@postgresql.org; Fri, 26 Jan 2018 14:27:13 +0000 Received: by mail-lf0-x244.google.com with SMTP id q17so899349lfa.9 for ; Fri, 26 Jan 2018 06:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:message-id:date:to:mime-version; bh=V8G1STZjM6kVGm0s8RlxWF4aY4r7mGvYogGjml2igWk=; b=eXE/7a558F7SIZSuQpkFA4UudkLDm+m4HLqjdHJT0zreFIwBBLFn1+/vyA1iWrRYjw ZmiI8rpzHWgcTI4IU6pk5GZc43uASe0xxVjTDd/lX9cjC1TMxgY6vGLcQa5l9609sUaS j1a33G/8bRqUKPKpl1Ez48rnOlvR87NKXIfrMVA75guZTPWxmQeNzz1UH7fZEF1jZhxh qwE9BREwxU0BNG/AKYF1OKjQHm6+f+NzHQGUYf8H4/6QirMwqzkxBgRU+cwfEtDkI5Lr MJZkQuLE/yOkXyuBf9+h7bT1oYRGINtcU8KmS18cN3hOR9bMeIQJrGTXoyxKPQ7TPwGf x9yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:message-id:date:to :mime-version; bh=V8G1STZjM6kVGm0s8RlxWF4aY4r7mGvYogGjml2igWk=; b=e7vuDmMtWTPKgp6hKgrwgCcI26BhGeiupq2i+87i7dlNGnCGMM4iWUzi4Zc/XKc8si /FRS7s0uAJK3YkeJhoWQwq5u5Wiru9ke+xGRXOuFqstxUeYGCUI42EdAv6uFA4c6EcVt hzDk0kjhEp/XZlmn58HWVBXFvEjlgPiLk/POVEJwTQfq8vTupygWEW9TUkppsqbNGI1D Y4PKvS6CNiRfbNtokvcZSYDn/bU+Ho8S5DNENm3BavSSd4dI8ukVchuR1VQ/VhJ54A5N sdPxli1LijWLIE3tOJMTMqpXU7VsgGyTuBSC/EKNH6TKupw9vJjd8CesXH0l8RRvUTvQ BLNg== X-Gm-Message-State: AKwxytdcyrnTJY835O+ch7uq6KG05j/baFTjoH3JOayPuS/xC/t+gYyy LgO/Wq7nPsqz4SQibXLaQK7ggUfsRqo= X-Google-Smtp-Source: AH8x224hzXyP88zZj8vR7ntFcjd6gIauap19zlxIWe87Xnul1n8KMHkMF1vOZ0llv7Pi5Umsi9MWXQ== X-Received: by 10.25.216.21 with SMTP id p21mr8686697lfg.11.1516976824805; Fri, 26 Jan 2018 06:27:04 -0800 (PST) Received: from [192.168.1.69] (c-c67ce055.027-294-73746f71.cust.bredbandsbolaget.se. [85.224.124.198]) by smtp.gmail.com with ESMTPSA id r132sm1471707lfe.9.2018.01.26.06.27.03 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Jan 2018 06:27:03 -0800 (PST) Sender: Daniel Gustafson From: Daniel Gustafsson Content-Type: multipart/mixed; boundary="Apple-Mail=_BFD30F40-9B84-45A4-AAFB-14D1B9490980" Subject: Trailing semicolons on partitioning example commands Message-Id: Date: Fri, 26 Jan 2018 15:27:02 +0100 To: pgsql-docs Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Apple-Mail=_BFD30F40-9B84-45A4-AAFB-14D1B9490980 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Is there a reason for not ending all partitioning commands with semicolons in the declarative partitioning example? https://www.postgresql.org/docs/devel/static/ddl-partitioning.html The two last commands with TABLESPACE clauses are ended with semicolons, the first three arent. Attached patch adds semicolons such that all are properly ended. cheers ./daniel --Apple-Mail=_BFD30F40-9B84-45A4-AAFB-14D1B9490980 Content-Disposition: attachment; filename=partcmd_semicolon.patch Content-Type: application/octet-stream; name="partcmd_semicolon.patch" Content-Transfer-Encoding: quoted-printable =46rom=2092e1b2fe5a470eb008e3b22a5706ffde1b915009=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Daniel=20Gustafsson=20=0A= Date:=20Fri,=2026=20Jan=202018=2015:13:37=20+0100=0ASubject:=20[PATCH]=20= doc:=20End=20partition=20commands=20with=20trailing=20semicolon=0A=0A---=0A= =20doc/src/sgml/ddl.sgml=20|=206=20+++---=0A=201=20file=20changed,=203=20= insertions(+),=203=20deletions(-)=0A=0Adiff=20--git=20= a/doc/src/sgml/ddl.sgml=20b/doc/src/sgml/ddl.sgml=0Aindex=20= 3244399782..1e1f3428a6=20100644=0A---=20a/doc/src/sgml/ddl.sgml=0A+++=20= b/doc/src/sgml/ddl.sgml=0A@@=20-3097,14=20+3097,14=20@@=20CREATE=20TABLE=20= measurement=20(=0A=20=0A=20=0A=20CREATE=20TABLE=20= measurement_y2006m02=20PARTITION=20OF=20measurement=0A-=20=20=20=20FOR=20= VALUES=20FROM=20('2006-02-01')=20TO=20('2006-03-01')=0A+=20=20=20=20FOR=20= VALUES=20FROM=20('2006-02-01')=20TO=20('2006-03-01');=0A=20=0A=20CREATE=20= TABLE=20measurement_y2006m03=20PARTITION=20OF=20measurement=0A-=20=20=20=20= FOR=20VALUES=20FROM=20('2006-03-01')=20TO=20('2006-04-01')=0A+=20=20=20=20= FOR=20VALUES=20FROM=20('2006-03-01')=20TO=20('2006-04-01');=0A=20=0A=20= ...=0A=20CREATE=20TABLE=20measurement_y2007m11=20PARTITION=20OF=20= measurement=0A-=20=20=20=20FOR=20VALUES=20FROM=20('2007-11-01')=20TO=20= ('2007-12-01')=0A+=20=20=20=20FOR=20VALUES=20FROM=20('2007-11-01')=20TO=20= ('2007-12-01');=0A=20=0A=20CREATE=20TABLE=20measurement_y2007m12=20= PARTITION=20OF=20measurement=0A=20=20=20=20=20FOR=20VALUES=20FROM=20= ('2007-12-01')=20TO=20('2008-01-01')=0A--=20=0A2.14.1.145.gb3622a4ee=0A=0A= --Apple-Mail=_BFD30F40-9B84-45A4-AAFB-14D1B9490980--