Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3iML-0000JJ-BT for pgsql-docs@arkaria.postgresql.org; Wed, 04 Apr 2018 13:21:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3iMK-0002qR-89 for pgsql-docs@arkaria.postgresql.org; Wed, 04 Apr 2018 13:21:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3iMK-0002qG-24 for pgsql-docs@lists.postgresql.org; Wed, 04 Apr 2018 13:21:52 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3iMC-0006Fu-HU for pgsql-docs@postgresql.org; Wed, 04 Apr 2018 13:21:51 +0000 Received: from pool-98-116-99-252.nycmny.fios.verizon.net ([98.116.99.252] helo=ph33r-retina.home) by meldrar.postgresql.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3iM7-0006EA-Fi; Wed, 04 Apr 2018 13:21:42 +0000 From: "Jonathan S. Katz" Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_1070809B-3A47-4978-98BD-1F26B9065329" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Blanks in the first line before the first word in the code boxes Date: Wed, 4 Apr 2018 09:21:32 -0400 In-Reply-To: <3f249760-fdf7-edb5-d927-6d5a4a1754d0@2ndquadrant.com> Cc: Magnus Hagander , Tom Lane , Daniel Westermann , pgsql-docs To: Peter Eisentraut References: <1237101144.12611.1521809780021.JavaMail.zimbra@dbi-services.com> <5B6B7585-9892-4846-904F-BB5B4A011A7D@postgresql.org> <07C79745-DDD1-4544-B95F-D878A477E898@postgresql.org> <13425.1522330858@sss.pgh.pa.us> <60a39b28-485e-1621-79af-fa01cf43b3c6@2ndquadrant.com> <3f249760-fdf7-edb5-d927-6d5a4a1754d0@2ndquadrant.com> X-Mailer: Apple Mail (2.3273) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Apple-Mail=_1070809B-3A47-4978-98BD-1F26B9065329 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 3, 2018, at 10:55 AM, Peter Eisentraut = wrote: >=20 > On 4/3/18 09:12, Magnus Hagander wrote: >> I've pushed the fix and reloaded the 10 docs. I have not reloaded >> earlier branches yet, but I'd be interested in some people reviewing = a >> bunch of pages in the 10 docs mainly to see if (1) it fixes all the >> cases, and (2) it actually breaks some *other* cases.=20 >=20 > It looks correct now. +1 Did a spot check on known broken pages and chose some others at random. Viewed the 9.6, 10, and devel versions. 10 and devel both looked correct, and the 9.6 was broken where expected. The only thing I saw (and this may be something to look at the SGML source) was some blocks that looked overly indented, but it was = consistent across all versions. On https://www.postgresql.org/docs/current/static/queries-with.html = If you search for "WITH RECURSIVE search_graph(id, link, data, depth)=E2=80= =9D the expression in the CTE is much more indented than similar CTEs above it. IMV I would not let this stop us from reloading the earlier versions as = that indentation is consistent across all versions (including 9.6, where it = has the initial indentation as well). Jonathan --Apple-Mail=_1070809B-3A47-4978-98BD-1F26B9065329 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On Apr 3, 2018, at 10:55 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:

On = 4/3/18 09:12, Magnus Hagander wrote:
I've pushed the fix and reloaded the 10 docs. I = have not reloaded
earlier branches yet, but I'd be = interested in some people reviewing a
bunch of pages in = the 10 docs mainly to see if (1) it fixes all the
cases, = and (2) it actually breaks some *other* cases. 

It looks correct = now.

+1

Did a spot check on known broken pages and chose = some others at
random. Viewed the 9.6, 10, and devel versions. =  10 and devel both
looked correct, and the 9.6 was broken = where expected.

The only thing I saw = (and this may be something to look at the SGML
source) was = some blocks that looked overly indented, but it was = consistent
across all versions.  On


If you search for "WITH = RECURSIVE search_graph(id, link, data, depth)=E2=80=9D
the = expression in the CTE is much more indented than similar CTEs = above
it.

IMV I would not = let this stop us from reloading the earlier versions as = that
indentation is consistent across all versions (including = 9.6, where it has the
initial indentation as = well).

Jonathan


= --Apple-Mail=_1070809B-3A47-4978-98BD-1F26B9065329--