Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 19 Feb 2026 12:09:57 -0300
Message-Id: <DGJ18BHYPI3K.1025EY15AKHB6@gmail.com>
Subject: Re: Clarify INCLUDING COMMENTS behavior in CREATE TABLE and CREATE
 FOREIGN TABLE docs
From: "Matheus Alcantara" <matheusssilv97@gmail.com>
To: "Fujii Masao" <masao.fujii@gmail.com>, <pgsql-docs@lists.postgresql.org>
References: 
 <CAHGQGwHSOSGcaYDvHF8EYCUCfGPjbRwGFsJ23cx5KbJ1X6JouQ@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwHSOSGcaYDvHF8EYCUCfGPjbRwGFsJ23cx5KbJ1X6JouQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/DGJ18BHYPI3K.1025EY15AKHB6%40gmail.com>
Precedence: bulk

On Tue Feb 17, 2026 at 11:36 AM -03, Fujii Masao wrote:
> Hi,
>
>> Comments for the copied columns, constraints, and indexes will be copied=
.
>
> The above current description of INCLUDING COMMENTS in the CREATE TABLE d=
ocs
> appears inaccurate and incomplete. It says that comments on constraints a=
re
> copied, but in practice only comments on CHECK and NOT NULL constraints
> are copied; comments on other constraints (such as primary keys) are not.
> In addition, comments on extended statistics are copied, but this is not
> documented.
>
> The CREATE FOREIGN TABLE docs has a similar omission: comments on extende=
d
> statistics are also copied, but this is not mentioned.
>
> Therefore I'd like to propose the attached patch to clarify the actual be=
havior
> of INCLUDING COMMENTS. Thoughts?
>

Hi, thanks for the patch.

The changes make sense to me, it sounds more clear. I've performed some
tests and the documentation seems correct about what comments are
actually copied.

--
Matheus Alcantara
EDB: https://www.enterprisedb.com