From: "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com>
To: Bruce Momjian <bruce@momjian.us>
CC: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers
	<pgsql-hackers@lists.postgresql.org>
Subject: Re: Wrong example in the bloom documentation
Thread-Topic: Wrong example in the bloom documentation
Thread-Index: 
 AQHWlMRYK9iztnw7OkKvSv5AhnzKKKmNT8sqgAClTACAAB38kYAAGf8AgAAC4wCAAKOvjoAKnrcfgAJ8Wjk=
Date: Sat, 17 Oct 2020 13:50:26 +0000
Message-ID: 
 <GVAP278MB01022477E6F7AE58E207CF25D2000@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
References: 
 <ZR0P278MB0122119FAE78721A694C30C8D2340@ZR0P278MB0122.CHEP278.PROD.OUTLOOK.COM>
 <GVAP278MB01028F3C84C0A724412854EDD20B0@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
 <20201008162310.GA13054@momjian.us>
 <GVAP278MB010226D15C90933B3C2D198BD20B0@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
 <2622731.1602186212@sss.pgh.pa.us> <20201008195352.GA5062@momjian.us>
 <GVAP278MB01026C00EA4E25E35062483FD2080@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM>
 <20201009150832.GB1459@momjian.us>,<20201015235019.GH3797@momjian.us>
In-Reply-To: <20201015235019.GH3797@momjian.us>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 24ec2003-0cc0-4314-dbaf-08d872a39a30
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2020 13:50:26.4227
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b9c70613-b1ea-47b7-9fdd-e6f3a67ce75c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 
 dEA+KIOd/1ojx1kl90usg3g2K5Zr4hK1AyuCFt4fTapnNkVHK16sD4vix2CfarUynedWLK+j1UNuStgsuIVfusLl+Xxt3Cnr1XKz9vXzD0n3aLlkiQYUXHzqPLFlhDOz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVAP278MB0118
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On Fri, Oct=A0 9, 2020 at 11:08:32AM -0400, Bruce Momjian wrote:=0A=
> On Fri, Oct=A0 9, 2020 at 05:44:57AM +0000, Daniel Westermann (DWE) wrote=
:=0A=
> > Hi Bruce, Tom,=0A=
> > =0A=
> > On Thu, Oct=A0 8, 2020 at 03:43:32PM -0400, Tom Lane wrote:=0A=
> > >> "Daniel Westermann (DWE)" <daniel.westermann@dbi-services.com> write=
s:=0A=
> > >> >> I was hoping someone more experienced with this would comment, bu=
t=0A=
> > >> >> seeing none, I will apply it in a day or two to all supported ver=
sions?=0A=
> > >> >> Have you tested this output back to 9.5?=0A=
> > >> =0A=
> > >> > I hoped that as well. No, I tested down to 9.6 because the change =
happened in 10.=0A=
> > >> =0A=
> > >> The patch assumes that parallel query is enabled, which is not true =
by=0A=
> > >> default before v10, so it should certainly not be applied before v10=
=0A=
> > >> (at least not without significant revisions).=0A=
> >> =0A=
> >> Yes, the behavior change was in 10. Before 10 the example is fine, I w=
ould not apply that to any prior version, otherwise the whole example needs=
 to be rewritten.=0A=
>> =0A=
>> Agreed.=0A=
=0A=
>This is not applying to PG 12 or earlier because the patch mentions JIT,=
=0A=
>which was only mentioned in the PG bloom docs in PG 13+.=0A=
=0A=
Does that mean we need separate patches for each release starting with 10? =
=0A=
As I am not frequently writing patches, I would need some help here.=0A=
=0A=
Regards=0A=
Daniel=