Received: from localhost (maia-1.hub.org [200.46.204.191]) by postgresql.org (Postfix) with ESMTP id 01C6C9FB1DD for ; Sat, 25 Nov 2006 05:35:02 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.191]) (amavisd-new, port 10024) with ESMTP id 46194-04 for ; Sat, 25 Nov 2006 05:34:53 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 Received: from westnet.com (westnet.com [206.24.6.2]) by postgresql.org (Postfix) with ESMTP id CDC6E9FB1D5 for ; Sat, 25 Nov 2006 05:34:53 -0400 (AST) Received: from westnet.com (localhost [127.0.0.1]) by westnet.com (8.13.8/8.13.8) with ESMTP id kAP9YrNs002656 for ; Sat, 25 Nov 2006 04:34:53 -0500 (EST) Received: from localhost (gsmith@localhost) by westnet.com (8.13.8/8.13.2/Submit) with ESMTP id kAP9YrsW002653 for ; Sat, 25 Nov 2006 04:34:53 -0500 (EST) X-Authentication-Warning: westnet.com: gsmith owned process doing -bs Date: Sat, 25 Nov 2006 04:34:52 -0500 (EST) From: Greg Smith X-X-Sender: gsmith@westnet.com To: pgsql-hackers@postgresql.org Subject: Re: [PATCHES] [PERFORM] Direct I/O issues In-Reply-To: <200611250123.kAP1NZL03480@momjian.us> Message-ID: References: <200611250123.kAP1NZL03480@momjian.us> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200611/733 X-Sequence-Number: 94195 On Fri, 24 Nov 2006, Bruce Momjian wrote: > OK, I modified test_fsync.c by copying the defines from xlog.c, and > fixed the O_DIRECT alignment and check write()/fsync(). I just tested your new test_fsync as included in the 8.2rc1, and it's working perfectly for me now on Linux. All the O_SYNC writes using O_DIRECT are reporting realistic timings. I'm happy that this code is working as it should and appreciate the quick response. I still think the wal_sync_method documentation deserves an update noting that O_DIRECT is used when available with the sync write methods. -- * Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD