X-Original-To: pgsql-patches-postgresql.org@postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id 8AF799FA6BB for ; Tue, 1 Aug 2006 22:29:18 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 69989-04 for ; Tue, 1 Aug 2006 22:29:04 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from linuxworld.com.au (unknown [203.34.46.50]) by postgresql.org (Postfix) with ESMTP id 45ACA9FA5FC for ; Tue, 1 Aug 2006 22:29:02 -0300 (ADT) Received: from linuxworld.com.au (IDENT:swm@localhost.localdomain [127.0.0.1]) by linuxworld.com.au (8.13.2/8.13.2) with ESMTP id k721Sltv018314; Wed, 2 Aug 2006 11:28:47 +1000 Received: from localhost (swm@localhost) by linuxworld.com.au (8.13.2/8.13.2/Submit) with ESMTP id k721SlCT018311; Wed, 2 Aug 2006 11:28:47 +1000 Date: Wed, 2 Aug 2006 11:28:47 +1000 (EST) From: Gavin Sherry To: Joe Conway cc: Tom Lane , pgsql-patches@postgresql.org Subject: Re: Values list-of-targetlists patch for comments (was Re: In-Reply-To: <44CFFD2D.8040906@joeconway.com> Message-ID: References: <44B69778.5050104@dunslane.net> <44B7ADFC.90205@dunslane.net> <44BC0432.3040509@joeconway.com> <44BC661F.80609@joeconway.com> <44BCD06C.3060409@calorieking.com> <44BCF1D4.3010807@dunslane.net> <5842.1153246741@sss.pgh.pa.us> <44BD8854.9060506@calorieking.com> <15212.1153279954@sss.pgh.pa.us> <44BDB2F5.7080003@joeconway.com> <44BEA710.6060700@joeconway.com> <23198.1153367887@sss.pgh.pa.us> <44BF0382.2010501@joeconway.com> <23454.1153370214@sss.pgh.pa.us> <44BF122F.1080200@joeconway.com> <23927.1153373971@sss.pgh.pa.us> <44C00E1E.1000405@joeconway.com> <14047.1153442773@sss.pgh.pa.us> <44C4451A.4010906@joeconway.com> <11495.1153757531@sss.pgh.pa.us> <44C4F625.2050304@joeconway.com> <12029.1153760969@sss.pgh.pa.us> <44CC0A66.6070903@joeconway.com> <16429.1154463351@sss.pgh.pa.us> <44CFBC78.2020508@joeconway.com> <27359.1154474195@sss.pgh.pa.us> <44CFFD2D.8040906@joeconway.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.042 tagged_above=0 required=5 tests=AWL X-Spam-Level: X-Archive-Number: 200608/41 X-Sequence-Number: 20557 On Tue, 1 Aug 2006, Joe Conway wrote: > Gavin Sherry wrote: > > Is this intentional: > > > > template1=# values(1), (2); > > column1 > > --------- > > 1 > > 2 > > (2 rows) > > > > This is legal because of: > > > > simple_select: > > /* ... */ > > | values_clause { $$ = $2; } > > hmm, not sure about that... > > > > > Also, I am working out some docs and regression tests. > > > > Oh, cool. I was going to start working on that myself tonight, but if > you're already working on it, don't let me stand in the way ;-) > > Actually, if you want me to finish up whatever you have started, I'm > happy to do that too. I've got to go out but I'll send a complete patch when I get back. Gavin