public inbox for [email protected]
help / color / mirror / Atom feedFrom: [email protected]
To: [email protected]
Subject: change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor
Date: Wed, 16 Jun 2021 05:22:41 +0000
Message-ID: <TYAPR01MB28965989AF84B57FC351B97BC40F9@TYAPR01MB2896.jpnprd01.prod.outlook.com> (raw)
Hi
As shown below, the argument types of autovacuum_vacuum_insert_scale_factor and toast.autovacuum_vacuum_insert_scale_factor are different from the others.
---
autovacuum_vacuum_scale_factor, toast.autovacuum_vacuum_scale_factor (floating point)
autovacuum_vacuum_insert_scale_factor, toast.autovacuum_vacuum_insert_scale_factor (float4)
autovacuum_analyze_scale_factor (floating point)
autovacuum_vacuum_cost_delay, toast.autovacuum_vacuum_cost_delay (floating point)
https://www.postgresql.org/docs/devel/sql-createtable.html
---
In addition, there is this statement.
---
autovacuum_vacuum_insert_scale_factor (floating point)
https://www.postgresql.org/docs/devel/runtime-config-autovacuum.html#GUC-AUTOVACUUM-VACUUM-INSERT-SC...
---
So, I thought it was better to be consistent with "floating point", and I created the patch.
A similar argument can be found here.
https://www.postgresql.org/message-id/[email protected]...
Best Regards,
Shinya Kato
Attachments:
[application/octet-stream] change_float4_to_floating_point.patch (913B, 2-change_float4_to_floating_point.patch)
download | inline diff:
diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
index c6d0a35e50..65d3a33ac9 100644
--- a/doc/src/sgml/ref/create_table.sgml
+++ b/doc/src/sgml/ref/create_table.sgml
@@ -1558,7 +1558,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
</varlistentry>
<varlistentry id="reloption-autovacuum-vacuum-insert-scale-factor" xreflabel="autovacuum_vacuum_insert_scale_factor">
- <term><literal>autovacuum_vacuum_insert_scale_factor</literal>, <literal>toast.autovacuum_vacuum_insert_scale_factor</literal> (<type>float4</type>)
+ <term><literal>autovacuum_vacuum_insert_scale_factor</literal>, <literal>toast.autovacuum_vacuum_insert_scale_factor</literal> (<type>floating point</type>)
<indexterm>
<primary><varname>autovacuum_vacuum_insert_scale_factor</varname> </primary>
<secondary>storage parameter</secondary>
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: change float4 to floating point about type of autovacuum_vacuum_insert_scale_factor
In-Reply-To: <TYAPR01MB28965989AF84B57FC351B97BC40F9@TYAPR01MB2896.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox