Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 22 Feb 2023 10:57:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jelte Fennema <me@jeltef.nl>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Add missing meson arguments in docs
Message-ID: <Y/V2m04KR6A0K29U@paquier.xyz>
References: 
 <CAGECzQRXd1z+AoQ4tC5tqPk1_NQJohf6xwdEL=z9KgxHau2maQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4l2YrbNAM0o1NpA/"
Content-Disposition: inline
In-Reply-To: 
 <CAGECzQRXd1z+AoQ4tC5tqPk1_NQJohf6xwdEL=z9KgxHau2maQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y/V2m04KR6A0K29U%40paquier.xyz>
Precedence: bulk


--4l2YrbNAM0o1NpA/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 21, 2023 at 10:40:12AM +0100, Jelte Fennema wrote:
> The -Dcassert and -Db_coverage of the meson build didn't show in the
> docs that they needed to be passed true or false. All other options
> specified the arguments they expected. This patch fixes that.

Indeed, values have to be specified after the equal sign of each
option, so applied what you are suggesting here.

-Db_coverage is part of the core options of meson because it is not
listed in meson_options.txt, no?  Documenting the switch is fine, but
it seems like we lack contents here.  The paragraph describing
-Db_coverage links to regress-coverage, still this only has
instructions for ./configure.  Shouldn't we have some docs to show one
how to achieve the same with meson?  I'd guess that a separate section
for meson would make the most sense, for as long as we support both
methods in parallel.

https://wiki.postgresql.org/wiki/Meson tells nothing about that, for
one.
--
Michael

--4l2YrbNAM0o1NpA/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmP1dpsACgkQnvQgOdby
QH1k2BAAiMBAljK+F9igBOmSBxA9SAO+4Ym+w8w4FIPwCJXIGxAoLiEQjkKu0vp0
ER084AYb2Zp3CGZyClK7zNtojvmEi7wk9iccSmZZTjzsSrsu5UXOLxkjAbtj29ro
Yle3ozX4cW+Vr379jWXtmY/mZiSO08NJG67NJbWSvbomhoGspiYhZrFcR5czOmpn
mXhAZwPHRZhSQMIHp2gjjxbOlANDXm2BxC92nm3TATdbBYVpwPa66RlBFY0QNE86
dxMx5DcT+uaE0NKFAIHSNd6HF4GUWOYcw69RVySFUdZtk84Y2b7gYqPjk00aJtEi
ga1CoZYR6vsFL/KVQIiMAY7EYbX8+2MmpGcRkQYQdvw4ndNR4BmD/oc1wzYRUwAm
0NjlVDNT6R1Y0XAAu/qRR2fZ84Iz8wu7rFu1OQQZlDf1xnTpjpa1VdsaReG6FIgg
h8iWuO1M/OX+XHkOCtJ+zgFJQxeLotAPeRUMw9UcbRUV82NuK0cCNj6PQQ0kDKns
6u+KHy5SheEsdUDDshZm7vAuFnVTwKWndWeIBp972hlB9FQBEBzeVR59xnRvRiiO
EaMj4l7ysHU4oCN4/7CQTkt7uePwMMrIDXsHmaeRdHGOrFdd/MJzF22RpYKmMGt8
S5hZT1dlSDulSvUoWo+p+tZ6rvpaQF7q/f0S1iBsWDVzu0KUTcg=
=ljBC
-----END PGP SIGNATURE-----

--4l2YrbNAM0o1NpA/--