Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pS9eb-0008Ts-SS for pgsql-docs@arkaria.postgresql.org; Wed, 15 Feb 2023 04:44:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pS9ea-0000NF-Ii for pgsql-docs@arkaria.postgresql.org; Wed, 15 Feb 2023 04:44:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pS9eY-0000M0-V4 for pgsql-docs@lists.postgresql.org; Wed, 15 Feb 2023 04:44:24 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pS9eT-0007gk-N7 for pgsql-docs@lists.postgresql.org; Wed, 15 Feb 2023 04:44:22 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 969335C0105; Tue, 14 Feb 2023 23:44:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 14 Feb 2023 23:44:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1676436254; x=1676522654; bh=X1DrVUeTBa DrxA4mf66jwM53WjoR1Og5rC02AnSiVvo=; b=z9o1XnTTGKyeegIH7pcqpfdypE KsYFIMXRhaZTA9qr2+shOhPs+cw8FbF4AgDg7PZb7O/kUVWLs/chXm/jEdzBWL5a avcbHmnn2VfGwiz93N9cMRZ+3CRB0Pum1UDwnnnf9IUmQNtQD7DlzesdlMhbJS8n 0cfwt6jC3Md8yAIfxUpOlYrv7dFL1AS54T8aW9M9stRKq/yg+sTNv+BEYtijeNj9 oPOhlVUC1MfTMj4Kixcqwe3L5ycF5YTNSJHC8CGYZzGJd6wtup3vUp/t37ZlbQsf JJza6UUc3DetzINnYP1N+VVJ+P/YZlvm+zFzYIKNCQq9K7BX1Yv/L6bDppxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676436254; x=1676522654; bh=X1DrVUeTBaDrxA4mf66jwM53WjoR 1Og5rC02AnSiVvo=; b=rLqq9B39A3XkR51+J/D/PWcwA6Zw8OWcXvyMSgj3XGtg BxpxMHFWeSPgyj3n4M384m/tNp1/7smEx6ngiURD0VXunZgF8xyM3zoj2mvl2Jsq L5ynrPgXpTp4SmGTtqHE6P4QFgDjqk4+bs8Qi5AVYAk/ZH78YfyNYoRSM85CVYVZ /Y34oGyxjsGf0HlvqDaEJwx2NpCCeOuhEg9DZy9kXI1opAibHrDpWonaHTIRSBwX lx7jObk3eWAeypqRDBl2IRpuIazvnrmEjH88P9hC8c0bEtPu+Ta2rYHT0g2L0G2q yl4wsJA32u7Q4/5yAd29Cybpm+SVYzTfVIbYgfe8tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeigedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Feb 2023 23:44:12 -0500 (EST) Date: Wed, 15 Feb 2023 13:44:07 +0900 From: Michael Paquier To: Katsuragi Yuta Cc: pgsql-docs@lists.postgresql.org Subject: Re: meson doc: Is "-Dtap-tests" a typo? Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BmtILhNyC6bE3J5T" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --BmtILhNyC6bE3J5T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote: > The parameter name "-Dtap-tests" in the meson's doc seems to be a typo. > I think "-Dtap_tests" is the correct name. Attached patch fixes that. >=20 > I got an unknown options error by using "-Dtap-tests=3Denabled". However, > meson_options.txt told me the correct name was "-Dtap_tests". - + And meson.build refers to the same term, as of "tap_tests": # Check whether tap tests are enabled or not tap_tests_enabled =3D false tapopt =3D get_option('tap_tests') So you are indeed right. Nice catch. Will fix. -- Michael --BmtILhNyC6bE3J5T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPsYxcACgkQnvQgOdby QH3JeRAAksuzqShEJ0BxBYEPdn4KfQiSFHm9mkv2MmizzswDpl4Wzs2f3Y4UT1Ox ebqvtbrf/CFlkg7tfB5v1hAuxBDi3o52nRsvK08NvGjUuM+OH+fTOAU1TChHEzGm mZzplMvi2WpkqA8lrlZwQu8gN+CUyGjpx//xY+kFSKjp8LZtsFuZAppDBnVzqLl6 URSUCo1DaVx9AI581dHlH/m8sHZnvC+6+EXzBxDrmTCJHz7qOdYgKMqttuvDwjxD T3IX5/nxWVGgbkBdMsJg9qBEWzUF4aFgxC0vximHOXiC0JPanYsckuzYHh1XtvYL ZjsyvDqY03dYZ7ij0Pe2L+VIDWoXmZ3Aw6wyz+DCdhtriKQXEcC3oT6PSF8Wg+Ws +NHnZHRr/JPXerLY+7doykCES5F7Y8RIeY/rVKLuEcmr+Ulmmltvdj/DYQxrlI10 20JoN3RqMdYFTdA3IQSpixqX7vxd4DLeZpySEZo56tKgn2T8BCMN29qRpaWlGN9h lKhRAtCiecElCNypRfp/1RXSR0+7F9qQFK9a4kRd40sD8xljsnqGvAT57HkBFnrv EmLY8llkM23ogcMYxaK9WfNe88v/yyq8X9KkjScG4wdigJ03l73PZpXLNmMTW3qU FyO4UgHUczHBIndN/SQ01tf5j0azcf/Ob506sH8zBqYIyFR7BII= =DDEo -----END PGP SIGNATURE----- --BmtILhNyC6bE3J5T--