Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okVgV-00074L-LC for pgsql-docs@arkaria.postgresql.org; Mon, 17 Oct 2022 19:21:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1okVgU-0003HO-Bp for pgsql-docs@arkaria.postgresql.org; Mon, 17 Oct 2022 19:21:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okVgU-0003H9-4X for pgsql-docs@lists.postgresql.org; Mon, 17 Oct 2022 19:21:58 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okVgR-0003fX-MO for pgsql-docs@lists.postgresql.org; Mon, 17 Oct 2022 19:21:57 +0000 Received: from bruce by momjian.us with local (Exim 4.94.2) (envelope-from ) id 1okVgP-008Ysb-AM; Mon, 17 Oct 2022 15:21:53 -0400 Date: Mon, 17 Oct 2022 15:21:53 -0400 From: Bruce Momjian To: alex.denman@nih.gov, pgsql-docs@lists.postgresql.org Subject: Re: JSON/JSONB documentation, aggregate functions Message-ID: References: <166335888474.659.16897487975376230364@wrigleys.postgresql.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Oct 11, 2022 at 11:48:21AM -0400, Bruce Momjian wrote: > On Fri, Sep 16, 2022 at 08:08:04PM +0000, PG Doc comments form wrote: > > Regarding the Json documentation (9.16.1: processing and creating JSON > > data), I would like to suggest that the reference to > > json_agg/jsonb_agg/json_object_agg/jsonb_object_agg (section 9.21) be made > > more prominent. When looking through the list of json[b] processing > > functions, it's really easy to miss the footnote mentioning the aggregate > > functions. The list of functions in table 9.47 includes a lot of functions > > that are *really*similar in purpose to the json aggregator functions, and > > it's easy to assume that anything related to building JSON[B] objects *must* > > be listed there. I just spent hours searching for a way to turn one column > > of keys and one column of values into a JSONB object (without coercing all > > numeric values to json strings), and I can't imagine I'm the only one. > > I see your point --- that the aggregate sentence is at the end of the > section, after four massive tables. The attached patch moves the > paragraph up to the end of the section's introductory paragraph. Patch applied back to PG 10, thanks. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson