Date: Fri, 7 Oct 2022 09:35:49 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Erki Eessaar <erki.eessaar@taltech.ee>
Cc: "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>,
	Noah Misch <noah@leadboat.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: SQL-standard function bodies and creating SECURITY DEFINER
 routines securely
Message-ID: <Y0ArNYxcHbimR6zN@momjian.us>
References: 
 <AM9PR01MB8268BF5E74E119828251FD34FE409@AM9PR01MB8268.eurprd01.prod.exchangelabs.com>
 <Yvvw1JB/Y12HvAYn@momjian.us>
 <YzR/X5Hhyu4HaUj2@momjian.us>
 <AM9PR01MB8268FB1629B5AAF1680E0594FE5C9@AM9PR01MB8268.eurprd01.prod.exchangelabs.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <AM9PR01MB8268FB1629B5AAF1680E0594FE5C9@AM9PR01MB8268.eurprd01.prod.exchangelabs.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y0ArNYxcHbimR6zN%40momjian.us>
Precedence: bulk

On Fri, Oct  7, 2022 at 08:05:36AM +0000, Erki Eessaar wrote:
> Hello
> 
> I confirmed, that setting search_path is indeed sometimes needed in case of
> SECURITY DEFINER routines that have SQL-standard bodies. See an example at the
> end of the letter.
> 
> I suggest the following paragraph to the documentation:
> 
> Starting from PostgreSQL 14 SQL-standard bodies can be used in SQL-language
> functions. This form tracks dependencies between the function and objects used
> in the function body. However, there is still a possibility that such function
> calls other code that reacts to search path. Thus, as a best practice, SECURITY
> DEFINER functions with SQL-standard bodies should also override search_path.

I think this gets back to what Noah said about this section not needing
to explain all the details but rather give general guidance.  I am not
sure adding the reasons for _why_ you should use search path for
SQL-standard bodies is really adding anything.  Noah, is that accurate?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson